Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Justin Lai <justinlai0215@realtek.com>
To:     Jiri Pirko <jiri@resnulli.us>
CC:     "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver
Thread-Topic: [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver
Thread-Index: AQHZxeQMA/4O5CExTkOPXZ48NozVXK/XvyuAgADLZRD//4a2gIAJe5wQ
Date:   Wed, 9 Aug 2023 06:42:27 +0000
Message-ID: <b5462aca9d85452fa40dc7ee88bc8d26@realtek.com>
References: <20230803082513.6523-1-justinlai0215@realtek.com>
 <ZMtr+WbURFaynK15@nanopsycho> <14e094a861204bf0a744848cb30db635@realtek.com>
 <ZMuw2SuGZtVX42Nu@nanopsycho>
In-Reply-To: <ZMuw2SuGZtVX42Nu@nanopsycho>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

> Thu, Aug 03, 2023 at 03:20:46PM CEST, justinlai0215@realtek.com wrote:
> >Hi, Jiri Pirko
> >
> >Our device is multi-function, one of which is netdev and the other is
> character device. For character devices, we have some custom functions that
> must use copy_from_user or copy_to_user to pass data.
> 
> 1. Don't top post
> 2. That's nice you have it, but it is totally unacceptable. That's my
>    point. This is not about wrapping your out-of-tree driver and sending
>    it as is. You have to make sure you comply with the upstream code.
>    Which you don't, not even remotelly.

Thank you for your reply, I will refer to your suggestions to modify my code.