Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230807080726.7190-1-Wenhua.Lin@unisoc.com> <3554a99d-339f-39f9-111d-040025096f97@linux.alibaba.com>
In-Reply-To: <3554a99d-339f-39f9-111d-040025096f97@linux.alibaba.com>
From:   wenhua lin <wenhua.lin1994@gmail.com>
Date:   Wed, 9 Aug 2023 13:52:10 +0800
Message-ID: <CAB9BWhdh8CXuWAQGir=9QqLPdVaN8hgmqii9Da=buSj=9BWJaw@mail.gmail.com>
Subject: Re: [PATCH] serial: sprd: Support 12 uart ports
To:     Baolin Wang <baolin.wang@linux.alibaba.com>
Cc:     Wenhua Lin <Wenhua.Lin@unisoc.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

The change of the max ports is to adapt to an new
SPRD serial hardware,also is backward-compatibility with old hardware.

Baolin Wang <baolin.wang@linux.alibaba.com> =E4=BA=8E2023=E5=B9=B48=E6=9C=
=887=E6=97=A5=E5=91=A8=E4=B8=80 16:41=E5=86=99=E9=81=93=EF=BC=9A
>
>
>
> On 8/7/2023 4:07 PM, Wenhua Lin wrote:
> > From: Wenhua Lin <wenhua.lin@unisoc.com>
> >
> > Support 12 uart ports, which can solve the problem
> > of insufficient uart ports.
>
> This sounds incorrect to me.
> If this is a software bug, please add a Fixes tag to backport for stable
> kernels. If the change of the max ports is only avaliable on the new
> SPRD serial hardware, you should ensure the change is
> backward-compatibility with old hardware.
>
> > Signed-off-by: Wenhua Lin <wenhua.lin@unisoc.com>
> > ---
> >   drivers/tty/serial/sprd_serial.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd=
_serial.c
> > index b58f51296ace..2774df490899 100644
> > --- a/drivers/tty/serial/sprd_serial.c
> > +++ b/drivers/tty/serial/sprd_serial.c
> > @@ -22,7 +22,7 @@
> >   #include <linux/tty_flip.h>
> >
> >   /* device name */
> > -#define UART_NR_MAX          8
> > +#define UART_NR_MAX          12
> >   #define SPRD_TTY_NAME               "ttyS"
> >   #define SPRD_FIFO_SIZE              128
> >   #define SPRD_DEF_RATE               26000000