Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230728022447.1323563-1-namhyung@kernel.org> <ZMPMHNjX2IxsLbAe@kernel.org>
In-Reply-To: <ZMPMHNjX2IxsLbAe@kernel.org>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 9 Aug 2023 15:56:17 +0900
Message-ID: <CAM9d7cgqJatFn0tQVOxoQymFUruSzniPi5Okb1sotb6VLt+X_g@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] perf build: Update build rule for generated files
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org,
        Anup Sharma <anupnewsmail@gmail.com>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Arnaldo,

On Fri, Jul 28, 2023 at 11:09 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Jul 27, 2023 at 07:24:46PM -0700, Namhyung Kim escreveu:
> > The bison and flex generate C files from the source (.y and .l)
> > files.  When O= option is used, they are saved in a separate directory
> > but the default build rule assumes the .C files are in the source
> > directory.  So it might read invalid file if there are generated files
> > from an old version.  The same is true for the pmu-events files.
> >
> > For example, the following command would cause a build failure:
> >
> >   $ git checkout v6.3
> >   $ make -C tools/perf  # build in the same directory
> >
> >   $ git checkout v6.5-rc2
> >   $ mkdir build  # create a build directory
> >   $ make -C tools/perf O=build  # build in a different directory but it
> >                                 # refers files in the source directory
> >
> > Let's update the build rule to specify those cases explicitly to depend
> > on the files in the output directory.
> >
> > Note that it's not a complete fix and it needs the next patch for the
> > include path too.
>
> Applied, testing it on the container builds.

I don't see these commits in the perf-tools{,-next} yet.

Thanks,
Namhyung