Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Aug 2023 08:41:05 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Kent Gustavsson <kent@minoris.se>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Cosmin Tanislav <demonsingur@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        ChiYuan Huang <cy_huang@richtek.com>,
        Haibo Chen <haibo.chen@nxp.com>,
        Ramona Bolboaca <ramona.bolboaca@analog.com>,
        Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
        ChiaEn Wu <chiaen_wu@richtek.com>,
        William Breathitt Gray <william.gray@linaro.org>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] iio: adc: mcp3911: add support for the whole
 MCP39xx family
Message-ID: <ZNM1AYMB3RGRWp7C@gmail.com>
References: <20230808110432.240773-1-marcus.folkesson@gmail.com>
 <20230808110432.240773-4-marcus.folkesson@gmail.com>
 <ZNJP6xpOvRJigtMx@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="nrv095Qp/+mbQXwa"
Content-Disposition: inline
In-Reply-To: <ZNJP6xpOvRJigtMx@smile.fi.intel.com>
Precedence: bulk


--nrv095Qp/+mbQXwa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> ...
>=20
> > +#define MCP3910_OFFCAL(x)		(MCP3910_REG_OFFCAL_CH0 + x * 6)
>=20
> Inconsistent macro implementation, i.e. you need to use (x).

Sorry, I do not get you


[...]

> > +static int mcp3910_get_osr(struct mcp3911 *adc, int *val)
> > +{
> > +	int ret, osr;
>=20
> Strictly speaking osr can't be negative, otherwise it's a UB below.
>=20
> 	u32 osr =3D FIELD_GET(MCP3910_CONFIG0_OSR, *val);
> 	int ret;
>=20
> and why val is int?

I will change val to u32 for *_get_osr(), *_set_osr() and *_set_scale().

[...]

> > +	if (device_property_read_bool(&adc->spi->dev, "microchip,data-ready-h=
iz"))
>=20
> This also becomes shorter.
>=20
> One trick to make it even shorter:
>=20
> 	if (device_property_present(dev, "microchip,data-ready-hiz"))

Thank you, I wasn't aware of device_property_present().

[...]

>=20
> > +	dev_dbg(&spi->dev, "use device address %i\n", adc->dev_addr);
>=20
> Is it useful?

Yes, I think so.

>=20
> --=20
> With Best Regards,
> Andy Shevchenko
>=20
>=20

Best regards,
Marcus Folkesson

--nrv095Qp/+mbQXwa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmTTNPwACgkQiIBOb1ld
UjJMIxAA0ziqecFc2NsbIKI+ra1llKa2RMulAVXDaozUb6uMV+gwo5UN1ayLGuqv
asYAWxkaL0T/xTp86mrMNGFlvm+brllmsgmu72q4Xzclq5zJy7EEAnV8D/5OXGE2
xY63As3iX10rvdSYdIOCdm04M8//35jipJtSEUuUQ+wDx75tG7h1hUBjAdO6nru+
5hkplGFv6badZGHhfbglNxER17OSsK19uocXxxZyvynompHTwh2CdpHbwEjDt7Hw
bXf6C/sPdEPeEJyIc/bFAuIxaPy9ujcXgxxLNvybFtMz+nfd9wwFYhor7gj/xIac
Q/xF/7QuYrBSz1AHLImsFopyXto9LHQs4uFnuCnXvcFmnMUKLKt4M3b2pcsVG2hd
8WnRfx0TqKI0XpBA07+ePjJL3sXE4UatqNFFdvfV8UvU0IZc/6A2BIlknO83y1db
1bwV3Oqh8S7mUf6KVFm14ksaQS93Zrca05zLM4wh2cxg3ar0ASpqJreutsmdLJNI
3wG52RBw+uDIB+FXwRY5triNlb7xKWqKEMBHhJ0fdO3dyaKChfkAHxLqE2lALMnN
soAWus6zFpgfQyD9beC0jkn81o1xyME+Xwemv3ztcKD7ZSR5dfauejVIEV8OxCgg
yBC/BVlriluQtKeMDfXEzbiqlzOa/bK3j7ZdnnzTBP4khWpATyo=
=5dFK
-----END PGP SIGNATURE-----

--nrv095Qp/+mbQXwa--