Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230807122233.28563-1-yangyicong@huawei.com> <ZNL9s92HjLy+MZTw@localhost>
In-Reply-To: <ZNL9s92HjLy+MZTw@localhost>
From:   Barry Song <21cnbao@gmail.com>
Date:   Wed, 9 Aug 2023 13:47:31 +0800
Message-ID: <CAGsJ_4z5kYWOa2L+BHypM4S6W_UhUfUe3wo2rwiy0u7Hf1Q5pw@mail.gmail.com>
Subject: Re: [PATCH] perf/smmuv3: Add platform id table for module auto loading
To:     Liang Li <liliang6@email.cn>
Cc:     Yicong Yang <yangyicong@huawei.com>, will@kernel.org,
        mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, jonathan.cameron@huawei.com,
        linuxarm@huawei.com, yangyicong@hisilicon.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 9, 2023 at 1:01=E2=80=AFPM Liang Li <liliang6@email.cn> wrote:
>
> On 2023-08-07 20:22, Yicong Yang <yangyicong@huawei.com> wrote:
> > From: Yicong Yang <yangyicong@hisilicon.com>
> >
> > On ACPI based system the device is probed by the name directly. If the
> > driver is configured as module it can only be loaded manually. Add the
> > platform id table as well as the module alias then the driver will be
> > loaded automatically by the udev or others once the device added.
> >
>
> Please consider revise the long log to clearly express the purpose of the
> changes in this patch:
>
> - What's the exact issue the patch is addressing
> - Why the changes in this patch can fix the issue or make something worki=
ng
> - Consider impact of the changes introduced by this patch
>
> These info may help reviewers and maintainers .. and yourself on code mer=
ge.

years ago, i found a good doc regarding this,
https://wiki.archlinux.org/title/Modalias

guess it is because /lib/modules/$(uname -r)/modules.alias fails to contain=
 smmu
driver without the MODULE_DEVICE_TABLE, isn't it, yicong=EF=BC=9F

>
> Regards.
>

Thanks
Barry