Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Liu, Yi L" <yi.l.liu@intel.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        Nicolin Chen <nicolinc@nvidia.com>,
        Jason Gunthorpe <jgg@nvidia.com>
CC:     "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
Subject: RE: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested domain
Thread-Topic: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested domain
Thread-Index: AQHZvh/uqwr3PK6FO0KhG3jtetteiK/WrrGAgAhNwpCAANOqgIAAnN2AgABV8ACAAPYtAIAABp4Q
Date:   Wed, 9 Aug 2023 08:50:25 +0000
Message-ID: <DS0PR11MB7529C3646E38542457D7B75DC312A@DS0PR11MB7529.namprd11.prod.outlook.com>
References: <20230724111335.107427-1-yi.l.liu@intel.com>
 <20230724111335.107427-10-yi.l.liu@intel.com>
 <BN9PR11MB527690EBAA872A16AE8926F88C0BA@BN9PR11MB5276.namprd11.prod.outlook.com>
 <DS0PR11MB7529F4D4DABBE29E9B7BF5C9C30CA@DS0PR11MB7529.namprd11.prod.outlook.com>
 <ZNGypUee/U9d68TZ@Asurada-Nvidia> <ZNI2O4Upyna5AWDA@nvidia.com>
 <ZNJ+Uv/WJwngosjJ@Asurada-Nvidia>
 <BN9PR11MB5276BFFEC7E12EEBD4503BF08C12A@BN9PR11MB5276.namprd11.prod.outlook.com>
In-Reply-To: <BN9PR11MB5276BFFEC7E12EEBD4503BF08C12A@BN9PR11MB5276.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UyhUo+7O1nxwzv95vAkduJk1lmCPAPtqeTHt1wvNFq7MCpXYBulwk+P4rExP?=
 =?us-ascii?Q?bb/HjOjejQnE3B0AF1EbkpPgACEd6P/tej2iFXP7KLyImCemm5rIiTqyjbl7?=
 =?us-ascii?Q?Qul23DfE592BBxpnaesh4YahwndJnS4x0ByuUOzqpbvW3uwyhoYwN+Lwqj6d?=
 =?us-ascii?Q?gUGKaaa37IeiY/2mjPFl1taw4tYweZ3c8OKvhRw72Z9fs4EEi1R2DQs1TBT7?=
 =?us-ascii?Q?iGr8ZGz6G4Vm4O7iYeR2GalcTK5jNfw1A2K2puRiKrZFRrfSd8VXEX7Fv65R?=
 =?us-ascii?Q?MeKUMG8joTaybE073My8g+8rJdQFdeXrc0piC+wwedXucq8wNTS5W4YFkAs8?=
 =?us-ascii?Q?5yVYltQsWe5SXV5ZUwNHTdSi9ESujXyA5HU//L6V8bxQFtBy8IbWXosp/FrK?=
 =?us-ascii?Q?r8YgxG93hwefDWf2yREah17YXPCtSi8QRbfDYO3nYcPxhuIIcRzm4KY0b0qX?=
 =?us-ascii?Q?CYXyRz7OStQIcrStSIw0TpOWFRVVxZcM0Hl5NreIy9G2qQ+BuJ1Kdi1M3Eog?=
 =?us-ascii?Q?kSId0btXIagFLepk4W5hEWCT1S6xuHkWKii6hFY01AGXhPC7rjTUXERehq4E?=
 =?us-ascii?Q?RItMueUUD2fXx8ICNUWkMZIzLsqQoi1tIeKfJyVaWGa3p4BpntzI/kVKANHA?=
 =?us-ascii?Q?VTXQt7OtVAkhkEP5ea629fl2cKx1wek24sW47Mfgy+lXVTT2yVKWrQj4NKji?=
 =?us-ascii?Q?UNwGreXNlF54RkqHwiVN/qUS3b3zzIleNpORDmCmOjGyCaU4BbW+6v5H3YLB?=
 =?us-ascii?Q?igp7eLmn7cqODscd71hGo8vLkJcN7DdyokFDO2hQzsu9L+mAczjedCZdMeyt?=
 =?us-ascii?Q?aWy3NcawB5Y3H7ABNQeNnyfZm+cNwN9lOnpgtqzG7/jcdIUjXS6E+jxGVxwb?=
 =?us-ascii?Q?uN0kTaJUENs0SL+4zthoq6UelwhaaHVAO6L2I5OzJi7IxTQ8teBf1w0tsPjA?=
 =?us-ascii?Q?UbDipsoy/06Bd6DvkKd0drDf6cVJ/m9n4tVjhOn0LzrZJw/eEXUklVRHFCJD?=
 =?us-ascii?Q?PR5/D8EOfx06N8yOoXo80a3a8u1dEqBERXVN2UKiJD7tHD7Obx25m6rQXIjT?=
 =?us-ascii?Q?2Fid1xikuQAGG3DR7CMtk6sKlOvQJ4q3FlIvZLfnORR10P8J+AXwdol1Cy1i?=
 =?us-ascii?Q?+RtKT1CEZbvM3r/nEsvB679D5lY6JhhtPzpxKW1iNtZZNsXO4vGCG5Dg13Fj?=
 =?us-ascii?Q?l97RAOAs5MHN2Kwo19rUQ5R7ac8tH6qlkPlS/mqy1Evbbhx45wNDJ/G1qdAU?=
 =?us-ascii?Q?4Azbo6TBcqlfSkMnv0RwLJXYajtakNQq0WwZuIuXeFnl44Vd8Tfm9NWjZ43c?=
 =?us-ascii?Q?iyF1etF6aZvl+It59UwApnnvhRLLcOFOkBv5KpqWk+V3+Ukx31JVf+LmuY7/?=
 =?us-ascii?Q?jK5uX79YmJM2P631YyE7k+5DhVCd3jfm+UOf47GFntKEGdtaWNU1b9aHNJvO?=
 =?us-ascii?Q?bG5/DcUbNKm3LjpeH6P2hkuU04VRMDm2YpbMgI72arHx2MD+BtiQ+BuUHzBU?=
 =?us-ascii?Q?BYco1anK5tjtBhnD2e3w4Vw6n8UjDnHMKPR/U0/JAvL7x9O2npXzMLW5pQ?=
 =?us-ascii?Q?=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83f763ed-49db-45a2-334c-08db98b5acd5
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2023 08:50:25.9117
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mZCQ9xF7t4PUIBl+DeyYEaSBR3a6GUMuEw3L/kqSL2irOi3Su8SWv5N4KPL2jDvQtln9kF3jCr8aRFJ7Zc02lA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4875
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Tian, Kevin <kevin.tian@intel.com>
> Sent: Wednesday, August 9, 2023 4:23 PM
>=20
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Wednesday, August 9, 2023 1:42 AM
> >
> > On Tue, Aug 08, 2023 at 09:34:03AM -0300, Jason Gunthorpe wrote:
> > > On Mon, Aug 07, 2023 at 08:12:37PM -0700, Nicolin Chen wrote:
> > > > On Mon, Aug 07, 2023 at 03:08:29PM +0000, Liu, Yi L wrote:
> > > > > > > From: Liu, Yi L <yi.l.liu@intel.com>
> > > > > > > Sent: Monday, July 24, 2023 7:14 PM
> > > > > > >
> > > > > > > +static int intel_nested_cache_invalidate_user(struct
> > iommu_domain
> > > > > > > *domain,
> > > > > > > +                                         void *user_data)
> > > > > > > +{
> > > > > > > +   struct iommu_hwpt_vtd_s1_invalidate_desc *req =3D user_da=
ta;
> > > > > > > +   struct iommu_hwpt_vtd_s1_invalidate *inv_info =3D user_da=
ta;
> > > > > > > +   struct dmar_domain *dmar_domain =3D to_dmar_domain(domain=
);
> > > > > > > +   unsigned int entry_size =3D inv_info->entry_size;
> > > > > > > +   u64 uptr =3D inv_info->inv_data_uptr;
> > > > > > > +   u64 nr_uptr =3D inv_info->entry_nr_uptr;
> > > > > > > +   struct device_domain_info *info;
> > > > > > > +   u32 entry_nr, index;
> > > > > > > +   unsigned long flags;
> > > > > > > +   int ret =3D 0;
> > > > > > > +
> > > > > > > +   if (get_user(entry_nr, (uint32_t __user
> > *)u64_to_user_ptr(nr_uptr)))
> > > > > > > +           return -EFAULT;
> > > > > > > +
> > > > > > > +   for (index =3D 0; index < entry_nr; index++) {
> > > > > > > +           ret =3D copy_struct_from_user(req, sizeof(*req),
> > > > > > > +                                       u64_to_user_ptr(uptr =
+ index *
> > > > > > > entry_size),
> > > > > > > +                                       entry_size);
> > > > > >
> > > > > > If continuing this direction then the driver should also check =
minsz etc.
> > > > > > for struct iommu_hwpt_vtd_s1_invalidate and
> > iommu_hwpt_vtd_s1_invalidate_desc
> > > > > > since they are uAPI and subject to change.
> > > > >
> > > > > Then needs to define size in the uapi data structure, and copy si=
ze first
> > and
> > > > > check minsz before going forward. How about the structures for hw=
pt
> > alloc
> > > > > like struct iommu_hwpt_vtd_s1? Should check minsz for them as wel=
l?
> > > >
> > > > Assuming that every uAPI data structure needs a min_size, we can
> > > > either add a structure holding all min_sizes like iommufd main.c
> > > > or have another xx_min_len in iommu_/domain_ops.
> > >
> > > If driver is doing the copy it is OK that driver does the min_size
> > > check too
> >
> > Ah, just realized my reply above was missing a context..
> >
> > Yi and I are having a concern that the core iommu_hpwt_alloc()
> > and iommu_hwpt_cache_invalidate(), in the nesting series, copy
> > data without checking the min_sizes. So, we are trying to add
> > the missing piece into the next version but not sure which way
> > could be optimal.
> >
> > It probably makes sense to add cache_invalidate_user_min_len
> > next to the existing cache_invalidate_user_data_len. For the
> > iommu_hwpt_alloc, we are missing a data_len, as the core just
> > uses sizeof(union iommu_domain_user_data) when calling the
> > copy_struct_from_user().
> >
> > Perhaps we could add two pairs of data_len/min_len in the ops
> > structs:
> > 	// iommu_ops
> > 	const size_t domain_alloc_user_data_len; // for sanity&copy
> > 	const size_t domain_alloc_user_min_len; // for sanity only
> > 	// iommu_domain_ops
> > 	const size_t cache_invalidate_user_data_len; // for sanity&copy
> > 	const size_t cache_invalidate_user_min_len; // for sanity only
> >
>=20
> What about creating a simple array to track type specific len in
> iommufd instead of adding more fields to iommu/domain_ops?
> anyway it's iommufd doing the copy and all the type specific
> structures are already defined in the uapi header.

Then index the array with type value, is it? Seems like we have defined
such array before for the length of hwpt_alloc and invalidate structures.
but finally we dropped it the array may grow largely per new types.

>=20
> and a similar example already exists in union ucmd_buffer which
> includes type specific structures to avoid memory copy...

Not quite get here. ucmd_buffer is a union used to copy any user
data. But here we want to check the minsz of the the user data.
Seems not related.

Regards,
Yi Liu