Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] MIPS: Remove noreturn attribute for die()
To:     "Maciej W. Rozycki" <macro@orcam.me.uk>
References: <1690887599-11442-1-git-send-email-yangtiezhu@loongson.cn>
 <alpine.DEB.2.21.2308081544180.38537@angie.orcam.me.uk>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        loongson-kernel@lists.loongnix.cn
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <13aaa917-e55d-f529-8b3f-cab285402808@loongson.cn>
Date:   Wed, 9 Aug 2023 17:30:09 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2308081544180.38537@angie.orcam.me.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 08/08/2023 10:54 PM, Maciej W. Rozycki wrote:
> On Tue, 1 Aug 2023, Tiezhu Yang wrote:
>
>> If notify_die() returns NOTIFY_STOP, there is no need to call
>> make_task_dead(), we can remove noreturn attribute for die(),
>> this is similar with arm64, riscv and csky.
>
>  So you want to keep a task alive that has caused a kernel oops in the
> process context in this case, right?  What purpose would it be for and
> what condition causes `notify_die' to return NOTIFY_STOP?  IOW why is
> there no need to call `make_task_dead' in this case?
>
>   Maciej
>

I did some research, hope it is useful.

There is a related description in Documentation/input/notifier.rst:

   For each kind of event but the last, the callback may return
   NOTIFY_STOP in order to "eat" the event: the notify loop is
   stopped and the keyboard event is dropped.

In commit 748f2edb5271 ("x86 NMI: better support for debuggers"), it said:

   If the notify is handled with a NOTIFY_STOP return, the
   system is given a new lease on life.

In commit 004429956b48 ("handle recursive calls to bust_spinlocks()"),
it said:

   However, at least on i386 die() has been capable of returning
   (and on other architectures this should really be that way, too)
   when notify_die() returns NOTIFY_STOP.

In commit 22f5991c85de ("x86-64: honor notify_die() returning NOTIFY_STOP"),
it said:

   This requires making die() return a value, making its callers honor
   this (and be prepared that it may return)

In commit 620de2f5dc69 ("[IA64] honor notify_die() returning NOTIFY_STOP"),
it said:

   This requires making die() and die_if_kernel() return a value,
   and their callers to honor this (and be prepared that it returns).

Thanks,
Tiezhu