Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp5465459rwb; Wed, 9 Aug 2023 04:50:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIYrSfIY+iWDiBR53mSh4ysXwQB/JTBPlUhCr28jR2W9PJ9nUXeL1IGJdOQIJIfSV3xC/e X-Received: by 2002:a17:906:8468:b0:99b:cf7a:c8d4 with SMTP id hx8-20020a170906846800b0099bcf7ac8d4mr2003828ejc.18.1691581857597; Wed, 09 Aug 2023 04:50:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691581857; cv=none; d=google.com; s=arc-20160816; b=jGYNXPIeJ31OVCkJ57RAeWQSl8W4Z58hHnri7SjflWBusmlMlYc3GL9hK/jNrTdiDQ gbN0xxl2JSZuIRlu9ZLesNqufRfqXg06YqXU1qWAyWLq8TH00R9Wv9MzXfvJvpjywzWh HjaCcWGxJe2WM1V/4GymjrKCn2EnOXwFqn1uPMMVHjkedWUVQuvYhG2xQ/fKHV3L95gR rhBrvOQ4J267dvRLEeT2nDWsIq4geARv/ftGkPLm+6+zwXwf8CjFzW6TiuU6fVUlU1Co tMVepE6pSM29RUUEktnmuzQbibz6iadH3x0z15eWwXYqMpl3U08khqVVVdo8Jh462MMB FzQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qb4nHKrxyC/H/r7t0RxFzDn0koTqV/7wXf1V15k7Hew=; fh=OTwut3rX1eO1SWGtoSlZX6kpru3kHFlt4QBvnuPMVfw=; b=M5TuGJ9GzMPD+YNpBLbK8M35SBbFfGi/L8b0nu5R04NMEXPUdj28ly68vCtP+tnDDL 4ps/fh49R7pD4q3AUWASkGQ/hjBdTsHuwuenQzYZEdPI3sddqzhmqPx7cw0NXPtM9xYv r717Zsgiy/SbASUSxFSiI2ZG1Xv921fZxU2uoa00WxelaruUC0rxOnInOS+8lUsgGG/I zVM1RPFV4kgjEdVmqA/jYF/T2ccwTWZabf7mYaF6qvZuLcv6xZy6lmLgdfFnnQpRkOTW NYlea+ZLyHfdYMH3Sfr69NtPtp9Qvj13N3+VstxC8BGIuwJrwTUiKKYTnywVxKEgIhXf 8zWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="TcxvQ/e9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x15-20020a170906134f00b00993860a6d3bsi7948623ejb.518.2023.08.09.04.50.32; Wed, 09 Aug 2023 04:50:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="TcxvQ/e9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232103AbjHIJs6 (ORCPT + 99 others); Wed, 9 Aug 2023 05:48:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230245AbjHIJs6 (ORCPT ); Wed, 9 Aug 2023 05:48:58 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C53C1FD8; Wed, 9 Aug 2023 02:48:57 -0700 (PDT) Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3799dD4O030706; Wed, 9 Aug 2023 09:48:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=qb4nHKrxyC/H/r7t0RxFzDn0koTqV/7wXf1V15k7Hew=; b=TcxvQ/e9g6WSBD6Oor/Cn7PYvFVVJ5dJ6Vieu7DY1Stx/aNJqfYISYBG1fDL27yv+4v7 sc6TuYSezj+IlpR8ulldhBL5NeNST7UXi4TlXDxSGoSCUpKS7oE/ozRstDl9a95eVpJa CMeM6yGgoR+IuLRvq7m1V6mzfwaNH4CSlFbL8ld5K4G6sauyJ1AWZPWftr9B/u4Xqbck ZJehxCgULy3x/OJ7UfrtYT53xZyZIXq+STMEezCgWD6cwnyH/gT/pE8EhkbMfNRH7D0E DwQmSnkrcM5Su9WxjdLXvVzs6vtsMW2FmQfRCK71oDs8atlEzgIkdnAzmQins+lc26tr BA== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sc7rxs840-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Aug 2023 09:48:55 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3798FeNw006666; Wed, 9 Aug 2023 09:48:54 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3sa0rt7dt3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Aug 2023 09:48:54 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3799mpag9699906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Aug 2023 09:48:51 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A6D920043; Wed, 9 Aug 2023 09:48:51 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 073A020040; Wed, 9 Aug 2023 09:48:51 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 9 Aug 2023 09:48:50 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55669) id 9C731E0331; Wed, 9 Aug 2023 11:48:50 +0200 (CEST) From: Alexander Gordeev To: Jarkko Sakkinen , Mimi Zohar , Vasily Gorbik , Heiko Carstens Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-integrity@vger.kernel.org Subject: [PATCH] s390/ipl: fix virtual vs physical address confusion Date: Wed, 9 Aug 2023 11:48:50 +0200 Message-Id: <20230809094850.3918281-1-agordeev@linux.ibm.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 0ke9H2pObXFBjrAJT0zxT-N1B6DvKbz_ X-Proofpoint-ORIG-GUID: 0ke9H2pObXFBjrAJT0zxT-N1B6DvKbz_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-09_08,2023-08-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 impostorscore=0 suspectscore=0 priorityscore=1501 clxscore=1011 lowpriorityscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308090084 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix virtual vs physical address confusion (which currently are the same). Signed-off-by: Alexander Gordeev --- arch/s390/kernel/machine_kexec_file.c | 4 ++-- arch/s390/kernel/setup.c | 2 +- security/integrity/platform_certs/load_ipl_s390.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/s390/kernel/machine_kexec_file.c b/arch/s390/kernel/machine_kexec_file.c index 2df94d32140c..8d207b82d9fe 100644 --- a/arch/s390/kernel/machine_kexec_file.c +++ b/arch/s390/kernel/machine_kexec_file.c @@ -188,7 +188,7 @@ static int kexec_file_add_ipl_report(struct kimage *image, data->memsz = ALIGN(data->memsz, PAGE_SIZE); buf.mem = data->memsz; - ptr = (void *)ipl_cert_list_addr; + ptr = __va(ipl_cert_list_addr); end = ptr + ipl_cert_list_size; ncerts = 0; while (ptr < end) { @@ -200,7 +200,7 @@ static int kexec_file_add_ipl_report(struct kimage *image, addr = data->memsz + data->report->size; addr += ncerts * sizeof(struct ipl_rb_certificate_entry); - ptr = (void *)ipl_cert_list_addr; + ptr = __va(ipl_cert_list_addr); while (ptr < end) { len = *(unsigned int *)ptr; ptr += sizeof(len); diff --git a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c index 393dd8385506..c744104e4a9c 100644 --- a/arch/s390/kernel/setup.c +++ b/arch/s390/kernel/setup.c @@ -875,7 +875,7 @@ static void __init log_component_list(void) pr_info("Linux is running with Secure-IPL enabled\n"); else pr_info("Linux is running with Secure-IPL disabled\n"); - ptr = (void *) early_ipl_comp_list_addr; + ptr = __va(early_ipl_comp_list_addr); end = (void *) ptr + early_ipl_comp_list_size; pr_info("The IPL report contains the following components:\n"); while (ptr < end) { diff --git a/security/integrity/platform_certs/load_ipl_s390.c b/security/integrity/platform_certs/load_ipl_s390.c index e769dcb7ea94..6723ba9f9ca4 100644 --- a/security/integrity/platform_certs/load_ipl_s390.c +++ b/security/integrity/platform_certs/load_ipl_s390.c @@ -23,7 +23,7 @@ static int __init load_ipl_certs(void) if (!ipl_cert_list_addr) return 0; /* Copy the certificates to the system keyring */ - ptr = (void *) ipl_cert_list_addr; + ptr = __va(ipl_cert_list_addr); end = ptr + ipl_cert_list_size; while ((void *) ptr < end) { len = *(unsigned int *) ptr; -- 2.39.2