Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Aug 2023 15:41:01 +0530
From:   Dhruva Gole <d-gole@ti.com>
To:     Tony Lindgren <tony@atomide.com>
CC:     <linux-omap@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Keerthy <j-keerthy@ti.com>, Kevin Hilman <khilman@baylibre.com>,
        Nishanth Menon <nm@ti.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] bus: ti-sysc: Fix a build warning with W=1 for sysconfig
Message-ID: <20230809101101.7pbe7fhrlfcblcqk@dhruva>
References: <20230809095633.34025-1-tony@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230809095633.34025-1-tony@atomide.com>
Precedence: bulk

On Aug 09, 2023 at 12:56:33 +0300, Tony Lindgren wrote:
> Dhruva reported a build warning with W=1 for "Function parameter or member
> 'sysconfig' not described in 'sysc'". Let's document sysconfig to fix this.
> 
> Reported-by: Dhruva Gole <d-gole@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---

Probably best to include a Fixes: commit no?

>  drivers/bus/ti-sysc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -109,6 +109,7 @@ static const char * const clock_names[SYSC_MAX_CLOCKS] = {
>   * @cookie: data used by legacy platform callbacks
>   * @name: name if available
>   * @revision: interconnect target module revision
> + * @sysconfig: saved sysconfig register value
>   * @reserved: target module is reserved and already in use
>   * @enabled: sysc runtime enabled status
>   * @needs_resume: runtime resume needed on resume from suspend
> -- 
> 2.41.0

-- 
Best regards,
Dhruva Gole <d-gole@ti.com>