Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Aug 2023 06:40:48 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Dhruva Gole <d-gole@ti.com>
CC:     Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Tony Lindgren <tony@atomide.com>,
        =?iso-8859-1?Q?Beno=EEt?= Cousson <bcousson@baylibre.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Vibhore Vardhan <vibhore@ti.com>, <linux-omap@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V3 1/2] dt-bindings: opp: Convert ti-omap5-opp-supply to
 json schema
Message-ID: <20230809114048.o3oadfytvxuxie7u@kobold>
References: <20230809023045.1870410-1-nm@ti.com>
 <20230809023045.1870410-2-nm@ti.com>
 <20230809044825.top2xma5meklzosc@dhruva>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230809044825.top2xma5meklzosc@dhruva>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 10:18-20230809, Dhruva Gole wrote:
> On Aug 08, 2023 at 21:30:44 -0500, Nishanth Menon wrote:
> > Rename ti-omap5-opp-supply to be bit more generic omap-opp-supply and
> > convert the free text binding to json-schema.
> > 
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> > Changes since V2:
> > - None.
> > 
> > V2: https://lore.kernel.org/r/20230801233341.1416552-2-nm@ti.com
> > V1: https://lore.kernel.org/all/20230724153911.1376830-5-nm@ti.com/
> >  .../bindings/opp/ti,omap-opp-supply.yaml      | 103 ++++++++++++++++++
> >  .../bindings/opp/ti-omap5-opp-supply.txt      |  63 -----------
> >  2 files changed, 103 insertions(+), 63 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml b/Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
> > new file mode 100644
> > index 000000000000..4db80e418829
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
> > @@ -0,0 +1,103 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/opp/ti,omap-opp-supply.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Texas Instruments OMAP compatible OPP supply
> > +
> > +description:
> > +  OMAP5, DRA7, and AM57 family of SoCs have Class0 AVS eFuse registers which
> > +  contain data that can be used to adjust voltages programmed for some of their
> > +  supplies for more efficient operation. This binding provides the information
> > +  needed to read these values and use them to program the main regulator during
> > +  an OPP transitions.
> > +
> > +  Also, some supplies may have an associated vbb-supply which is an Adaptive Body
> > +  Bias regulator which much be transitioned in a specific sequence with regards
> 
> s/much/must ?

Thanks.
> 
> > +  to the vdd-supply and clk when making an OPP transition. By supplying two
> > +  regulators to the device that will undergo OPP transitions we can make use
> > +  of the multi regulator binding that is part of the OPP core described
> 
> Existing txt seems to have:
> 
>  part of the OPP core described here [1]
> 
> Why get rid of the reference "[1]" here?
> 
> Going through Documentation/devicetree/bindings/opp/opp-v2.yaml didn't
> tell me much about this multi regulator binding, I only see 1 example.
> 
> Please can you explain a bit more or make this line more clear?

Example 4 in the referenced binding does explain that - consumer
examples that are already documented does'nt make sense to be replicated
here. I will add a reference to opp-v2.yaml binding along with a pointer
to example 4.

> 
> > +  to describe both regulators needed by the platform.
> > +
> > +maintainers:
> > +  - Nishanth Menon <nm@ti.com>
> > +
> > +properties:
> > +  $nodename:
> > +    pattern: '^opp-supply(@[0-9a-f]+)?$'
> [...]
> 

Thanks for the detailed review. Will repost a new rev in a few days if
there are no further review comments.


-- 

Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D