Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp5546160rwb; Wed, 9 Aug 2023 06:01:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbcD34Iic7d0lW8aVH9ZHnXSVm9HXiImVZlQQr/DZXfF5CcjwOe/uikTPBlr8qlFfaOa9g X-Received: by 2002:a17:907:2e0d:b0:97e:aace:b6bc with SMTP id ig13-20020a1709072e0d00b0097eaaceb6bcmr1980828ejc.53.1691586065836; Wed, 09 Aug 2023 06:01:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691586065; cv=none; d=google.com; s=arc-20160816; b=JVdFY3CAEFll885JOQFS1/BUeRHuYC72sbJ+12VGTMqNbtJL/WP46LSGCPRY3gEbA1 upGwgOXDA592es5j8y/DsjMpKWopXzjTlmOnnJlCD/35uT+3urc6nO4KtMhTnOZ3Mk79 715tayjQwGOad4Jr3pgFwQbwDfZqiFQZ6rW7jN0/YY2y+g9n8mOignID2IxbwO5lIhdS LLKlcPE0+SwwSDSQGvV7D4lSxYQwxLfDpDcPK5Ev3KEMy6Cgc+VgZ90DP8jhUwO2os8s WgsaC5VId3BboAr5++VY2USrS03jpU6cVxHo9gOU7wyzM6yyVfkv7YMMhs2I2ZCTuboI dfVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5dRhM0yl3Iy05eIKjSWgbotWCHR0gIQoYC8t7e1+HFQ=; fh=B21ZzlpOoaPuCsrz452JIwoCgKunLuYhawO8LC0uUiA=; b=arAU6b0ccHx9+5YyyaYIUHogZntSioxcMmCJ2CsKjiNcandkZzuYTfuUwL/9/sdbrF UOaL0Xy+3t2yFct5aoQ9yOpmrcPuyPot3UWMH/x0oD/Qi6WqIQgGqqieHTDJPiYd02Gr fu50SlqKHHGQnZPCHDOWLyhiaVdMSncInjkAA3Oezq9dvATcLPHJdUYdtzJs/8Hs/taq LqYpZDSmyv3Zk6gjmas/IlyGN50QyQczb+TiF1NmaFFFs9qNnfmBpIOZ/5OgpAbdSe9i rxs7zIAUOk2KvvkRpZYWW8VUQNR5nl5pZfPqe8wc63ULCgu5sZ//Ssd7dqF3ejIIFgSc WGYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Nz30+Gzh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bu24-20020a170906a15800b00988907e3aaesi8366398ejb.428.2023.08.09.06.00.39; Wed, 09 Aug 2023 06:01:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Nz30+Gzh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231748AbjHIMVc (ORCPT + 99 others); Wed, 9 Aug 2023 08:21:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230404AbjHIMV3 (ORCPT ); Wed, 9 Aug 2023 08:21:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B6F31BF7 for ; Wed, 9 Aug 2023 05:21:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1141363814 for ; Wed, 9 Aug 2023 12:21:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23921C433C8; Wed, 9 Aug 2023 12:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691583688; bh=lxZkcW9VfEj3r2MbCwShiHqYNarVQxG41BuXDQ8GgCU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nz30+GzhOTK9fL0ZJ4cTrBOZFLpZ3sdqUgow83Xco/6qcAjpScI44oujP/EGDCoOK XmpeKrDlZl9R9qbM4g+JiMlU4HuoWQ8mAj007vCUnbmbLznXwt6xJgqlSiqyzh7f9g VZD0jKqzQwv+NRSVcmaTbh1CdgVFCcONJiiTS8dM= Date: Wed, 9 Aug 2023 14:21:25 +0200 From: Greg KH To: Michael Straube Cc: philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: prefer strscpy over strncpy Message-ID: <2023080952-maroon-waviness-9621@gregkh> References: <20230805075114.15186-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230805075114.15186-1-straube.linux@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 05, 2023 at 09:51:14AM +0200, Michael Straube wrote: > Replace strncpy with strscpy in two places where the destination buffer > should be NUL-terminated. Found by checkpatch. > > WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 If a global search/replace could be done, it would have happend a long time ago. How was this tested? The functions work differently, are you sure there is no change in functionality here? thanks, greg k-h