Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <85118937-c5fe-8f5c-5033-285f67087f64@denx.de>
Date:   Wed, 9 Aug 2023 14:53:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: linux-next: build failure after merge of the leds-lj tree
Content-Language: en-US
To:     Stephen Rothwell <sfr@canb.auug.org.au>, Lee Jones <lee@kernel.org>
Cc:     Isai Gaspar <isaiezequiel.gaspar@nxp.com>, #@denx.de,
        Basically@denx.de, rewrite@denx.de, the@denx.de, driver@denx.de,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20230809131733.67238c8a@canb.auug.org.au>
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <20230809131733.67238c8a@canb.auug.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/9/23 05:17, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> FATAL: modpost: drivers/leds/leds-pca995x: sizeof(struct i2c_device_id)=32 is not a modulo of the size of section __mod_i2c__<identifier>_device_table=600.
> Fix definition of struct i2c_device_id in mod_devicetable.h
> 
> Presumably caused by commit
> 
>    ee4e80b2962e ("leds: pca995x: Add support for PCA995X chips")
> 
> I have reverted that commit for today.

Ah doh, the fix is trivial, proper patch is coming in a bit.

diff --git a/drivers/leds/leds-pca995x.c b/drivers/leds/leds-pca995x.c
index 3ac99a433fcd2..78215dff14997 100644
--- a/drivers/leds/leds-pca995x.c
+++ b/drivers/leds/leds-pca995x.c
@@ -187,7 +187,7 @@ static const struct of_device_id pca995x_of_match[] = {
         { .compatible = "nxp,pca9955b", .data = (void *)PCA995X_TYPE_B },
         {},
  };
-MODULE_DEVICE_TABLE(i2c, pca995x_of_match);
+MODULE_DEVICE_TABLE(of, pca995x_of_match);

  static struct i2c_driver pca995x_driver = {
         .driver = {