Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808232627.21168-1-rdunlap@infradead.org>
In-Reply-To: <20230808232627.21168-1-rdunlap@infradead.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 9 Aug 2023 09:05:06 -0400
Message-ID: <CADnq5_PkGDM0ig9-D3y1Z87EauYnAnteNqr=EewUjhVaCUFA7g@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: dmub_replay: don't use kernel-doc markers
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        kernel test robot <lkp@intel.com>,
        Leo Li <sunpeng.li@amd.com>,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Tue, Aug 8, 2023 at 7:26=E2=80=AFPM Randy Dunlap <rdunlap@infradead.org>=
 wrote:
>
> These functions don't use kernel-doc notation for comments so
> don't begin each comment block with the "/**" kernel-doc marker.
>
> This prevents a bunch of kernel-doc warnings:
>
> dmub_replay.c:37: warning: This comment starts with '/**', but isn't a ke=
rnel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> dmub_replay.c:37: warning: missing initial short description on line:
>  * Get Replay state from firmware.
> dmub_replay.c:66: warning: This comment starts with '/**', but isn't a ke=
rnel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> dmub_replay.c:66: warning: missing initial short description on line:
>  * Enable/Disable Replay.
> dmub_replay.c:116: warning: This comment starts with '/**', but isn't a k=
ernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> dmub_replay.c:116: warning: missing initial short description on line:
>  * Set REPLAY power optimization flags.
> dmub_replay.c:134: warning: This comment starts with '/**', but isn't a k=
ernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> dmub_replay.c:134: warning: missing initial short description on line:
>  * Setup Replay by programming phy registers and sending replay hw contex=
t values to firmware.
> and 10 more similar warnings.
>
> Fixes: c7ddc0a800bc ("drm/amd/display: Add Functions to enable Freesync P=
anel Replay")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: lore.kernel.org/r/202308081459.US5rLYAY-lkp@intel.com
> Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Christian K=C3=B6nig <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: dri-devel@lists.freedesktop.org
> ---
>  drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c |   18 ++++++-------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff -- a/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c b/drivers/gpu/=
drm/amd/display/dc/dce/dmub_replay.c
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c
> @@ -33,7 +33,7 @@
>
>  #define MAX_PIPES 6
>
> -/**
> +/*
>   * Get Replay state from firmware.
>   */
>  static void dmub_replay_get_state(struct dmub_replay *dmub, enum replay_=
state *state, uint8_t panel_inst)
> @@ -62,7 +62,7 @@ static void dmub_replay_get_state(struct
>         }
>  }
>
> -/**
> +/*
>   * Enable/Disable Replay.
>   */
>  static void dmub_replay_enable(struct dmub_replay *dmub, bool enable, bo=
ol wait, uint8_t panel_inst)
> @@ -112,7 +112,7 @@ static void dmub_replay_enable(struct dm
>
>  }
>
> -/**
> +/*
>   * Set REPLAY power optimization flags.
>   */
>  static void dmub_replay_set_power_opt(struct dmub_replay *dmub, unsigned=
 int power_opt, uint8_t panel_inst)
> @@ -130,7 +130,7 @@ static void dmub_replay_set_power_opt(st
>         dm_execute_dmub_cmd(dc, &cmd, DM_DMUB_WAIT_TYPE_WAIT);
>  }
>
> -/**
> +/*
>   * Setup Replay by programming phy registers and sending replay hw conte=
xt values to firmware.
>   */
>  static bool dmub_replay_copy_settings(struct dmub_replay *dmub,
> @@ -215,7 +215,7 @@ static bool dmub_replay_copy_settings(st
>         return true;
>  }
>
> -/**
> +/*
>   * Set coasting vtotal.
>   */
>  static void dmub_replay_set_coasting_vtotal(struct dmub_replay *dmub,
> @@ -234,7 +234,7 @@ static void dmub_replay_set_coasting_vto
>         dm_execute_dmub_cmd(dc, &cmd, DM_DMUB_WAIT_TYPE_WAIT);
>  }
>
> -/**
> +/*
>   * Get Replay residency from firmware.
>   */
>  static void dmub_replay_residency(struct dmub_replay *dmub, uint8_t pane=
l_inst,
> @@ -267,7 +267,7 @@ static const struct dmub_replay_funcs re
>         .replay_residency               =3D dmub_replay_residency,
>  };
>
> -/**
> +/*
>   * Construct Replay object.
>   */
>  static void dmub_replay_construct(struct dmub_replay *replay, struct dc_=
context *ctx)
> @@ -276,7 +276,7 @@ static void dmub_replay_construct(struct
>         replay->funcs =3D &replay_funcs;
>  }
>
> -/**
> +/*
>   * Allocate and initialize Replay object.
>   */
>  struct dmub_replay *dmub_replay_create(struct dc_context *ctx)
> @@ -293,7 +293,7 @@ struct dmub_replay *dmub_replay_create(s
>         return replay;
>  }
>
> -/**
> +/*
>   * Deallocate Replay object.
>   */
>  void dmub_replay_destroy(struct dmub_replay **dmub)