Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9d109a43-78a3-dee4-5aaa-385bdfe4bcb3@redhat.com>
Date:   Wed, 9 Aug 2023 16:00:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] Multi-gen LRU: skip CMA pages when they are not eligible
Content-Language: en-US
To:     Charan Teja Kalla <quic_charante@quicinc.com>,
        akpm@linux-foundation.org, zhaoyang.huang@unisoc.com,
        yuzhao@google.com, surenb@google.com, kaleshsingh@google.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <1691568344-13475-1-git-send-email-quic_charante@quicinc.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <1691568344-13475-1-git-send-email-quic_charante@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09.08.23 10:05, Charan Teja Kalla wrote:
> This patch is based on the commit 5da226dbfce3("mm: skip CMA pages when
> they are not available") which skips cma pages reclaim when they are not
> eligible for the current allocation context. In mglru, such pages are
> added to the tail of the immediate generation to maintain better LRU
> order, which is unlike the case of conventional LRU where such pages are
> directly added to the head of the LRU list(akin to adding to head of the
> youngest generation in mglru).
> 
> No observable issue without this patch on MGLRU, but logically it make
> sense to skip the CMA page reclaim when those pages can't be satisfied
> for the current allocation context.
> 
> Signed-off-by: Charan Teja Kalla <quic_charante@quicinc.com>
> ---
>   mm/vmscan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b4329f9..6cbe921 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4943,7 +4943,7 @@ static bool sort_folio(struct lruvec *lruvec, struct folio *folio, struct scan_c
>   	}
>   
>   	/* ineligible */
> -	if (zone > sc->reclaim_idx) {
> +	if (zone > sc->reclaim_idx || skip_cma(folio, sc)) {
>   		gen = folio_inc_gen(lruvec, folio, false);
>   		list_move_tail(&folio->lru, &lrugen->folios[gen][type][zone]);
>   		return true;

Makes sense to me.

-- 
Cheers,

David / dhildenb