Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp71605rwl; Wed, 9 Aug 2023 11:04:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFYAfeaoNsQhlKVcMBANCAmG7aO5laqtA6iTvgvHkdlnIoKszc8l4t75qLgyeahKyKWjnHO X-Received: by 2002:a05:6830:4d8:b0:6b7:56d9:533 with SMTP id s24-20020a05683004d800b006b756d90533mr3498812otd.28.1691604296271; Wed, 09 Aug 2023 11:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691604296; cv=none; d=google.com; s=arc-20160816; b=ef9zlQmEJDM/bZsuwARNrUNI1ZyiWjuwxTTats/fY6DjB3w5XooUCE9C8e4GBBhN6+ 3meTF0xPMEaA+yjGiVG03LSU/Da5SDF3MIDQtZ2jjg+PnUgP7dCd5MJN9vLjRGb7vbq4 wxw6OhUWG5eM46yuRX4kAyHJ8u9YxIkBHM5TzS3i4Tto6vOgUGnKFew/IplchKZMtINf MX25APWCl3J9DDEYqe+eNwcHvBWUyVkwI1yN+YKUv21f1Q33uF3LrSyq9+tJtNpFxp/w Whx9zz8FOpFry1j17Z0p6PYtjolcO8g8tjjaZaJ5+LO6Y/SN3tJg4FZZSEa2VObHMJ2A 6Dig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XTEsQP1+0iumF877RP4qQLHej8hsu/9BpYuUN5Y2adY=; fh=xltAmSPd/yLdUi9FHi45DAi3RH3y0htPE7VC5DZecA8=; b=dhsVvbR6KNJuMhm4BijW/SK5tgeOliztJ0YknqZhLF9mUgrrW4ZNoDth+3wmcfP4wy 7WteTQlHpSwAH6CYrsQ99TNgxe4+K95X/bMS77PSNlIFE1/j63SNuQlYZB0escddQtb2 dRQgBVY16FqEB21PwDQoXkaaAc9xPkH2mJMmcw7Y9fvbHjV5WoSmOk4rSQ1c04PBZ7BZ ZPU3u5VFkPz80iKkWEhaFabW51imqu0TWEQss2ZdF4odNt3VEcYRWlm8Cv6JMN/fqdPT wGTpo374gU1pzCx1rcHgZDvx7mwflQv7Dvs5hqsmE902e9Al4+fiEhyTOfc8MnXJAhuJ +8DA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=JzlC8Zw9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a634d07000000b0055b57fc53a6si9665395pgb.540.2023.08.09.11.04.43; Wed, 09 Aug 2023 11:04:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=JzlC8Zw9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232244AbjHIQ7q (ORCPT + 99 others); Wed, 9 Aug 2023 12:59:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjHIQ7p (ORCPT ); Wed, 9 Aug 2023 12:59:45 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D86341BFE for ; Wed, 9 Aug 2023 09:59:44 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6bca3588edbso23437a34.0 for ; Wed, 09 Aug 2023 09:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1691600384; x=1692205184; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XTEsQP1+0iumF877RP4qQLHej8hsu/9BpYuUN5Y2adY=; b=JzlC8Zw9WKivJVxz26FYwqB80WVfFZ6RDiS980y67gmTTNuF7ER+yz08CPVwASwoZM gKYV7BCMOa6zNvbbVCtWaxGDgfUkQ9qJmez94gYiktjPGpOmDjgkfsHiHTTFp/8xFTtf DlOmv8AX5zaHS9ih6o9Q7j0FIxPpPFcT2fnBsU92+V4kJRCVEuLVp/fzvl2N0bIbpxi6 SuCTNor5R/pwn+u0oZ2YrCPUsrqYNzRV60a1T/LCyNBE3osy8HyYLEJM9ZV1+buUemOe avfBcqa5N4koDm2vxcyUqsSN8QgDCc9kjJFkgFvPN3JjT8qwQuRMo89sT9Pij82iX2I+ 3NtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691600384; x=1692205184; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XTEsQP1+0iumF877RP4qQLHej8hsu/9BpYuUN5Y2adY=; b=OK1Q4jMSbLtBv9/R4lRVhDMoUsAVMd1gymwijMsq7THm0MTWlmsVteL5zIyWaEeLBK 4KOLYfOUKVuG1DnVgFetncU304rygsoBt0AS8njibiY7ao5fTHIZ+akMyzwy0FW5R/Sl vOO7VvSvVD2PgKRyowku5hv+5rKpNoVKgbtFOtS9HaYTOK4kWMcwI7mYWog8v9HLLs84 lDDsMFoiEk8phPJlV8hqMx84+eurEjp3Hrp4tPWebxofow75ekUHXxASDpqj6Xf8d5QT zniYaCfB7SmQj69gFJvRHyBwTs9xJ0/NEm6HjndK/7raH6VXG766CORs2r5MJYVlVMOX R96g== X-Gm-Message-State: AOJu0Yyru1RGZBlwJseC8RUkXb+yMm5UA0sz/lsPLwKQfhsXIwud+0OG akkaIO3ruJF0VE/5cfOzyPKWpQ== X-Received: by 2002:a05:6358:c18:b0:139:71af:ed0f with SMTP id f24-20020a0563580c1800b0013971afed0fmr2197432rwj.1.1691600384122; Wed, 09 Aug 2023 09:59:44 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id f6-20020ac81346000000b0040f200feb4fsm4152679qtj.80.2023.08.09.09.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 09:59:43 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qTmX8-00551w-Uh; Wed, 09 Aug 2023 13:59:42 -0300 Date: Wed, 9 Aug 2023 13:59:42 -0300 From: Jason Gunthorpe To: Lu Baolu Cc: Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Jean-Philippe Brucker , Nicolin Chen , Yi Liu , Jacob Pan , iommu@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/12] iommu: Remove unrecoverable fault data Message-ID: References: <20230727054837.147050-1-baolu.lu@linux.intel.com> <20230727054837.147050-4-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727054837.147050-4-baolu.lu@linux.intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 27, 2023 at 01:48:28PM +0800, Lu Baolu wrote: > The unrecoverable fault data is not used anywhere. Remove it to avoid > dead code. > > Suggested-by: Kevin Tian > Signed-off-by: Lu Baolu > --- > include/linux/iommu.h | 70 +------------------------------------------ > 1 file changed, 1 insertion(+), 69 deletions(-) Do we plan to bring this back in some form? A driver specific fault report via iommufd? Reviewed-by: Jason Gunthorpe Jason