Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp83726rwl; Wed, 9 Aug 2023 11:15:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNWljpgnE+MS/pI6Rwg0uQS5CXocioTnY80Dqe8LPsB7mew49kO3oZdghgW0lUlTT1s7OZ X-Received: by 2002:a17:906:2d4:b0:99b:56f1:3002 with SMTP id 20-20020a17090602d400b0099b56f13002mr3251757ejk.61.1691604928417; Wed, 09 Aug 2023 11:15:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691604928; cv=none; d=google.com; s=arc-20160816; b=eXdbt2x6XmBeIKebdTWM9vYyhMWnig7ac7KUUc+yQrRwUT6CCsrFG3DvX6OdhhDif/ rs6B1eD4G8Lef3e0DbbXLdaaF1Xckshq8Fg6NRyuqP2JEc92Gb5Um1CBkfruqoYRHsip uB6cADSQBGgTWmbLwu8RDXCCEHOjzSCg1JwEjBoOvM+l8MqOthAwTBS59ZeByLHID3Un rpvTPALJgU1ipkcDx3/Za1fpYHgdtedSiHI40B+kqzqb/WfZCMqt5AoiIwol8Faxy2Tc aAq6n2hJpWbgVxkx7L0hekOhqHutbxKhSBA5kYrJVNU0sLMSRlm6lbtOQyl0UQyE7C8+ uGDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=9yArT/awXRkYrPki92Zws/80hTWdY4r8NmlN6iV95PI=; fh=MQBorZxRJ/qy/Kbc8gESisNtRZE7x/JHoujroQErS0E=; b=BCkWgMHv2JoRRJ6rPMOsWnVOCEG19+EZsc3wxCortxWS4RnkLV6Hgh4EnBYWbxP7Bs bUkJsFxq4JHBFS7J4nDEAwQTDO/VQ4UIXj0+JjaDsu89qvuoub1Wz7xSEAfHgEnLlpIn i7s+WHtnGiPiJYrsycfXNoLWouaf3j150Ss5InIvn4VgOB5QumHzbNC4fcEo2DJhHCly Gcku/mXwFdCVNQ/utwAvqt69XChkEwOVMPxulM+MTxstiWsug77ZCyjEov2zEaATeiRq kQVW9Kwm0U7ENM9sxEOgqbPpAzDnhjpZ0kg/D1h0arg+TcP8jXv5E4VWcodv4yMkhW+Y 1Mjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v5-20020a170906380500b00992e2779596si8055781ejc.827.2023.08.09.11.14.40; Wed, 09 Aug 2023 11:15:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231971AbjHIRhU (ORCPT + 99 others); Wed, 9 Aug 2023 13:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230504AbjHIRhT (ORCPT ); Wed, 9 Aug 2023 13:37:19 -0400 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 015C410C0 for ; Wed, 9 Aug 2023 10:37:19 -0700 (PDT) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6873a30d02eso2986b3a.3 for ; Wed, 09 Aug 2023 10:37:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691602638; x=1692207438; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9yArT/awXRkYrPki92Zws/80hTWdY4r8NmlN6iV95PI=; b=jks9I40Mu3hsgme1eY9fqX8Uv4oV5A1l/I2D3q9XMC3+KCQDRaUE8TnTIkE+jQMa94 F7a0p4U9TpkQswhPv9XyYLPxEVxRgZ7do8nadjop7mj1XvqxpY4ZEjm8ZAdKP6OgqYuM 58s5eVTGm7lAJpqm17dKwyWkmraaNT2ENxfpBkRHbk1+OLG4X3vImO8bfS+rQJ4UlKxa V3llXeutWD/cKJa0pOYBCW3a0U5iaD8qeNOrRlRPlxrBsxwzDHVpsEW1efRFDRxBUEdo akXENIoMn69KesjUvSULvrihK/C4pvEM6y6O1eMQ4Ad+JMqMC8S6HSXVsuUqi1w0UP17 rreA== X-Gm-Message-State: AOJu0YxPIDnnz9aZrqGJuuDqkqfV6sXg/HBJKJb5yfRbtiey3jECiJyR aN6DCLb/7rkWzHnbuaE1T6aYIQ== X-Received: by 2002:a05:6a20:428a:b0:140:a25:1c1d with SMTP id o10-20020a056a20428a00b001400a251c1dmr3891567pzj.51.1691602638385; Wed, 09 Aug 2023 10:37:18 -0700 (PDT) Received: from localhost ([75.172.135.98]) by smtp.gmail.com with ESMTPSA id j21-20020a62b615000000b00687375d9135sm10158999pff.4.2023.08.09.10.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 10:37:17 -0700 (PDT) From: Kevin Hilman To: Tony Lindgren Cc: Dhruva Gole , Andrew Davis , Nishanth Menon , Tero Kristo , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Viresh Kumar , Praneeth Bajjuri , Dave Gerlach , Vibhore Vardhan , Georgi Vlaev Subject: Re: [PATCH V6 4/4] firmware: ti_sci: Introduce system suspend resume support In-Reply-To: <20230809072330.GB11676@atomide.com> References: <20230803064247.503036-1-d-gole@ti.com> <20230803064247.503036-5-d-gole@ti.com> <3882f0ac-b74c-6eb2-197c-34ca233cd7a3@ti.com> <20230803155541.nwsfwobfkbpefoyw@dhruva> <8c330bd9-5f4e-8cd0-ed02-c3a696d7473a@ti.com> <20230803160815.yfpkdfssv75d4inf@dhruva> <7ho7jifrda.fsf@baylibre.com> <20230808115403.dkz6ev5vc6bhcmzh@dhruva> <7httt9dq2x.fsf@baylibre.com> <20230809072330.GB11676@atomide.com> Date: Wed, 09 Aug 2023 10:37:17 -0700 Message-ID: <7ho7jgdsmq.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tony Lindgren writes: > * Kevin Hilman [230809 00:20]: >> To me, it sounds like you might want to use ->resume_early() or maybe >> ->resume_noirq() in the pinctrl driver for this so that IO isolation can >> be disabled sooner? > > For calls that need to happen just before the SoC is disabled or first > thing on resume path, cpu_cluster_pm_enter() and cpu_cluster_pm_exit() > notifiers work nice and allow distributing the code across the related > SoC specific code and device drivers. See for example the usage in > drivers/irqchip/irq-gic.c for CPU_CLUSTER_PM_ENTER. Indeed, this is an option too, but for things that already have "full" drivers (e.g. not an irqchip), they already have a full range of PM callbacks, and adding another set of callbacks/notifiers for cpu_pm_* is a bit clunky IMO. That being said, for things like this IO isolation stuff that is system-wide, and needs to happen very late in suspend (and/or very early in suspend), cpu_pm_ is worth considering if the same cannot be done with the normal PM callbacks. Kevin