Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c0798225-3d99-4c45-5637-55bfbf7b0c8b@ti.com>
Date:   Wed, 9 Aug 2023 12:01:27 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v5 0/6] arm64: ti: k3-am62: Add display support
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>, Aradhya Bhatia <a-bhatia1@ti.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Conor Dooley <conor+dt@kernel.org>,
        Will Deacon <will@kernel.org>,
        Francesco Dolcini <francesco@dolcini.it>,
        Devicetree List <devicetree@vger.kernel.org>,
        Linux Kernel List <linux-kernel@vger.kernel.org>,
        Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Rahul T R <r-ravikumar@ti.com>,
        Devarsh Thakkar <devarsht@ti.com>,
        Jai Luthra <j-luthra@ti.com>,
        Jayesh Choudhary <j-choudhary@ti.com>
References: <20230809084559.17322-1-a-bhatia1@ti.com>
 <20230809144005.n3uq5yjusrrtjhqz@churn>
From:   Andrew Davis <afd@ti.com>
In-Reply-To: <20230809144005.n3uq5yjusrrtjhqz@churn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/9/23 9:40 AM, Nishanth Menon wrote:
> On 14:15-20230809, Aradhya Bhatia wrote:
>> Hi all,
>>
>> The patch series adds DT nodes for Display SubSystem (DSS) and other
>> peripherals required to enable the HDMI audio and video on the AM625 SK,
>> AM62-LP SK, as well as the AM625 based Beagle-Play platforms. An HDMI
>> monitor can be connected to the boards for the audio/video outputs.
>>
>> The series adding the compatible and basic driver support[0] is in the
>> drm-misc-next and linux-next queues and is expected to be in the
>> mainline by v6.6-rc1. Patch 5/6 also requires Nishanth Menon's patch[1]
>> that introduces debounce select mux macros. This patch too is not in
>> v6.5-rc1 but has been picked up in ti-next[2] and hence, is present in
>> linux-next.
>>
>> Patches 4 and 5 have been picked up from TI's vendor tree[3] based off
>> linux-kernel v6.1.
>>
>> Regards
>> Aradhya
>>
>> Change Log:
>> V4 -> V5:
>>    - Cosmetic changes as suggested by Jayesh.
>>    - Fixed the mis-represented DSS VP1 clock, and added a
>>      fixed-factor-clock.
>>
>> V3 -> V4:
>>    - Added "Fixes" tag for patch 1/6.
>>    - Rebased to linux-next.
>>    - Enabled display at board level and disabled at SoC level.
>>    - Dropped OLDI pinmux configuration as OLDI output comes directly from
>>      the SoC and muxing is not required.
>>    - Squashed DSS pinmux patches into their platform specific HDMI
>>      support patches, because it did not make sense to have only one set
>>      of pinmux config separated in a patch.
>>
>> V2 -> V3:
>>    - Updated the compatible from "ti,am65x-dss" to "ti,am625-dss".
>>    - Peripheral nodes like HDMI TX, HDMI connector are now added to
>>      k3-am62x-sk-common.dtsi instead of k3-am625-sk.dts, in order to
>>      support AM62-LP SK-EVM as well.
>>    - Dropped the HDMI master clock node as it is not connected on the
>>      EVM, and should not have been added in the first place.
>>    - Re-worded and Re-ordered commits.
>>    - Dropped Rahul Ravikumar's R-bs because of the changes.
>>    - Added AM625 based Beagle-Play for HDMI support.
>>    - Added HDMI audio support as well.
>>
>> V1 -> V2:
>>   - Removed repetitive data in dss_ports
>>
>> V4: https://lore.kernel.org/all/20230807153307.22174-1-a-bhatia1@ti.com/
>> V3: https://lore.kernel.org/all/20230728173438.12995-1-a-bhatia1@ti.com/
>> V2: https://lore.kernel.org/all/20220505134303.23208-1-a-bhatia1@ti.com/
>> V1: https://lore.kernel.org/all/20220427090850.32280-1-a-bhatia1@ti.com/
>>
>> [0]: https://lore.kernel.org/all/20230616150900.6617-1-a-bhatia1@ti.com/
>> [1]: https://lore.kernel.org/all/20230619131620.3286650-1-nm@ti.com/
>> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/commit/?id=0bec3d7ecc7493b0e530f6f34539841ef6779006
>> [3]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/log/?h=ti-linux-6.1.y-cicd
>>
>>
>> Aradhya Bhatia (4):
>>    arm64: dts: ti: k3-am62x-sk-common: Update main-i2c1 frequency
>>    arm64: dts: ti: k3-am62-main: Add node for DSS
>>    arm64: dts: ti: k3-am62x-sk-common: Add HDMI support
>>    arm64: defconfig: Enable ITE_IT66121 HDMI transmitter
>>
>> Jai Luthra (1):
>>    arm64: dts: ti: am62x-sk: Add overlay for HDMI audio
>>
>> Nishanth Menon (1):
>>    arm64: dts: ti: k3-am625-beagleplay: Add HDMI support
>>
>>   arch/arm64/boot/dts/ti/Makefile               |   3 +
>>   arch/arm64/boot/dts/ti/k3-am62-main.dtsi      |  25 +++
>>   arch/arm64/boot/dts/ti/k3-am62.dtsi           |   8 +
>>   .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 150 ++++++++++++++++++
>>   .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi |  93 ++++++++++-
>>   .../boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso   |  40 +++++
>>   arch/arm64/configs/defconfig                  |   1 +
>>   7 files changed, 319 insertions(+), 1 deletion(-)
>>   create mode 100644 arch/arm64/boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso
>>
>>
>> base-commit: 71cd4fc492ec41e4acd85e98bbf7a13753fc1e03
>> -- 
>> 2.40.1
>>
> 
> Can you help cleanup the following before we start introducing new oldi
> and dss support? I am not sure if these were introduced due to yaml
> updates or something pre-existing.

This is a pre-existing issue. Lets not fault Aradhya nor hold back this
series for an issue we caused way back when initially adding AM65 support.

Just to help this along, I've gone and added the fix for these warnings
here[0][1].

Andrew

[0] https://lkml.org/lkml/2023/8/9/889
[1] https://lkml.org/lkml/2023/8/9/888

> 
> linux/build/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed:
> linux/build/arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed:
> linux/build/arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed:
> linux/build/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed:
> linux/build/arch/arm64/boot/dts/ti/k3-am654-base-board.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed:
> linux/build/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed:
>