Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9be10770-d3df-467e-0541-8839bcd22fee@quicinc.com>
Date:   Wed, 9 Aug 2023 22:51:54 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH RESEND] tty: serial: qcom-geni-serial: Poll primary
 sequencer irq status after cancel_tx
Content-Language: en-CA
To:     Hugo Villeneuve <hugo@hugovil.com>
CC:     <agross@kernel.org>, <bjorn.andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <gregkh@linuxfoundation.org>,
        <jirislaby@kernel.org>, <bartosz.golaszewski@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_msavaliy@quicinc.com>,
        <dianders@chromium.org>, <mka@chromium.org>, <swboyd@chromium.org>,
        <quic_vtanuku@quicinc.com>
References: <1691583100-15689-1-git-send-email-quic_vnivarth@quicinc.com>
 <20230809091951.fbcc682d00deacd4d7b55b44@hugovil.com>
From:   Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
In-Reply-To: <20230809091951.fbcc682d00deacd4d7b55b44@hugovil.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Thank you very much for the review...


On 8/9/2023 6:49 PM, Hugo Villeneuve wrote:
> On Wed,  9 Aug 2023 17:41:40 +0530
> Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> wrote:
>
>> TX is handled by primary sequencer. After cancelling primary command, poll
>> primary sequencer's irq status instead of that of secondary.
> Hi,
> it is not clear to me if this is a bug fix or an improvement?
This is a bug fix.
>
>> While at it, also remove a couple of redundant lines that read from IRQ_EN
>> register and write back same.
> This should go into a separate patch.

The changes were too close by so I wasn't sure it could be split into 2 
patches.

I see that the earlier patch has already been signed off by Greg. (I did 
a RESEND after realising that I had Bjorn Andersson's email address 
incorrect)

Will post another version if original patch doesn't get merged for any 
reason.

Thank you,

Vijay/


>
> Hugo Villeneuve.
>
>
>> Fixes: 2aaa43c70778 ("tty: serial: qcom-geni-serial: add support for serial engine DMA")
>> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
>> ---
>>   drivers/tty/serial/qcom_geni_serial.c | 7 ++-----
>>   1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
>> index 3ca5db2..b8aa4c1 100644
>> --- a/drivers/tty/serial/qcom_geni_serial.c
>> +++ b/drivers/tty/serial/qcom_geni_serial.c
>> @@ -591,7 +591,6 @@ static void qcom_geni_serial_stop_tx_dma(struct uart_port *uport)
>>   {
>>   	struct qcom_geni_serial_port *port = to_dev_port(uport);
>>   	bool done;
>> -	u32 m_irq_en;
>>   
>>   	if (!qcom_geni_serial_main_active(uport))
>>   		return;
>> @@ -603,12 +602,10 @@ static void qcom_geni_serial_stop_tx_dma(struct uart_port *uport)
>>   		port->tx_remaining = 0;
>>   	}
>>   
>> -	m_irq_en = readl(uport->membase + SE_GENI_M_IRQ_EN);
>> -	writel(m_irq_en, uport->membase + SE_GENI_M_IRQ_EN);
>>   	geni_se_cancel_m_cmd(&port->se);
>>   
>> -	done = qcom_geni_serial_poll_bit(uport, SE_GENI_S_IRQ_STATUS,
>> -					 S_CMD_CANCEL_EN, true);
>> +	done = qcom_geni_serial_poll_bit(uport, SE_GENI_M_IRQ_STATUS,
>> +					 M_CMD_CANCEL_EN, true);
>>   	if (!done) {
>>   		geni_se_abort_m_cmd(&port->se);
>>   		done = qcom_geni_serial_poll_bit(uport, SE_GENI_M_IRQ_STATUS,
>> -- 
>> 2.7.4
>>