Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1691568344-13475-1-git-send-email-quic_charante@quicinc.com>
 <9d109a43-78a3-dee4-5aaa-385bdfe4bcb3@redhat.com> <CAC_TJvckhxwz9TxXgMSaiihHddY+AnEGqjLxvO6qF0eqTb5U8Q@mail.gmail.com>
In-Reply-To: <CAC_TJvckhxwz9TxXgMSaiihHddY+AnEGqjLxvO6qF0eqTb5U8Q@mail.gmail.com>
From:   Yu Zhao <yuzhao@google.com>
Date:   Wed, 9 Aug 2023 11:09:16 -0600
Message-ID: <CAOUHufarW3utTCqk+tes-tbU7iRKCYa_GMZvSNxJrFRKWXMbWw@mail.gmail.com>
Subject: Re: [PATCH] Multi-gen LRU: skip CMA pages when they are not eligible
To:     Charan Teja Kalla <quic_charante@quicinc.com>
Cc:     David Hildenbrand <david@redhat.com>, akpm@linux-foundation.org,
        zhaoyang.huang@unisoc.com, surenb@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Kalesh Singh <kaleshsingh@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 9, 2023 at 9:54=E2=80=AFAM Kalesh Singh <kaleshsingh@google.com=
> wrote:
>
> On Wed, Aug 9, 2023 at 7:00=E2=80=AFAM David Hildenbrand <david@redhat.co=
m> wrote:
> >
> > On 09.08.23 10:05, Charan Teja Kalla wrote:
> > > This patch is based on the commit 5da226dbfce3("mm: skip CMA pages wh=
en
> > > they are not available") which skips cma pages reclaim when they are =
not
> > > eligible for the current allocation context. In mglru, such pages are
> > > added to the tail of the immediate generation to maintain better LRU
> > > order, which is unlike the case of conventional LRU where such pages =
are
> > > directly added to the head of the LRU list(akin to adding to head of =
the
> > > youngest generation in mglru).
> > >
> > > No observable issue without this patch on MGLRU, but logically it mak=
e
> > > sense to skip the CMA page reclaim when those pages can't be satisfie=
d
> > > for the current allocation context.
> > >
> > > Signed-off-by: Charan Teja Kalla <quic_charante@quicinc.com>
>
> Reviewed-by: Kalesh Singh <kaleshsingh@google.com>

Thanks, Charan! Do we need a "Fixes" tag?

> > > ---
> > >   mm/vmscan.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > > index b4329f9..6cbe921 100644
> > > --- a/mm/vmscan.c
> > > +++ b/mm/vmscan.c
> > > @@ -4943,7 +4943,7 @@ static bool sort_folio(struct lruvec *lruvec, s=
truct folio *folio, struct scan_c
> > >       }
> > >
> > >       /* ineligible */
> > > -     if (zone > sc->reclaim_idx) {
> > > +     if (zone > sc->reclaim_idx || skip_cma(folio, sc)) {
> > >               gen =3D folio_inc_gen(lruvec, folio, false);
> > >               list_move_tail(&folio->lru, &lrugen->folios[gen][type][=
zone]);
> > >               return true;
> >
> > Makes sense to me.