Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp177189rwl; Wed, 9 Aug 2023 12:50:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9XKutAjQ3VyyT4d7C/17XsQ30DXQJE9Nb9gHlT8LQG3rLUVInFnHkGISYJz3ikiQfxl9z X-Received: by 2002:a05:6a21:78a9:b0:140:56b6:4137 with SMTP id bf41-20020a056a2178a900b0014056b64137mr216400pzc.52.1691610619376; Wed, 09 Aug 2023 12:50:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691610619; cv=none; d=google.com; s=arc-20160816; b=P9WGhq9k5+yewsiWm9iL99WEFkD8f0zH8YohJT/tY7UY1sybl8x1UcN1v0vnpvGlw6 UoVKPSGHUGXa7uCxrt93CN8jtFflQkVIWQnKVMtNf/e9jpXyN7XRozxlyai/6ZRZ3Jt+ WpXDsG237L895YVLUYx8pw9eCvCPAD0c6hnT8ae45r45jIa3WkBIHuzJJ5xWaK4r5COw gqjAHP2vqEwOd/s9mFoFra+Fy7cpi4dy4tiwgjj9mEKgkIHlDoLyorWm7IoGd7I3JGIC TPIelLXYILE+ORw6mMv1Oi+Bi/xFiCWdfw3lxd8zpW2UopogcP9KCH5i6L78PVI5ugHj 3I9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=pwigRAFAXBRS5qA8koF+a3Bv4bIxzklMHFE/MHDH5ok=; fh=oTiZA3GfSarG/DyU8V/oC05yVJ1oAqQLF4AiyZszZOg=; b=IuSChi1d6OQFXZK7drlFHGbSOa0lpestdaqRqAioQC6r5/CF1V2oefknyt/yfJeASl CK/W4ihs4RH1MpL6aH80eYLr04SnQuTBHVSSsOQRSstLi4iZd9oATItgc+l+PRqi1HnX mZCRaWd4MZkVC9blm6SVZWJ0SBSnGkgyjUBbjUv+f6ci2zwvNU3ngTd4cHY8MoTMCTL+ hgkcB5EjigqQgTmg23eiT+Plzf/xOve9Kf1cP6IUwHXe4QDklYal3pPYRcjgwDK2JzTU 6UUw6rzMcBUCXZjpeXFE5XqsHnNabVSFI/n46+4PGETqw4f29fnXcMuyoTOOqwWU9Mbj tijw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=eve8xWI6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o5-20020a635a05000000b0054febdc8ea2si9194486pgb.87.2023.08.09.12.50.05; Wed, 09 Aug 2023 12:50:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=eve8xWI6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234059AbjHITZy (ORCPT + 99 others); Wed, 9 Aug 2023 15:25:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233979AbjHITZZ (ORCPT ); Wed, 9 Aug 2023 15:25:25 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93E7F3C0B; Wed, 9 Aug 2023 12:24:22 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3fbea147034so981065e9.0; Wed, 09 Aug 2023 12:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691609061; x=1692213861; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pwigRAFAXBRS5qA8koF+a3Bv4bIxzklMHFE/MHDH5ok=; b=eve8xWI6YnHpUf/J5yzVBAv9L32VRTQu2RRy55ESICy3heLY5wjsRCBsUTwOV3DU5S RuCionFHq2S5hlamn5nk6ivk3p0gmVeJ+eCiq+Xqw7QaNzDlrYseRS9kV/CMGJj0NxFi sbdZfU7tnEQJeXq10+Gdoo2VA/PqCsQcWRKfWM42VjSwhxIHTIIVYQPCmxnMpVB87b8Y kCeVz9UkLYW5mE8Q6sDwY3Yarv0X9Nv6frMTlyQfQH0DwfK7d2c5WpiX3LFQyZGnWWOT SZW4itQ8mKpbTItkwF2hiWAD3pjZF/Dl96mgbqt4oPYTJhFU++j3nNXv4pI9+OknbFwN 3JfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691609061; x=1692213861; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pwigRAFAXBRS5qA8koF+a3Bv4bIxzklMHFE/MHDH5ok=; b=iTCml0erA9YB7UZgHTupKSQHYt86tAM17z/9sgSIhZSzIfRuUD4pO/dpXToXEdr6XL bDT+6Hh/7LrtSGDvWlaHdKw4p/faRt+V2025NwRxCYcs8FfmLXxz5Qe3XSHIcnjHuhVS 0rGkxnBCzhlaggWm0xKpvv3oEtbKLTRVDB0hBizuwg3QxNdBRM5D+ycmFOqMY+lp70AQ sPa7dB5DLrb7q48uWirL+Nplipwer7A16oYolN2wyuEbwiVdRKuB0T43SNHg498OlteL ct3j5ONnXBvFpC5k2T8SGHB5g+YAGS5UpIbCkX2eTrvs02+ok/D1eT5Rp1gc6Ox2N1Rc ypmw== X-Gm-Message-State: AOJu0YxVmmPpHDPqJDNcLqOecG5WhZaVF6lcmys3mJjfWOQo53ZO1L02 /F6ie9dlUvTKGe72hTysNa4= X-Received: by 2002:a1c:7c0b:0:b0:3fd:e86b:f095 with SMTP id x11-20020a1c7c0b000000b003fde86bf095mr44652wmc.13.1691609060920; Wed, 09 Aug 2023 12:24:20 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id y9-20020a7bcd89000000b003fba6a0c881sm2776208wmj.43.2023.08.09.12.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 12:24:20 -0700 (PDT) From: Benjamin Bara Date: Wed, 09 Aug 2023 21:24:08 +0200 Subject: [PATCH v2 6/6] regulator: pca9450: register restart handlers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230809-pca9450-reboot-v2-6-b98b4f8139d5@skidata.com> References: <20230809-pca9450-reboot-v2-0-b98b4f8139d5@skidata.com> In-Reply-To: <20230809-pca9450-reboot-v2-0-b98b4f8139d5@skidata.com> To: Lee Jones , Thierry Reding , Jonathan Hunter , Tony Lindgren , Liam Girdwood , Mark Brown , Dmitry Osipenko , peng.fan@oss.nxp.com, rafael.j.wysocki@intel.com, Jerome Neanne Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Benjamin Bara X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Benjamin Bara The PCA9450 supports both, a warm and a cold reset. Implement both and register the respective handlers. Acked-by: Mark Brown Signed-off-by: Benjamin Bara --- drivers/regulator/pca9450-regulator.c | 59 +++++++++++++++++++++++++++++++++++ include/linux/regulator/pca9450.h | 7 +++++ 2 files changed, 66 insertions(+) diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c index 2ab365d2749f..86903d677bf6 100644 --- a/drivers/regulator/pca9450-regulator.c +++ b/drivers/regulator/pca9450-regulator.c @@ -38,6 +38,11 @@ struct pca9450 { int irq; }; +static inline struct pca9450 *dev_to_pca9450(struct device *dev) +{ + return dev_get_drvdata(dev); +} + static const struct regmap_range pca9450_status_range = { .range_min = PCA9450_REG_INT1, .range_max = PCA9450_REG_PWRON_STAT, @@ -219,6 +224,42 @@ static int pca9450_set_dvs_levels(struct device_node *np, return ret; } +static int pca9450_cold_reset(struct pca9450 *pca9450) +{ + int ret; + + ret = regmap_write(pca9450->regmap, PCA9450_REG_SWRST, + SWRST_RESET_COLD_LDO12); + if (ret) + return ret; + + /* t_RESTART is 250 ms. */ + mdelay(500); + return -ETIME; +} + +static int pca9450_warm_reset(struct pca9450 *pca9450) +{ + int ret; + + ret = regmap_write(pca9450->regmap, PCA9450_REG_SWRST, + SWRST_RESET_WARM); + if (ret) + return ret; + + /* t_RESET is 20 ms. */ + mdelay(50); + return -ETIME; +} + +static int pca9450_restart_handler(struct sys_off_data *data) +{ + int (*handler)(struct pca9450 *) = data->cb_data; + struct pca9450 *pca9450 = dev_to_pca9450(data->dev); + + return handler(pca9450); +} + static const struct pca9450_regulator_desc pca9450a_regulators[] = { { .desc = { @@ -845,6 +886,24 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) return PTR_ERR(pca9450->sd_vsel_gpio); } + ret = devm_register_cold_restart_handler(pca9450->dev, + pca9450_restart_handler, + pca9450_cold_reset); + if (ret) { + dev_err(&i2c->dev, "register cold restart handler failed: %d\n", + ret); + return ret; + } + + ret = devm_register_warm_restart_handler(pca9450->dev, + pca9450_restart_handler, + pca9450_warm_reset); + if (ret) { + dev_err(&i2c->dev, "register warm restart handler failed: %d\n", + ret); + return ret; + } + dev_info(&i2c->dev, "%s probed.\n", type == PCA9450_TYPE_PCA9450A ? "pca9450a" : "pca9450bc"); diff --git a/include/linux/regulator/pca9450.h b/include/linux/regulator/pca9450.h index 505c908dbb81..a72fd4942d5f 100644 --- a/include/linux/regulator/pca9450.h +++ b/include/linux/regulator/pca9450.h @@ -93,6 +93,13 @@ enum { PCA9450_MAX_REGISTER = 0x2F, }; +/* PCA9450 SW_RST bits */ +#define SWRST_NOACTION 0x00 +#define SWRST_RESET_REGS 0x05 +#define SWRST_RESET_COLD_LDO12 0x14 +#define SWRST_RESET_WARM 0x35 +#define SWRST_RESET_COLD 0x64 + /* PCA9450 BUCK ENMODE bits */ #define BUCK_ENMODE_OFF 0x00 #define BUCK_ENMODE_ONREQ 0x01 -- 2.34.1