Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Aug 2023 14:56:33 -0400
From:   Brian Masney <bmasney@redhat.com>
To:     Hugo Villeneuve <hugo@hugovil.com>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: ufs: core: convert to dev_err_probe() in
 hba_init
Message-ID: <ZNPhYRslrcwAHo3Y@brian-x1>
References: <20230808142650.1713432-1-bmasney@redhat.com>
 <20230808142650.1713432-2-bmasney@redhat.com>
 <20230808162929.a1b784ad42bd346cd87747b9@hugovil.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230808162929.a1b784ad42bd346cd87747b9@hugovil.com>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk

On Tue, Aug 08, 2023 at 04:29:29PM -0400, Hugo Villeneuve wrote:
> On Tue,  8 Aug 2023 10:26:49 -0400
> Brian Masney <bmasney@redhat.com> wrote:
> 
> > Convert ufshcd_variant_hba_init() over to use dev_err_probe() to avoid
> > log messages like the following on bootup:
> > 
> >     ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qcom init
> >         failed err -517
> > 
> > While changes are being made here, let's go ahead and clean up the rest
> > of that function.
> 
> Hi,
> you should not combine code cleanup and fixes/improvements in the same
> patch, split them.

This is a pretty simple patch as is, and split up the code clean up is
not very useful on its own. I'll just skip doing the code cleanup and
only post the dev_err_probe() change in v2.

Brian