Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp254798rwl; Wed, 9 Aug 2023 14:07:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrO/XkqcK3wM23IlmsowiusYWwxrFR19xEKJzxLDWmDZ4APvJCohQcdgypOvheaoM7LSB2 X-Received: by 2002:a17:907:7813:b0:99b:ef86:60d8 with SMTP id la19-20020a170907781300b0099bef8660d8mr214153ejc.5.1691615243278; Wed, 09 Aug 2023 14:07:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691615243; cv=none; d=google.com; s=arc-20160816; b=d0jsNRpNFad9HtEWBODSlADbhBpJd5873Vs0lEKI1kAN2Iz3DYquy7u7ZtDQtdW5UF 39enfWs/Ua/Q9yfX3SEg0/saVgsBwBNRPRG0VvYvN4zlRVdl2YbS2Rz44MATCYJ1pTqW zkRHr+PhYP+hxFMEWsl61zRNB6nGIpxgVQl6z4RJFl7LYUC7hX0JX+Eoo/56atQczrY3 9yc4PYrtnlIApAT/0BaNpqYD234HPodieKAxrCDJ3YnENg1RJ3sHUDvsgg/kXUAq73B7 meq8dEKnp20hr1+q0rGhO1TSGXlsHoow5Z5VsdryQloueGWG8wt4Iv+SX+cI4bvFowPL ID8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=8OHWJKRmAIE6jl+hVx/FmYwIb5ABf5W2LsIv6XGHMyA=; fh=q+idgjsNOfSeB0DE+ldLVkxZV9h+m6OLm8KWzgZjrCg=; b=AEDrdk4P2NZIE41vitbO4KuTMpiIpuKt9vO5hKcTrTRncWxJN9G+Y+TUGkI4Rj0wIz PUDhNJDYZnlQF6XlP095edEDZQk+C+UGhHEaVGWZ1RXd8nTtblXgv4rbm91Mpi6EUnsy 5hC8v/yHdRu07HhE/8JBvJXRebgP0CTRPN631uzbmzbcolN4h32yzEfGGMBOdeAGD3dH /gyraqANZEQr/2fFIh/5Gkb7p6fofDYw7F79TO93cIjXXj7d3CcM30qXmv9LbD8hnWxW F+Vfp7pmRP+Beas9w6zPaUL9QZh+0q7PWydbMIMkKuFerR8XWJPW5MPifybayIhvZOt3 H6Zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i17-20020a17090685d100b00992d730e99dsi14786ejy.494.2023.08.09.14.06.50; Wed, 09 Aug 2023 14:07:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234191AbjHIUUI (ORCPT + 99 others); Wed, 9 Aug 2023 16:20:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbjHIUUH (ORCPT ); Wed, 9 Aug 2023 16:20:07 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82DE010E9; Wed, 9 Aug 2023 13:20:06 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qTpey-0001b4-B2; Wed, 09 Aug 2023 22:20:00 +0200 Date: Wed, 9 Aug 2023 22:20:00 +0200 From: Florian Westphal To: Justin Stitt Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-hardening@vger.kernel.org, Kees Cook , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/7] netfilter: x_tables: refactor deprecated strncpy Message-ID: <20230809202000.GB3325@breakpoint.cc> References: <20230809-net-netfilter-v2-0-5847d707ec0a@google.com> <20230809-net-netfilter-v2-6-5847d707ec0a@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230809-net-netfilter-v2-6-5847d707ec0a@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Justin Stitt wrote: > Prefer `strscpy_pad` to `strncpy`. I don't think this instance needs _pad.