Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp269542rwl; Wed, 9 Aug 2023 14:23:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFB3KA4rTunMzDgPCJrU90hg/Xn6Gc7txOxJIb8Jy1/C5mCC5DM1Z6GhDx5cwmlYqsfwfF X-Received: by 2002:a17:903:451:b0:1b8:a54c:6183 with SMTP id iw17-20020a170903045100b001b8a54c6183mr325367plb.46.1691616183559; Wed, 09 Aug 2023 14:23:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691616183; cv=none; d=google.com; s=arc-20160816; b=YGeMMwrKo1Ion0BspkzBeaZsOUVJJB6QLb02lT+73Puz6LY+08I1MVJPbCkS3fTMdR DdsI5ud0g4MNMBESRoy7L2fdVtUcTL3+9ro2VlbofS3guUWasJIKj9PVAtwM2giNlG+i WW2Kx66+HAgbu+RESyCajrgk+ELh1nU1GcI5kjC9rkVY0r0ElgVspojetqAqmfw8Z1cc u/7pRN8W7yGRIGni6uir3tj2Tdk6v49qhUQWpfA/4ek7VYkQ0iZSvXbGpz+3RY+Vyv/s AmlaiGeoWY9kAZ22DFyTHEKTvd/6viey791sLmd9RxPy6TuKZrmotP56wKxvwjf+g8mL ouig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=UMH5jLVsNNkJl0jCslb/zCh75K7YRzfuck1qaHYwcrY=; fh=q+idgjsNOfSeB0DE+ldLVkxZV9h+m6OLm8KWzgZjrCg=; b=paDMe0xEq8AzhxPSw5J0RXWZGWkeIRfy3Hy69YnTTcWAN2Xsk/IJ8hiE6JReJ6Bfi4 VZnKcOgKuHyKQ3uR3ztkn49d1t05VRiJMZaHkIdjNKSXxfNk5Exod7T5WeNnyLQdN6iC 1DD1uU3oR8EvrF80LAGcv0ubg6wClWkQIVB/PI6kWT8V1S1zcUQW8bIsYuFU/bS07kA5 YVseOdfcRneicKRgDrVuB+ctIFglSrdnAOKZlZNxXlPdE3cgNy/9YPgekemVg/ckzfX6 BLO3waPKbEaM5AODQ2LvKxz+o8pviptcFr9gGnnZN91DxcR6r5fSh9OBCfvpbPUbZo2b 7qhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id le11-20020a170902fb0b00b001bb053dc947si2832plb.177.2023.08.09.14.22.49; Wed, 09 Aug 2023 14:23:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234151AbjHIUTp (ORCPT + 99 others); Wed, 9 Aug 2023 16:19:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbjHIUTo (ORCPT ); Wed, 9 Aug 2023 16:19:44 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A083E10E9; Wed, 9 Aug 2023 13:19:43 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qTpeQ-0001aG-Sr; Wed, 09 Aug 2023 22:19:26 +0200 Date: Wed, 9 Aug 2023 22:19:26 +0200 From: Florian Westphal To: Justin Stitt Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-hardening@vger.kernel.org, Kees Cook , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] netfilter: ipset: refactor deprecated strncpy Message-ID: <20230809201926.GA3325@breakpoint.cc> References: <20230809-net-netfilter-v2-0-5847d707ec0a@google.com> <20230809-net-netfilter-v2-1-5847d707ec0a@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230809-net-netfilter-v2-1-5847d707ec0a@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Justin Stitt wrote: > Use `strscpy_pad` instead of `strncpy`. I don't think that any of these need zero-padding.