Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Mirela Rabulea <mirela.rabulea@nxp.com>
To:     Ruan Jinjie <ruanjinjie@huawei.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "laurent.pinchart@ideasonboard.com" 
        <laurent.pinchart@ideasonboard.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] media: nxp: Remove redundant dev_err()
Thread-Topic: [PATCH -next] media: nxp: Remove redundant dev_err()
Thread-Index: AQHZywvETLV+48yXl0S/EZQMbgYN9A==
Date:   Wed, 9 Aug 2023 21:52:18 +0000
Message-ID: <AS4PR04MB92440C79E652C986413E88888F12A@AS4PR04MB9244.eurprd04.prod.outlook.com>
References: <20230727102154.2757410-1-ruanjinjie@huawei.com>
In-Reply-To: <20230727102154.2757410-1-ruanjinjie@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tqpfWWZRBH1J8zDg8A6UT4KPWTQ0PesgR6LXL8Xc8hKiiMS4vlhiJz6ZiPsn?=
 =?us-ascii?Q?S8SfWamkIA8MbQxTYuJqIT1WWce3aKITJm3PWhW8lg46nEc22HhFd/6GO5qo?=
 =?us-ascii?Q?OcZdakIeacC81FN6BX7boNCfr0iDuzSDFo7kkljeCMboBAFzO8KAqJioLnRd?=
 =?us-ascii?Q?VHfMP3U0ASdkn8+MLb6+q6Ojmn8zBHc1OY9D5Hue5RVNDg2ey+wQ2wGJu+/8?=
 =?us-ascii?Q?MScKZr8Gbxuc8cu5HCQyAC7mT4/5y0O3UblyNru/lk+iefso+RO/TQrEEJdt?=
 =?us-ascii?Q?GjNIgZTmTzu5AGZApOm7k4D6Zw26RDKQdXzNhcz3YKizSQ15TzKEPbltrvp8?=
 =?us-ascii?Q?rWUsoaJ0c4qIsWsNuZLyIDQdsLBddu+Nt7BRrgQWJqXunhu4cyWRTL4TrmdJ?=
 =?us-ascii?Q?bBiFTxAOjLtQjDKyfoX50tC+XT+HrI31QsxsMR17r+worC33PrxkrH4Wker4?=
 =?us-ascii?Q?NJ5NioyvxmMmg+xQZOjRPV2qN9JInjDSBVoKBpFRSsH7LrUpOLXvjRgFk354?=
 =?us-ascii?Q?XfUnD3Ip3mVhscD9DP1pZQxpnKUep0i2alp1FJ0mfxfkUWihOvTTFHcjzxG7?=
 =?us-ascii?Q?9uYvvIJqDr0zGh/xTFEdXMzbiYESJBU7TgQ9kgp1YoTWmLu8e5wG8dBRLyXl?=
 =?us-ascii?Q?Ve+gGpZMrxoHBA+1YshBnZFoMTN6miups5iPDeQTnUhMJErhJSehOXdxLecX?=
 =?us-ascii?Q?JaIN1G2iumaFAQJQFbVSkv3QIpqzcffAg/0B+8H+UuElygNrQKotWCK9z/l8?=
 =?us-ascii?Q?G/xqixt1aHkBkVo4fUwhcXYLXU+X2zELeL7TV5fxItQG+hve4Ce4HsDM1OnZ?=
 =?us-ascii?Q?izuz2t+wwmMamH3MOfacntZppPseNWNomSHhHgmLYZq8kL7Bj5Yoxft/2Y7K?=
 =?us-ascii?Q?XCOgxLvWH4l9nN+o+mMVjSk5Nu0H7P0jVgrHV+rUhJQzxKs8ayH7Y+F/oUuD?=
 =?us-ascii?Q?kg4OeLMtmDaMsL48XkKxh5cRLYLLEJLVN+0YODtS3Xj7TRfLDH3veLqyBnzM?=
 =?us-ascii?Q?8aXSt24vc9cua3pKS9a39mrVpziBUmzfk0Yv5Y5dTChb5IlzOfF9yBJRRiZi?=
 =?us-ascii?Q?cBN8Bi0MKRlZR/tQ2zgFBZZEpy7IsQcr/KB4ANHTN4QkqtyqKBCdkdmbxuEt?=
 =?us-ascii?Q?0+MdmBVnBwtCzQi3mVrw1ogOdJrIpFhaC/lPQgK1t4x8noxp1GGG+wmiweI7?=
 =?us-ascii?Q?Pm+m9Cb7Pd0lq3uIiPd4ei2EOLKJ5CiOEOczVPt7c24Qp/+BdGTi7mx7mvj4?=
 =?us-ascii?Q?8kjhVq9HOqVqZlS4qRRUMwFRJTeHEYtVgd9PCNrUEbWT5MzSyq4Xq39ZnDyM?=
 =?us-ascii?Q?RZN3kRPj4ltL7RA0lqa0kSyxMCs1/ZXOloOEEC+a4+xdMW1COAYKhsaGJu0g?=
 =?us-ascii?Q?hZ1nG7xNS+ZkHsMCzN4S7Coyu6JUwyyUtLJZcVnZMGRQyTmkSPvClIgvdZqo?=
 =?us-ascii?Q?+jrxHA7M4oXNzi0pZc+A3ytWzN9Mv6YLRJrcF2AYTADvQkSF+KFSexrVEJJL?=
 =?us-ascii?Q?BIm4a+Xon+LgBNRkV8GAfH2SsdtsYi2TXcW0Gk6o7vQm2EbCg2uOg/HhJAjK?=
 =?us-ascii?Q?ZU7uKh593dUotZYC64WHft9JbKLOAUxJ9Du5W5mT?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS4PR04MB9244.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3457a962-5f5b-4206-bb90-08db9922e6b8
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2023 21:52:18.1590
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mUz9mK6aEm1fsSqNd/68SqKDlMjQc2xSh2DltakKvREwxSQHNqVPLlQEEaZ0BkvMdgHnE9YHR5uQOt3gZwwD8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8729
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Ruan Jinjie <ruanjinjie@huawei.com>
> Sent: Thursday, July 27, 2023 1:22 PM
> To: Mirela Rabulea <mirela.rabulea@nxp.com>; dl-linux-imx <linux-
> imx@nxp.com>; mchehab@kernel.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> laurent.pinchart@ideasonboard.com; linux-arm-kernel@lists.infradead.org;
> linux-media@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: ruanjinjie@huawei.com
> Subject: [PATCH -next] media: nxp: Remove redundant dev_err()
>=20
> There is no need to call the dev_err() function directly to print a custo=
m message
> when handling an error from platform_get_irq() function as it is going to=
 display
> an appropriate error message in case of a failure.
>=20
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Hi,
We have been using "media: imx-jpeg:" in the subject.
Other than that,
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>

Regards,
Mirela

> ---
>  drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c      | 1 -
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c | 1 -
>  2 files changed, 2 deletions(-)
>=20
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> index 9512c0a61966..b7a720198ce5 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> @@ -2742,7 +2742,6 @@ static int mxc_jpeg_probe(struct platform_device
> *pdev)
>         dev_info(&pdev->dev, "choose slot %d\n", jpeg->slot_data.slot);
>         dec_irq =3D platform_get_irq(pdev, 0);
>         if (dec_irq < 0) {
> -               dev_err(&pdev->dev, "Failed to get irq %d\n", dec_irq);
>                 ret =3D dec_irq;
>                 goto err_irq;
>         }
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> index c4454aa1cb34..65d20e9bae69 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> @@ -791,7 +791,6 @@ int mxc_isi_pipe_init(struct mxc_isi_dev *isi, unsign=
ed
> int id)
>=20
>         irq =3D platform_get_irq(to_platform_device(isi->dev), id);
>         if (irq < 0) {
> -               dev_err(pipe->isi->dev, "Failed to get IRQ (%d)\n", irq);
>                 ret =3D irq;
>                 goto error;
>         }
> --
> 2.34.1