Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759040AbXKARjs (ORCPT ); Thu, 1 Nov 2007 13:39:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758727AbXKARjf (ORCPT ); Thu, 1 Nov 2007 13:39:35 -0400 Received: from viefep18-int.chello.at ([213.46.255.22]:38375 "EHLO viefep12-int.chello.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758636AbXKARjd (ORCPT ); Thu, 1 Nov 2007 13:39:33 -0400 Subject: Re: per-bdi-throttling: synchronous writepage doesn't work correctly From: Peter Zijlstra To: Miklos Szeredi Cc: jdike@addtoit.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: References: <1193935886.27652.313.camel@twins> <1193936949.27652.321.camel@twins> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-tNPUnuLGMUTQ9uh1rASb" Date: Thu, 01 Nov 2007 18:39:30 +0100 Message-Id: <1193938770.27652.328.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 39 --=-tNPUnuLGMUTQ9uh1rASb Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2007-11-01 at 18:28 +0100, Miklos Szeredi wrote: > > The page not having PG_writeback set on return is a hint, but not fool > > proof, it could be the device is just blazing fast. >=20 > Hmm, does it actually has to be foolproof though? What will happen if > bdi_writeout_inc() is called twice for the page? The device will get > twice the number of pages it deserves? That's not all that bad, > especially since that is a really really fast device. Basically, yes. But then again, that would require auditing all ->writepage() callsites. --=-tNPUnuLGMUTQ9uh1rASb Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBHKg9SXA2jU0ANEf4RAhxyAJwLeufXonQYVMeLHA7r+JcGfedEdgCfXvCL jdocEtAFn/AUW123WpFxQBU= =2axN -----END PGP SIGNATURE----- --=-tNPUnuLGMUTQ9uh1rASb-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/