Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Aug 2023 15:26:37 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <davem@davemloft.net>, <sgoutham@marvell.com>,
        <gakula@marvell.com>, <sbhatta@marvell.com>, <naveenm@marvell.com>,
        <edumazet@google.com>, <pabeni@redhat.com>
Subject: Re: [net Patch] octeontx2-pf: Allow both ntuple and TC features on
 the interface
Message-ID: <20230809152637.17888c9b@kernel.org>
In-Reply-To: <20230808063623.22595-1-hkelam@marvell.com>
References: <20230808063623.22595-1-hkelam@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 8 Aug 2023 12:06:23 +0530 Hariprasad Kelam wrote:
> The current implementation does not allow the user to enable both
> hw-tc-offload and ntuple features on the interface. These checks
> are added as TC flower offload and ntuple features internally configures
> the same hardware resource MCAM. But TC HTB offload configures the
> transmit scheduler which can be safely enabled on the interface with
> ntuple feature.
> 
> This patch fixes the issue by relaxing the checks and ensures
> only TC flower offload and ntuple features are mutually exclusive.

Not enabling a feature is not a bug. And it will cause conflicts 
with net-next. Resend for net-next without the Fixes tag, please.
-- 
pw-bot: cr