Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bdeedd8a-c417-4265-374d-09747e60d1d0@quicinc.com>
Date:   Wed, 9 Aug 2023 15:11:40 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v2 2/2] scsi: ufs: host: convert to dev_err_probe() in
 pltfrm_init
Content-Language: en-US
To:     Brian Masney <bmasney@redhat.com>, <jejb@linux.ibm.com>,
        <martin.petersen@oracle.com>
CC:     <alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
        <bvanassche@acm.org>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <hugo@hugovil.com>
References: <20230809191054.2197963-1-bmasney@redhat.com>
 <20230809191054.2197963-3-bmasney@redhat.com>
From:   "Bao D. Nguyen" <quic_nguyenb@quicinc.com>
In-Reply-To: <20230809191054.2197963-3-bmasney@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/9/2023 12:10 PM, Brian Masney wrote:
> Convert ufshcd_pltfrm_init() over to use dev_err_probe() to avoid
> the following log message on bootup due to an -EPROBE_DEFER return
> code:
> 
>      ufshcd-qcom 1d84000.ufs: Initialization failed
> 
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
> No changes since v1
> 
>   drivers/ufs/host/ufshcd-pltfrm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c
> index 0b7430033047..f2c50b78efbf 100644
> --- a/drivers/ufs/host/ufshcd-pltfrm.c
> +++ b/drivers/ufs/host/ufshcd-pltfrm.c
> @@ -373,7 +373,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
>   
>   	err = ufshcd_init(hba, mmio_base, irq);
>   	if (err) {
> -		dev_err(dev, "Initialization failed\n");
> +		dev_err_probe(dev, err, "Initialization failed\n");
Hi Brian,
Can you pls add the error code to the print?

>   		goto dealloc_host;
>   	}
>