Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp380711rwl; Wed, 9 Aug 2023 16:25:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6QGNIzVwvZAgE3FvpHuTfY7l3crfD6D0i6PcRURX30JyyCFjobJ9oxicHjsRkxp2fby3v X-Received: by 2002:a05:6402:6c9:b0:522:678d:45e5 with SMTP id n9-20020a05640206c900b00522678d45e5mr626895edy.30.1691623558290; Wed, 09 Aug 2023 16:25:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691623558; cv=none; d=google.com; s=arc-20160816; b=eFmFmarIcNVqzOJsQRHFpZksYWKVrQ8ckyfjA4JTebdzGWhumRuOcEK0Zw+oQVuPbE ABYrIcYRVkRj/NGdiQRLkE8QggROm466ocVPrn9lQmJ4kgF4PIeTnPdXmSjn3Uwl4329 0XOurAyOd07hSu//EwQEI47hKjmpdG6W8ra+I/lQ+RBwgx9UPf/9/7Y1AFhEMal33hJb uUkLrEBnttXCxTPUdd8zDHSiv+34YdN9mB52KQDtL8/a6P14FEWam+lD4kgMZ1xIXhSI EV4m4KXVxz82ENEk5sz5JPCgfEBAbfsfAEts7OqziO9rgwU1LgOLUI0XWbmzIfwWwMGY Z66Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3GN7LGqdTr6CnPW49m5sqS19cT6QuH9Su23vIXkae5w=; fh=HZ5vFzPejk1GOlYmzvZFf5gQeh6tiex9W9d/Lp4bZuc=; b=0Ikk1+2/ZCrBSTWNLCR05wBhMp+QPrAg4WCVKI2ffWlvTqmxvm/7/WMgWlPu196cjE V+ZoyF6FHCdllp8hkei2KuKgIRmQQZ4cyi5iuoDCzV+l2vs0fFIE29laWUUXBBZuYSw6 kVoZ0qDJtMiO3qIzrnqO8pl5harwj3ipl2baRRTHDtfqEvytAbY2ZR4cAu3g7DLU8d/e SJUJ3uT5h9cbFtUveavEoUlfYp6LOEttn8bZNg03ywTCI4bpKVMkeaBXGhbXj8GB0eIp DS+5MCrNi/oflUrAvtP9ROTcSCWnS9RsllmbF3gNXZoSkVDSiLe6vCZGeIM9QhlLZ/uR WfTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=5Fk7ox2Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d17-20020aa7d691000000b0052337f4212bsi178332edr.108.2023.08.09.16.25.34; Wed, 09 Aug 2023 16:25:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=5Fk7ox2Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230260AbjHIWZZ (ORCPT + 99 others); Wed, 9 Aug 2023 18:25:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbjHIWZY (ORCPT ); Wed, 9 Aug 2023 18:25:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77DC2B2 for ; Wed, 9 Aug 2023 15:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3GN7LGqdTr6CnPW49m5sqS19cT6QuH9Su23vIXkae5w=; b=5Fk7ox2QmkiMrKU0ZB8zJUPTYo 3WYsHKPT/uZuXI8/Y+uOeJxlN3kWfZLRXEI/kzk0VXO7aqmoGqjokWX2sTffmaKJ4gHYTWaBxoRr9 cyTz27W1C1FGj44jDUKLVBp2C4PiCry3ZlzmBOa4r4XIDl/Xahr/96c60GoNlYaXkrLr7byGjt0FO /HZwh2zEirA+Olxz+Vl1bjIqZmYjUl22a/ILFZrNOZWAeEkZ5EvecldCNhv4YhZH6EBOlgmOviQnq SQ85bIR5WlOpUlv4Jce0PLiDUgvPrslN2dMSdSLcJzq6odEXxDD8RnSUHX2TtcR82G4GhAmRodwXx JDX8Xa8g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qTrcF-005zKr-2x; Wed, 09 Aug 2023 22:25:19 +0000 Date: Wed, 9 Aug 2023 15:25:19 -0700 From: Christoph Hellwig To: Alexandre Ghiti Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dylan Jhong Subject: Re: [PATCH -fixes] mm: Add a call to flush_cache_vmap() in vmap_pfn() Message-ID: References: <20230809164633.1556126-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230809164633.1556126-1-alexghiti@rivosinc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 09, 2023 at 06:46:33PM +0200, Alexandre Ghiti wrote: > flush_cache_vmap() must be called after new vmalloc mappings are > installed in the page table in order to allow architectures to make sure > the new mapping is visible. Looks good. I somehow vaguely remember seing a patch like this floating around before as part of a series, but if that didn't make it it certainly should now. Reviewed-by: Christoph Hellwig