Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp381049rwl; Wed, 9 Aug 2023 16:26:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsPlNUp+vDKltSntywqlXSwXL8Y++S9OAVxOyFTPLBjGaEkP55OEQhZqux9E3V7XOhvrLA X-Received: by 2002:a19:6758:0:b0:4fd:bec3:776a with SMTP id e24-20020a196758000000b004fdbec3776amr386615lfj.61.1691623583635; Wed, 09 Aug 2023 16:26:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691623583; cv=none; d=google.com; s=arc-20160816; b=t5oC8R2syXF6YgWbtNED2zHPW+0sKYIRUTHe7AJwpVOGdBpZwRleWZcksYhVCu/hT3 PpjitS7jLta5gJlQTwlp8GvrfCFoNggJGWQvWZR35H8EBNXtOh8LAr2/VIbVNbef6/pL NTYLyr1f1Xdt2e+jLiF24TWlMqMCcg0Oc0Ej62oKpjb4Rf4oeNuKw7tNLHCMjpv4j+t7 eQvVg1/YavQmcsuyvF0UM50dWUWGllCdeVHb3SY0IDxpPXyK25thTYtbZSl2+0sdxfwC AEkZ7I6JlLnsFEGXOQaVyoXMZWowIWU8C/E2e+aABAc7FMr/vGV/DZzQ1i3H+h4PNrnv 91jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=Kiv6ufTEi0zIDTNC+kqfchdMcC8M8bSZwpcc+Cne5SA=; fh=o5rpXnmscWXJVOOJZEN3UobbaxOwMqH8nNQpRXULPA8=; b=ArQStq9k8uMAsTPa/7xEwlmSi5REt9BHu+Wq1WK/MD2pJNptUuq5sMapmRc0xaBYwR 7wS+QpJ1U9RCMSVx1zKO1Vh69utWg5Vd3D5pV2P/H5gWsLovCp2dkjGIWfbP91TYFHB0 eaSj6XIXt0xW8IObqsbwCsztnJs0J0CZzJh7+EyoETwyyTUhR3epQwYwGBea8BFOg0EY BjXU97VP8edYf7fg0w5D5lYv/QnicdzAxQe+Jfm7w6ZPwI04hz2pRNz4ucAztLw9dHpA bNHiAx/ntLMOBwC+IQLEx0uw8XgdeRyxTc+mu0pipP75teLzwlVKIQRSmAUjPgh0PTJU 1xiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d9-20020a170906040900b00992b63c9c16si235884eja.129.2023.08.09.16.25.58; Wed, 09 Aug 2023 16:26:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233325AbjHIWoC convert rfc822-to-8bit (ORCPT + 99 others); Wed, 9 Aug 2023 18:44:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231199AbjHIWoB (ORCPT ); Wed, 9 Aug 2023 18:44:01 -0400 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEBE2D2; Wed, 9 Aug 2023 15:44:00 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id A2B1F635D29E; Thu, 10 Aug 2023 00:43:59 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id v_JwZWmfHdUG; Thu, 10 Aug 2023 00:43:59 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 4E2D4635D29D; Thu, 10 Aug 2023 00:43:59 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jfzWTASF6VHD; Thu, 10 Aug 2023 00:43:59 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 2EA2A635D28F; Thu, 10 Aug 2023 00:43:59 +0200 (CEST) Date: Thu, 10 Aug 2023 00:43:59 +0200 (CEST) From: Richard Weinberger To: hch Cc: Stephan Wurm , linux-block , Miquel Raynal , Vignesh Raghavendra , linux-mtd , linux-kernel , Johannes Eigner Message-ID: <533238598.5052964.1691621039144.JavaMail.zimbra@nod.at> In-Reply-To: <20230809223703.GA10719@lst.de> References: <1293911429.1782934.1691445776353.JavaMail.zimbra@nod.at> <20230809135308.GA32214@lst.de> <20230809141542.GA32614@lst.de> <366198994.5052941.1691620484888.JavaMail.zimbra@nod.at> <20230809223703.GA10719@lst.de> Subject: Re: ubiblock: null pointer dereference using scatterlist in work_queue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: ubiblock: null pointer dereference using scatterlist in work_queue Thread-Index: r+jP0Y2+YKP9h0H5tuoMD33XwrLVCg== X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > On Thu, Aug 10, 2023 at 12:34:44AM +0200, Richard Weinberger wrote: >> Will do so! So far I managed to get UBIblock work with scsi_kmap_atomic_sg(). >> Sadly now with kmap'ed memory a bounce buffer is needed since IO in UBI/MTD can >> sleep. >> Is there a strong reason why scsi_kmap_atomic_sg() needs IRQs disabled? > > I don't think it needs irqs disabled. Also if you switch from the > deprecated kmap_atomic to kmap_local first you can sleep and don't > need bounce buffers. Yep, for upstream kmap_local will do the trick, but I need also something for the stable trees. Anyway, time to get some sleep. Thanks, //richard