Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp381964rwl; Wed, 9 Aug 2023 16:27:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGztTRD1n+oldBPJkXa5yK2CFMpDGdHq3yjcffePM5QlCSXHsZtNPjrppU+mWaK6cmu6vs1 X-Received: by 2002:a17:907:761b:b0:99b:d075:18ba with SMTP id jx27-20020a170907761b00b0099bd07518bamr423261ejc.56.1691623657627; Wed, 09 Aug 2023 16:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691623657; cv=none; d=google.com; s=arc-20160816; b=LiiNE9WdAf1HJKkS/Jq98zt2aOOQpo/3SwpojAuLa/aNoqiYVYzHg2lr1uM2nGNsz5 9R5b4NzXcUISfUKc5jZyvEbgIjkV5QqahRO0OD4Cp+MtIT+L4cezvmOvOaBCdJ03E+Li IB87EInzKhvq5AImSHPU7/Pvx5lrCzFTaa/5Bvt/zuroV7SG9wYjTghRo494zDK6Ygtk Bw0R+MwnIntLnVdAqx2FzPTMKahMADMh5ZT53bZBFK2pXqZRjSGuDQ/LrXGoQHE0iQD3 Q3a21oMMBo0yFgEph2kzztYx24FJRo5GKtCk4vk1zR55jqW3acC/zzf+6XvdGtUAz+v4 bzxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=lW2YJ1DpQsxIG7eWE29CKsa3c5xb6O4dq90dIZp4C+g=; fh=qdHPSpsub0xEIXpztC2Gt2uqr/plls4TCwpXm1gAKVc=; b=q5mQTjvA4rx+50IEpBRS1AoCVlIrpML3xsoC7NJkcolkphO2g5jR6JhMeIFoSIvlw1 lmpExgTYaf+1GHLM+9D8UGyxWLD5Rg4GzxnjU8BAX3xY/l8FfX5duIM1PIQkgSu3cPqc wx5fGgzvwnf7uhNun8X6bXaeFkvRn5xSckSmZVp4xCavt2UzgztBEENK5vKYI8eYiOjD o+TRJ49049NM1UshC9IYATMIeP0+d99WC8hoePoCCd0edJldIIch7U+ovunN5j2FBXcZ Ajgy/hc4skoIJGnpLAQisq12UExETUT/BHxctHyr9PgouHmYJQ4W1xivNSlieGRFcjOk DMWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rs28-20020a170907037c00b0099364d9f0eesi225787ejb.481.2023.08.09.16.27.13; Wed, 09 Aug 2023 16:27:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232803AbjHIWh3 (ORCPT + 99 others); Wed, 9 Aug 2023 18:37:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232845AbjHIWh2 (ORCPT ); Wed, 9 Aug 2023 18:37:28 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5990E7C; Wed, 9 Aug 2023 15:37:09 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 0075668AFE; Thu, 10 Aug 2023 00:37:04 +0200 (CEST) Date: Thu, 10 Aug 2023 00:37:03 +0200 From: hch To: Richard Weinberger Cc: hch , Stephan Wurm , linux-block , Miquel Raynal , Vignesh Raghavendra , linux-mtd , linux-kernel , Johannes Eigner Subject: Re: ubiblock: null pointer dereference using scatterlist in work_queue Message-ID: <20230809223703.GA10719@lst.de> References: <1293911429.1782934.1691445776353.JavaMail.zimbra@nod.at> <20230809135308.GA32214@lst.de> <20230809141542.GA32614@lst.de> <366198994.5052941.1691620484888.JavaMail.zimbra@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <366198994.5052941.1691620484888.JavaMail.zimbra@nod.at> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 12:34:44AM +0200, Richard Weinberger wrote: > Will do so! So far I managed to get UBIblock work with scsi_kmap_atomic_sg(). > Sadly now with kmap'ed memory a bounce buffer is needed since IO in UBI/MTD can sleep. > Is there a strong reason why scsi_kmap_atomic_sg() needs IRQs disabled? I don't think it needs irqs disabled. Also if you switch from the deprecated kmap_atomic to kmap_local first you can sleep and don't need bounce buffers.