Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp412303rwl; Wed, 9 Aug 2023 17:04:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHKxHK9ZjCKZ4u5soMKnQy3Si6dZ2ZC0rhG4ANXNwCqyDkdERbwA+jTqFHjBLCuYJl5FZ1 X-Received: by 2002:a19:6d0d:0:b0:4fd:da65:d10 with SMTP id i13-20020a196d0d000000b004fdda650d10mr418716lfc.36.1691625839825; Wed, 09 Aug 2023 17:03:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691625839; cv=none; d=google.com; s=arc-20160816; b=ttylAxJemP7Jm7Q3wwcHhjhxXIU/xksv4tiycw0oYGTsPjJilKVqT0T7OQU1DkmKLW j1BQOidsdplTQx4LoIaeCXsK8JBXrn7OSUbwnuxVYmpHOphfwE5u5hVY4VG1iFNxwPEs G14nM/YRgvXWudxfnbHJ/pRG/U00qCMilwvXXeUAXEBqpKp0JskYcppNsqhVYz5NMU3s or+1stQt1pZC/aN/gKHA7huxwQVFCgzHcQgmm0Y5894vr7X/z6UdgnPkEoWq8ya/wSxg u9WNiAqQjGpjjuSrLDHAaPXf4WD+4WQ7eFPQF4kAH7T3cQ0X7ctodgAXBlFdc7FBAJRz pitw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:subject:cc:to:from :message-id:date:dkim-signature; bh=li/9TOw1D/al0BgcWpvzxPhzRc7oZy+uOQFsKnuD0nc=; fh=zOdTh2zTjJiNrBG1kFVcf98gVI/1jQma2FGYQ18uIgo=; b=y1Qt1oRxrKPP8+dZk+kp9yBEv4VnQ9lGmJQXMqENrvnTYFzMmVhhvvVCmuq8aap9sQ tsn6WQv4XGDYOo/P0ddBatDuTl/vnfjNPepekHB13o8apotVCXkd3LQ9h2wsrw/wr5bw JPCRQw8X4CaJ80y85DpxYdpMTDOIW7WwCGIrtG/F1MCydD6R99Y0xW+C1J1wiJmSDUHY HU1zb7Ifphak+qpIRQtDaxIin3ba728C3f64f5X11BjV5mbJblpezY/Kir/2mIpCw7Oo lW5oCT61RACRE9Ukco0Tgsfii9vp6M0qKfNLJX+Ur3OgSSTAbhQdpkSSXzLAAmAxc9v+ nRWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b=VsgR3qiN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n16-20020aa7db50000000b0052307b7c10fsi225100edt.441.2023.08.09.17.03.16; Wed, 09 Aug 2023 17:03:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b=VsgR3qiN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233483AbjHIXHx (ORCPT + 99 others); Wed, 9 Aug 2023 19:07:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232673AbjHIXHr (ORCPT ); Wed, 9 Aug 2023 19:07:47 -0400 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D545D1 for ; Wed, 9 Aug 2023 16:07:46 -0700 (PDT) Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-63fbfca1302so79366d6.2 for ; Wed, 09 Aug 2023 16:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1691622465; x=1692227265; h=in-reply-to:references:subject:cc:to:from:message-id:date:from:to :cc:subject:date:message-id:reply-to; bh=li/9TOw1D/al0BgcWpvzxPhzRc7oZy+uOQFsKnuD0nc=; b=VsgR3qiNN+VuZuH58/kL0XOyT5r0+EUKZKvFDLAYBNNEL6QY5BLbea3/fsWoOrepON 1J9WYmT/sxrpqc/g+FT8PiebEUrRrnHGrp5HBz/GKO87cFAQF+B02NHzQeWXFG9u37ic bygIceYeq8MxC5bqcJ3loTL94SEZUqMLVV+Y0ZrXh5J6sCKs1uQu+HjxBHPmWNXOStXj QQrMZAljeAubu5D4pxANJTbpKpFu/9UGCu0ImHNkd+mVXM0RJ2pukjD7lt/jfFElIyLb c+EcJTe3S10nGDaYLhbWEaNs/JCnsJU7OD67hscB8ClWezuccWHlmO72NMpgjL2SlCEN q4kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691622465; x=1692227265; h=in-reply-to:references:subject:cc:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=li/9TOw1D/al0BgcWpvzxPhzRc7oZy+uOQFsKnuD0nc=; b=Xe1cXvpJlsoO1FO3forq4ang0VZd7i4PehMLO7tiP+P4ySkhezGzcbiQO/d2qF5iXM XDRvulgNUDIdqWOzRuPrdLfNd7gHo4E4rf8ZioAr/suAoi//E28qmqN3EV8i5ZCjS7Uw o5s912AnD24+irQQmySq+UIb2wvMhvBDRdOYFxUSwFDA93po8Zg7oHlCrW5gE1jiZQG0 dhpLjrOonEq1IaeoHV+Ldl3qhvszYLlUU62qd14dGRSdsR6iCAsT9v4Kix4Wo5Yer8Bt oYX0l7soqG32Xzq5fREo32rzrlb98rYubrW8OofpyWsHkiKxPtdPIKDuGYP+ALcDITZq b8Ww== X-Gm-Message-State: AOJu0YzWm1NaPZTq30lUr0i8zMlIGp86MbwUBwPfsYYo2BB74l07fBPr j5MwcJJHVvooPDqVh81It245 X-Received: by 2002:a0c:f54d:0:b0:63c:d8b5:ee6d with SMTP id p13-20020a0cf54d000000b0063cd8b5ee6dmr582494qvm.33.1691622465178; Wed, 09 Aug 2023 16:07:45 -0700 (PDT) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id d14-20020a05620a166e00b0076c5ad6750fsm45819qko.102.2023.08.09.16.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 16:07:44 -0700 (PDT) Date: Wed, 09 Aug 2023 19:07:44 -0400 Message-ID: <651d3c359cdfd599482a94104c35ee05.paul@paul-moore.com> From: Paul Moore To: =?UTF-8?q?Christian=20G=C3=B6ttsche?= , selinux@vger.kernel.org Cc: Stephen Smalley , Eric Paris , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/7] selinux: avoid implicit conversions in selinuxfs code References: <20230807171143.208481-4-cgzones@googlemail.com> In-Reply-To: <20230807171143.208481-4-cgzones@googlemail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,PP_MIME_FAKE_ASCII_TEXT, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Aug 7, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= wrote: > > Use umode_t as parameter type for sel_make_inode(), which assigns the > value to the member i_mode of struct inode. > > Use identical and unsigned types for loop iterators. > > Signed-off-by: Christian Göttsche > --- > v3: > - drop leftover declaration in init-clauses of for loops > - use unsigned int instead of u32 for loop iterator with loop bounds > known at compile time to be small (<100) > v2: avoid declarations in init-clauses of for loops > --- > security/selinux/selinuxfs.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Merged into selinux/next, thanks. -- paul-moore.com