Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 00:07:13 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Charlie Jenkins <charlie@rivosinc.com>
Cc:     Conor Dooley <conor.dooley@microchip.com>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        paul.walmsley@sifive.com, palmer@rivosinc.com,
        aou@eecs.berkeley.edu, anup@brainfault.org,
        konstantin@linuxfoundation.org, linux-doc@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
        mick@ics.forth.gr, jrtc27@jrtc27.com, rdunlap@infradead.org,
        alexghiti@rivosinc.com
Subject: Re: [PATCH v9 0/4] RISC-V: mm: Make SV48 the default address space
Message-ID: <20230810-endanger-motive-83096266ab26@spud>
References: <20230809015110.3290774-1-charlie@rivosinc.com>
 <20230809-bobbing-unleaded-c3d5e1c57d96@wendy>
 <ZNQXC+UQ+a0s69Bs@ghost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xYlUSbAm7YzipPhu"
Content-Disposition: inline
In-Reply-To: <ZNQXC+UQ+a0s69Bs@ghost>
Precedence: bulk


--xYlUSbAm7YzipPhu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 09, 2023 at 03:45:31PM -0700, Charlie Jenkins wrote:
> On Wed, Aug 09, 2023 at 08:42:58AM +0100, Conor Dooley wrote:
> > On Tue, Aug 08, 2023 at 06:51:06PM -0700, Charlie Jenkins wrote:
> > > Make sv48 the default address space for mmap as some applications
> > > currently depend on this assumption. Users can now select a
> > > desired address space using a non-zero hint address to mmap. Previous=
ly,
> > > requesting the default address space from mmap by passing zero as the=
 hint
> > > address would result in using the largest address space possible. Some
> > > applications depend on empty bits in the virtual address space, like =
Go and
> > > Java, so this patch provides more flexibility for application develop=
ers.
> >=20
> > This still does not build:
> > ../fs/binfmt_flat.c:900:30: error: call to undeclared function 'is_comp=
at_task'; ISO C99 and later do not support implicit function declarations [=
-Wimplicit-function-declaration]
> >=20
> > Reproduceable with allmodconfig.
> >=20
> There is some weird interaction with compat.h. Moving the definitions
> in pgtable.h into the #ifndef __ASSEMBLY__ guarded section resolves=20
> the compile error. I will send out another version with this change.

Just be sure to run an allmodconfig build this time before doing so ;)

--xYlUSbAm7YzipPhu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNQcIQAKCRB4tDGHoIJi
0gh4AP0ZHirwBgSAjTZzsYgQWx0puWLpButSxiuoRHlyGjJHRwD8C6jANtDOeMif
IiUgQCa5S8zKtEanNEt/wf4f6auvfgY=
=E3pw
-----END PGP SIGNATURE-----

--xYlUSbAm7YzipPhu--