Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f5993dda-7540-a43e-acee-85054c4a22c7@intel.com>
Date:   Wed, 9 Aug 2023 15:32:57 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.14.0
Subject: Re: [PATCH v5 03/24] x86/resctrl: Create helper for RMID allocation
 and mondata dir creation
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>
References: <20230728164254.27562-1-james.morse@arm.com>
 <20230728164254.27562-4-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230728164254.27562-4-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnVraGJNSmxaZlZDWklMT2dHalFlV3NLT2FLWXV1YW0rRHNDVkprOUZWUCs0?=
 =?utf-8?B?L1dIb3BnTmdLQ1g2MHNOWU9KTm1PV0ViVnJ5anVMNVJDMjFKOWZnY01OMHVp?=
 =?utf-8?B?d3JTbVB0UzBvc0tHWDlEdXF1NDRJNjJMMDIyLzdYUi8rVzdCM0ZIOXpJYjlI?=
 =?utf-8?B?NmJGTUlPajQzb0NSWHdSOEVTUTMrWFhVcVVlSGZDODNNejloWmc3ai94VE9t?=
 =?utf-8?B?WjBQdk5yQmVQMmZ5cTBnTzI2ekV1djBSVUpiZ29UekRsWmFuenNkUlBEcUJL?=
 =?utf-8?B?SCtRdGZqb3RHWnl1NitLRjVXdWNlTVAvTUNxUGtEQlI5L1ZSR3czRW13SFRG?=
 =?utf-8?B?WDFEZFIwaVMxU3BXUjVlZmIvZ1JLTm9RVktTVWw5elcwQVpha3ZDSkw5WVdr?=
 =?utf-8?B?UFliMk55WWpiQW00QnlpME1VY3RlY0FNWVVBa1JsNkorc08xYVNOUHlIemU1?=
 =?utf-8?B?Z2Jnb0pzL1dCaE1POWl6V0N0SmtlaDhnb1dzY1FNYlNqN0hUM1FvdSs5NXVw?=
 =?utf-8?B?cDRlYkxpM3puZE9xdVdaMjBYcUN6aW1yeGdsVXFJRWdRWG1uZDdBazV3TjMr?=
 =?utf-8?B?UWR5K0MvditCR2RURWRJOXR2ZnBEMGhwNmdiWG5XZ0h6b2d2YitIV2FKNWNh?=
 =?utf-8?B?Sm84QXRMeDFYQjNHV1E5b3dkZjlxT0lWOFNRWlVEWU5ueU12Yk4vM3J2dG5o?=
 =?utf-8?B?cUlUc3BEeGxtb3BvVE1kYnZjbmZkdnJiWUhoZVFHSjZ0Q0lVYU02emZGY1Va?=
 =?utf-8?B?c2JuQW1zMWtYNXpCQmpzMGdaN1NXejdPMDVuRTlreWV3Z24yclYxVjJmSTBI?=
 =?utf-8?B?U2xUQTdUczMrM29XTTdqbzBvNmF0c0N0dS9yNGVxNVFTd000OFBCMlRyZmNI?=
 =?utf-8?B?UGdLeDYzcE90eXJYNU4yOEtpQVdEVUtzOFRBSW1SdEpSTTJCWlpDYnk1eHZN?=
 =?utf-8?B?KzJaUThCSXEzb09EaDBRR01sbEhSYXVFNW4yRmFTMCt4dWU0SWxXSWZhLzhD?=
 =?utf-8?B?YnFNdzdrcU91YmI2MGtPT0JIdzA2UDAvdm02WU53N1d6Z0E3SXRDVk84OGp6?=
 =?utf-8?B?bzB3elFkMjMxUmZma3Z1VzQyN3F4YmI3Q3N2SmlRWC95eHFaS2o3elU0ZXY2?=
 =?utf-8?B?dFd0dVNxODdVREJKQXdTaExuZ28zQTlmNGJzdjBqbFZ4MFRiWWl2RDZnSmdk?=
 =?utf-8?B?UnU5UTRpMVUyMVZFYmw5YXNESmpINnZlSFpLUFdHKzdFNnRCWjZkRmRiL0xv?=
 =?utf-8?B?VDg3TjU5bWd1Vm5XV3ExSGQ3dUZXS3JNa294TUdFT2NNWnV1bVlDSkJPRXV0?=
 =?utf-8?B?YVBXOUpOQ1ZiOGJ0SDYwV0FsQjdXMHpVcjBKazNJVktlV2E0TG9TMzRTTWZM?=
 =?utf-8?B?aE1hOThzaU9oUlp0YW1GL2VkMEM0bUFQTWNhYkd3SXBRUXBsWDYwekZVeHpn?=
 =?utf-8?B?UE5ZL3FDVEFPb2tCalBuQjVUeGprNWdLM0Fsd0J1Z0xwTFgxQ2xJNDZjeEpt?=
 =?utf-8?B?RWZRVE1yYXpNOWJSbDJnbTduMTZvZzVPRVhPajIvUHVCTWlWOXI2a0dJY081?=
 =?utf-8?B?NHNxRWFxZmRseEhPR2NBcjhRVzg5ZmFlaFJNcHBLUExWbjczZ3RXYnVpSVBU?=
 =?utf-8?B?OW1pdWtQZjBxWHpCUHp2Y3gzMjVBTkxqUzJUbzhtUlQ5a0xYV21YQ2Zram41?=
 =?utf-8?B?dzVBU0cvTWhiUHRCUWZmV0IrR3YrOGJEcU9kaHZOY3ZsUklWdU9ET3RQb3h5?=
 =?utf-8?B?Lzkxbjc4cno5VDJLd0VzTE53TmR4ZlRNOS9WeHE0TVBtVWVKbTUxS2tXeGtk?=
 =?utf-8?B?ZGhIK0pDZ3NBOEJlYmpTb3V1aEdFKzBrKzlYanlRLzdiRXZKOGMrcUdjbkd3?=
 =?utf-8?B?VkFNaHBwcE91VTR1SmFUNDdtdDZpQ3MrdTEwS2F1MUJmMzl5aGN5MFlna3lO?=
 =?utf-8?B?TXBPbVFFb1VOWlFnOC9oSi9yV0Y2OFF5ZVR6ZUJLWGJVaHVHa0QzUGlTemJO?=
 =?utf-8?B?cGxGSFJFNnpKUWxwTTFSQWFialQrYTFWR1VtUCtzdFJicVhENGVKam9rSWVw?=
 =?utf-8?B?elcvT2FaSFhCVjFXTDRycUZvWjZWaFRNZUZuZ1FRUUdWalJUODVIZ3YzT3dp?=
 =?utf-8?B?Q095by9zbEVtSjJESkY0bW5MRVFEK0hIK0YzMVZBdzdpYnFVd0FFbFhJblhw?=
 =?utf-8?B?Y1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c7c82d67-057f-40be-9211-08db99289665
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 22:33:00.5630
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JUc/PbRmYzBQYRy4JMeowlskqyoz0fKBEGOnEi64vhS0F5VmFmdTdpQ4fw/ryiJ9m1lXZjv525MDGCU6rLIv2qZC7lSq3xEsg2juCmimzj0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7413
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 7/28/2023 9:42 AM, James Morse wrote:
> When monitoring is support, each monitor and control group is allocated

"When monitoring is support" -> "When monitoring is supported"

> an RMID. For control groups, rdtgroup_mkdir_ctrl_mon() later goes on to
> allocate the CLOSID.
> 
> MPAM's equivalent of RMID are not an independent number, so can't be
> allocated until the CLOSID is known. An RMID allocation for one CLOSID
> may fail, whereas another may succeed depending on how many monitor
> groups a control group has.
> 
> The RMID allocation needs to move to be after the CLOSID has been
> allocated.
> 
> Move the RMID allocation and mondata dir creation to a helper, this
> makes a subsequent change easier to read.

Reinette