Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230803042732.88515-1-weijiang.yang@intel.com>
 <20230803042732.88515-5-weijiang.yang@intel.com> <ZM1C+ILRMCfzJxx7@google.com>
 <0655c963-78e5-62c9-50af-20d9de8a1001@intel.com>
In-Reply-To: <0655c963-78e5-62c9-50af-20d9de8a1001@intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Date:   Thu, 10 Aug 2023 02:01:29 +0200
Message-ID: <CABgObfbvr8F8g5hJN6jn95m7u7m2+8ACkqO25KAZwRmJ9AncZg@mail.gmail.com>
Subject: Re: [PATCH v5 04/19] KVM:x86: Refresh CPUID on write to guest MSR_IA32_XSS
To:     "Yang, Weijiang" <weijiang.yang@intel.com>
Cc:     Sean Christopherson <seanjc@google.com>, peterz@infradead.org,
        john.allen@amd.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, rick.p.edgecombe@intel.com,
        chao.gao@intel.com, binbin.wu@linux.intel.com,
        Zhang Yi Z <yi.z.zhang@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 9, 2023 at 10:56=E2=80=AFAM Yang, Weijiang <weijiang.yang@intel=
.com> wrote:
> > I'm pretty sure I've advocated for the exact opposite in the past, i.e.=
 argued
> > that KVM's ABI is to not enforce ordering between KVM_SET_CPUID2 and KV=
M_SET_MSR.
> > But this is becoming untenable, juggling the dependencies in KVM is com=
plex and
> > is going to result in a nasty bug at some point.
> >
> > For this series, lets just tighten the rules for XSS, i.e. drop the hos=
t_initated
> > exemption.  And in a parallel/separate series, try to do a wholesale cl=
eanup of
> > all the cases that essentially allow userspace to do KVM_SET_MSR before=
 KVM_SET_CPUID2.
> OK, will do it for this series and investigate for other MSRs.
> Thanks!

Remember that, while the ordering between KVM_SET_CPUID2 and
KVM_SET_MSR must be enforced(*), the host_initiated path must allow
the default (generally 0) value.

Paolo

(*) this means that you should check guest_cpuid_has even if
host_initiated =3D=3D true.