Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <839913af-a511-19fe-919e-733f080196ea@intel.com>
Date:   Thu, 10 Aug 2023 09:12:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH v5 04/19] KVM:x86: Refresh CPUID on write to guest
 MSR_IA32_XSS
To:     Paolo Bonzini <pbonzini@redhat.com>
CC:     Sean Christopherson <seanjc@google.com>, <peterz@infradead.org>,
        <john.allen@amd.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <rick.p.edgecombe@intel.com>,
        <chao.gao@intel.com>, <binbin.wu@linux.intel.com>,
        Zhang Yi Z <yi.z.zhang@linux.intel.com>
References: <20230803042732.88515-1-weijiang.yang@intel.com>
 <20230803042732.88515-5-weijiang.yang@intel.com>
 <ZM1C+ILRMCfzJxx7@google.com>
 <0655c963-78e5-62c9-50af-20d9de8a1001@intel.com>
 <CABgObfbvr8F8g5hJN6jn95m7u7m2+8ACkqO25KAZwRmJ9AncZg@mail.gmail.com>
Content-Language: en-US
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <CABgObfbvr8F8g5hJN6jn95m7u7m2+8ACkqO25KAZwRmJ9AncZg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm5zT3BUZUNpL3lHZTRKejVrL05FMlZwZzRzbjE5M3crNExLYXh4K1BhMXB4?=
 =?utf-8?B?UzdiMC9rT3ptR1FjckRyUC9QcVZsNlY2OXRJallBV3BWUlUxZVkvSDlRVENy?=
 =?utf-8?B?Y05tTzgrWHhheG9kQmh4N2RHa3JoMVZyR25hRHNYRHBCd0ZhTXljUVhHOW5M?=
 =?utf-8?B?cm11V3RKNmNJenBra095dUE0RTB4bnl5NW1iK0tnbWlxSXNSbkhObVo1QmJz?=
 =?utf-8?B?aEFqMFM5NUtVZEplU1g2RVpndlh2SlpweDY0ZVZsWEJld3l4a2dmZ2k5NnVI?=
 =?utf-8?B?d3h4ZmM3UjVPZjhZb24ycUt6Z0lRdjlOcXMwdXNZMUNSeXU5eFJ6NTVoZld4?=
 =?utf-8?B?UWlFV3piakRzUFdLVWczRWphWGtqdlJ5dGxuTTFteXBFZFpBSzA3MmVKTGZX?=
 =?utf-8?B?WmZBd051N3JMTThUbms2L2xXU1RqS1JQeUFCVE51OWREVlkxMEhSZTErYnVC?=
 =?utf-8?B?eVphUXFYTWdnUlFpbTJLbHJOUzNqVWNmVHRYaU1DNHRYUmIwOGw3RHM4WnIx?=
 =?utf-8?B?VjB3QkJFc3pEU0dxckFrOTd4NEZ1WmJPcFR3UGR1MXFTYXNjOFI0cUpRSHk2?=
 =?utf-8?B?a3VLeWl1REZnTE5KMzlvTE93T1N5c1ptSzVXT0h6S2xrcHAwRGp1ZFFJdGNq?=
 =?utf-8?B?NFBPWnJpSFdkMXRJT2JsUmxyanJSdEF3UjJWUjc2ODhIdTZqa1NYSEsxeTls?=
 =?utf-8?B?ZVdXU0lkdk1DSDlZVVBZdjlITTdsRkJ5RFhmQVczUU5JYWg4WTVlTElhWGh0?=
 =?utf-8?B?RElvcDVVVmppVjZUdUFPZUdabVRoVzRhclRsVHdhWWxnRnNqWkJ4K2ptdUNZ?=
 =?utf-8?B?SWFYQSsrNXM1K1UyV1ZvbnMxdm83VEI2Vmdxd0UweFFiLzNhbDJsMlNUS2lD?=
 =?utf-8?B?b1RUaFk4TUxTQ2NJUXp4bFBNOFlVRjYzTXJtdWlDbVAyNTdhallYdlpIY2FO?=
 =?utf-8?B?eDJuNGhnZVF1b25uM2hqYjNaZWFoaS9DY0xnUzNUMnNpTkNLNG4zWjBtQzJF?=
 =?utf-8?B?bmxiQlFodi9GUUFqNk1sZGZNQnNvdUgxTXR2bUpZYnZrS0ZqOW8vUFJza1pV?=
 =?utf-8?B?T3hKUmtYd3dHVlEzNU96R0szR1R3QTNWVWdzMkdkVmw1YXlSWDZnYTdwakR2?=
 =?utf-8?B?d3UzWEVPZnRXUDU3amNBc3BhMWhjME5mK2FQRkNDSERMTSt1Zk9aaEx4bDJ6?=
 =?utf-8?B?NmNheDlZZDB5SDZDVS9PcERpLy9GaGZFV3F2YVptaWVFWFU2bmtYM3k3b3Fk?=
 =?utf-8?B?bHptSVB2bFNJNVA4T0hlWVdLMVJja1MwZlp6NTAzQUJYTHY5WFRETWFYZFR4?=
 =?utf-8?B?L3Vibi9HTlN5ek5LdzR2Z3p2Rm9xNmozMkI2dHF1aVdtMTZOL2swMVU2RGVj?=
 =?utf-8?B?MjlKeWlZa0cwVlY0aDYrcExaS0dnY0JhK0c1dVkzb1FBK0x0ZTRLbllYK2hx?=
 =?utf-8?B?QldFNzNMK1NEeWpKNlIyOGxvenhzVzhWREdkN0g2WS91ZWdBa1BENXZSSWVD?=
 =?utf-8?B?SkFyVVJGeW55M1Jkb2RpZm1td3V1bmVXK2hOZkVTUkpTaDc5cmZTSDNaRzAv?=
 =?utf-8?B?K2ZEY3g1ek9SMHo3ajY5RGV6QzdnaGdnVzJrcEFHckovZTF6RlRxL1E3aDVs?=
 =?utf-8?B?L2szNDZMK0ZNWWFOdHY1Z3R5UUpQY2VENEV4OEJudmtHWlBNQyt2OUZvUVVr?=
 =?utf-8?B?K1N0Y1hWVW16YWsxRXZhUkpXbUVmRkxCQ1VGQkZBRTBYVDYwQlk3aXZucjhr?=
 =?utf-8?B?Y1hKNTZ2TGNhYlByMnVyWnF5Z2NGUStmQ3o1VTROR0F1d29jQ0lwNG4wdEl1?=
 =?utf-8?B?YXpyRFkwT0s3bklGYmZYZ2EvSTZyb0VCUjgzODlFNTA2V0x6QitldG8zT0pR?=
 =?utf-8?B?S1JrVjd4ZXRuQVJxdXlPMEtadlBlRzFjOFpkRndJMGtJM2MwL0xGZXI3aDZF?=
 =?utf-8?B?Sm1hZUladFFUZ050a0ZzMUFCNXpvbVQrUW9Dd0hTbUppY0wxWVcrdGtZQ2ZO?=
 =?utf-8?B?UVA0RWxJN3pUamgxc0ZhUHN1VUcxMkhXUjk2SHlUNXUyRjRKOHRQTkNnTWNL?=
 =?utf-8?B?akluTFd0a2pzOWZoZHF2bkd3TFJxcmh5ZHJyNWd6anBjbjNRajJadStQWEs4?=
 =?utf-8?B?dE1CNGhFSG5oUGxjcUFtaERUVCs3ZFJkdGMyQ3JPTDd2OWo1NFdFa3hrb0py?=
 =?utf-8?B?SGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a2c76ee3-b37c-4b69-a4d7-08db993eecbb
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 01:12:54.5527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LqIfOhkIlxiKJP1LGe8WHTMduKvmihsvbP6IXIKBI4CT4Yjp/dUPViHo/yh2JLZEmKe0lSZBCksbuejGR+Dz7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7778
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/10/2023 8:01 AM, Paolo Bonzini wrote:
> On Wed, Aug 9, 2023 at 10:56 AM Yang, Weijiang <weijiang.yang@intel.com> wrote:
>>> I'm pretty sure I've advocated for the exact opposite in the past, i.e. argued
>>> that KVM's ABI is to not enforce ordering between KVM_SET_CPUID2 and KVM_SET_MSR.
>>> But this is becoming untenable, juggling the dependencies in KVM is complex and
>>> is going to result in a nasty bug at some point.
>>>
>>> For this series, lets just tighten the rules for XSS, i.e. drop the host_initated
>>> exemption.  And in a parallel/separate series, try to do a wholesale cleanup of
>>> all the cases that essentially allow userspace to do KVM_SET_MSR before KVM_SET_CPUID2.
>> OK, will do it for this series and investigate for other MSRs.
>> Thanks!
> Remember that, while the ordering between KVM_SET_CPUID2 and
> KVM_SET_MSR must be enforced(*), the host_initiated path must allow
> the default (generally 0) value.
Yes, will take it, thanks!
> Paolo
>
> (*) this means that you should check guest_cpuid_has even if
> host_initiated == true.
>