Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Aug 2023 23:02:49 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Benno Lossin <benno.lossin@proton.me>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Alice Ryhl <aliceryhl@google.com>,
        linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: macros: add `paste!` proc macro
Message-ID: <20230809230249.01ffc009.gary@garyguo.net>
In-Reply-To: <CANiq72miVic=P+qSobuUqXoCuKW30_tT_buD8MyEsyVb_uoj6w@mail.gmail.com>
References: <20230628171108.1150742-1-gary@garyguo.net>
        <CANiq72miVic=P+qSobuUqXoCuKW30_tT_buD8MyEsyVb_uoj6w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTFxcHc0VUNjN0hqa3FUdDNlQmY1cndpUzRIc1BnSnljYmtPRjk4bmozM3Fa?=
 =?utf-8?B?eDVQTVdKSWJENXdCVVphZlpCcTlGK3MxMmttU3F3VnJIR1UxNGpzWVdVdWJQ?=
 =?utf-8?B?NjVFLzVDa00vdXBKZ3ArOGF2V01QdHJ0R0R0bEpqR1JBOVhtTFBJb2dVTGYz?=
 =?utf-8?B?Sk4wN1ZwMmNWOE1hTzlCeGljY2haMWxac21XOFBOeTNBa0RrR3QwSXI3RkZ2?=
 =?utf-8?B?L1liQmZLalF5NFlXQVBsNjFCQWNxSjJWd2swTlRPb3VMRXdqYUEyTjdhaFUw?=
 =?utf-8?B?eXo4OXlHay9xekxiYkNvb2VLMlN0c1crYUJwWDJvN2J3aFM4bmhKQnFrdmRL?=
 =?utf-8?B?OHdlVDRRRDRickFrT2hWS25EbVI5ajBQYXYyY01Lb1E4NVpiUHpNMC9FZW5L?=
 =?utf-8?B?MXZjd0VHeVk1TkdNak1qMlNXZ2hCbGU3NENieUdqb2RnK2tUbU93dDBLVHdK?=
 =?utf-8?B?QlBodzNUUUdrV3l3bURtNkd3VWJEbExISjZLMTRObGhQR0JUQS9LMnRuZzRt?=
 =?utf-8?B?RjMrcTRDa1F3djh4TjZVekhmUTVQTGpUanc2bnBaYUpRamFnQ3AwbXJMZWJJ?=
 =?utf-8?B?OGI2NFd2cHBFUkNtcXhnbXNKTkVxSUZuUGRMVmhvLy94VEV2TXpSYkh5b0NJ?=
 =?utf-8?B?d21nNGNCM0JWcVYrSld1OTJnR3Rjd0ZOVmdJblF6YTRpeGlzdTNtT1ZMVUlm?=
 =?utf-8?B?VEgrTTVaWGtDcnV3OTNBcDMvNlgvOXNBdVRkUGw5dXc4TkpJTVhmNU8xUUwx?=
 =?utf-8?B?VitIWE9PYzlNK0hwRy85UFVQdGVNRWdGTDBPZW04WFkrZHgzc2xwYWV2U1V3?=
 =?utf-8?B?N2t6QWhDbHo3bXBiV01wRzhnbkV3dnM2RjZ2Q29IMzJLa0hKbVBkSkE1aUFi?=
 =?utf-8?B?V1pPWk5RSVlQa0VkMXIzSk1ZOFFqT2hmWUVCRldKMHZsTVQ1SFF1SXBuVjZl?=
 =?utf-8?B?K0E4L1pkQ2gxSVFMd0tKTit2MG1mZ2NPYUtVZTNzYjhQNXFCVFFacGdwcmJs?=
 =?utf-8?B?UmNnOEZPVU85NmcvNVJZdlZRcGJ3ZVRlWlpBTjV1SUI1ekJtQ0pRY0lzcFdn?=
 =?utf-8?B?TFBXbVlaSGRDZStoSUF3bWJ2b2hnVnBGNnViNldqMGFRRllCdGV0Z29vN1VX?=
 =?utf-8?B?ZjhPRU44blZ0VDdtYmJ0dDlFdHFUdFpmbXVFZEthR3pCN1ZydkhqZGliUTh2?=
 =?utf-8?B?YlpFVUlCQ0RWejBEaXNINzNWellBcW5WL1ZQSlZPVm9CU1FjUjlYOEQ2dkRs?=
 =?utf-8?B?dFVaM1RjNkdDMk5rNFdZZ0NicWcyRUtTNlZ5c2xRZUpkTWxFYVo2SnJZQzYr?=
 =?utf-8?B?VUlici9hYTZSYkhmaWE2SWNxdmw0U25naGIydU1HSzErTGFVS2xnMmx6cFov?=
 =?utf-8?B?b3VZd3ZtNWszcy9BbHlqUXpqQ29NbFpqSitXS0c1OE8xQ01rRndzSllPUHJP?=
 =?utf-8?B?YjRvTkxGNHM4UTRqWnJ2SVFFdzBkcW9FZ2Q3K1ZscW1JS2RoaGVKTEgvWDls?=
 =?utf-8?B?c3pxSjhtT1E2azRzMTBkbE1yN3kySm4vMW5lU3VzY2xDNitXZnMrQ3hBUUVU?=
 =?utf-8?B?anV2V05wakdhcy9WcUNycm9LVEc0UHFCQ0s1NmFKdFFKS1d6SUUrMVd5bXAv?=
 =?utf-8?B?eTVBVTNnVnhDZDRVUWFxcGZSQjh6aTU1VVpnRnpuUUR5b1Y1NG1JQlEraDJH?=
 =?utf-8?B?aVVuaWRxQ3Njd3p2OSt1MWRhS3N0cmhwcmVMbEtGNDZDVmZPdms2Q1NSUGFT?=
 =?utf-8?B?Rk9RWlZkN08xWTBIOEFsS0o0WHlkdzVjNUw5b3d4QWQvaVl5ZGZvZEJDS21G?=
 =?utf-8?B?dHNNVW5GWGc4MHc4NGhGQXNsOXc1V0xQait6YTVkTE4zMHllQmthOEV1eVBC?=
 =?utf-8?B?STlyUVllREs4Q3JLRmRUNTFyUzFpOGgvOXlHMEtUMTVpeVdWakVjMFRqUmN5?=
 =?utf-8?B?aEcxbHlzbkJQRmtVQUprWTU0ZklQOFk0ZEJOcG9oTGFPemhQaXUxemxtcjB2?=
 =?utf-8?B?aUtnZWUzU29Pam0yOVVtSS9CK3QvWkNKRUFEZ1VCalNDeC9TUVg3ck9DVWVl?=
 =?utf-8?B?WXRBbnFuN2JiSmNicmU4YVhHOXEyTm40RmdpMDVidE1hcS9YdHUxRlM4MHJq?=
 =?utf-8?Q?XYLQVQw4PiCf7ytWBGNrFcOS9?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 354de098-8216-4901-b198-08db99245fa1
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 22:02:50.7188
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xzvR1lBFUuFrKUeoYnGZ2n3lcSJwnlveMWb8tdBzVfbTQecShp58pUCQir+EU6rjag0OuTVD8+OGjapzSV8IEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB7313
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 9 Aug 2023 23:45:34 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:

> On Wed, Jun 28, 2023 at 7:12=E2=80=AFPM Gary Guo <gary@garyguo.net> wrote=
:
> >
> > diff --git a/rust/macros/paste.rs b/rust/macros/paste.rs
> > new file mode 100644
> > index 000000000000..42fde0930b05
> > --- /dev/null
> > +++ b/rust/macros/paste.rs
> > @@ -0,0 +1,94 @@
> > +use proc_macro::{Delimiter, Group, Ident, Spacing, Span, TokenTree}; =
=20
>=20
> We need the license identifier to apply this -- is it our usual one?
>=20
>     // SPDX-License-Identifier: GPL-2.0
>=20
> If so, for the record, could you please confirm it is? Then I will add
> it on my side and apply it -- thanks!
>=20
> Cheers,
> Miguel

Hi Miguel,

Sorry I forgot to add license comments!

All my kernel contributions are permissively licensed if possible, so I
am fine with this being either MIT or GPL-2.0 (I think GPL-2.0 is
deprecated in as a SPDX license identifier and it should be
GPL-2.0-only going forward, though).

Given this is non-kernel specific generic code, I think it might worth
following the convention of the paste and pin-init code and make it
`Apache-2.0 OR MIT`? This would also make it the same license as the
`paste` crate (although we don't have to keep the same license as this
is a different implementation).

I'll leave the final decision to you.

Best,
Gary