Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Stefan Hajnoczi <stefanha@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     Jason Gunthorpe <jgg@ziepe.ca>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>
Subject: RE: [PATCH 2/4] vfio: use __aligned_u64 in struct
 vfio_device_gfx_plane_info
Thread-Topic: [PATCH 2/4] vfio: use __aligned_u64 in struct
 vfio_device_gfx_plane_info
Thread-Index: AQHZywUD9/fh9XBS6EyCf69oWksSBq/i2x/w
Date:   Thu, 10 Aug 2023 03:22:56 +0000
Message-ID: <BN9PR11MB5276BC132EAE86D470B886528C13A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230809210248.2898981-1-stefanha@redhat.com>
 <20230809210248.2898981-3-stefanha@redhat.com>
In-Reply-To: <20230809210248.2898981-3-stefanha@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B+SAwS74/tipXRHOeH78LfVyGesAiaAjWVlYRP3NGhbMxmxmwVp+eiaLlArU?=
 =?us-ascii?Q?7AAX5jBsXNV1Ws3NuSQElESViXzzFYFCMnGVYGjLoF9sD2u4U2lrFI6FW3Ew?=
 =?us-ascii?Q?DFCPJFctXsVwNKIVjJTM4L2dAJfbARXs3fPTQE/GkSbKRJdSqFKcZaOLW/TJ?=
 =?us-ascii?Q?CFdlFZ/nzgongznVZKFNKays1st2SwxaHSv7tYjPc5ka41hj3fyWFB590X3J?=
 =?us-ascii?Q?aJWw6zBCcvpbYer4cvd4emhtCF224PNYaq4Izcb1YZqlv2yBDT4k3XFP2npD?=
 =?us-ascii?Q?xpefyjC+VmWGFxU1oOBvQDYdd67qJ6bxKvXTreuG6hUo7ziSIr3Q+9uS9fHL?=
 =?us-ascii?Q?Bez/1roEqrwDk5/qA/LC3sftUOSrr1JFpJGsV+CdQ4Ei/SrakDCp3/aSslyF?=
 =?us-ascii?Q?v/s6TXA69RM2sSzFgvby20jhfOaAYZQivNNrHP2k1cOlpnQDwZdG4qZeHyZw?=
 =?us-ascii?Q?5hqYwgEDstnp/vyTG7MQHoW9ppQCHcUwZ7Se6gRrJO7AFrwaAvsFLB8sMRH9?=
 =?us-ascii?Q?8oadb52ISUojhb1l5yW8w3iEW18UmBwh4Ppt2QxWAsK/A9A/+rAWeAS4E+tT?=
 =?us-ascii?Q?H6inDbX9VgilPIkIETdXikWbj2yVkNkev7+x3cw0b0oFKfZ0ntKVIJz6zYix?=
 =?us-ascii?Q?6gALr3Aq/8eDKQlMeTSBEHY9GHCraPm8tw+Khsivul3G8uOzk2aJaOjQr1I2?=
 =?us-ascii?Q?Sfp/e6Uw/W+e1BlX5JT43mKswe5PD2Mk2DxtnxWo6G0g6yTFWNuGWPHp1nh/?=
 =?us-ascii?Q?Pq/8GwImo3jKDtQaLpyBXVHwYCGS1I3T6N5LouYEkIgqswzj/E/nv6u9RLpL?=
 =?us-ascii?Q?LBHJTaNV9Xdb132peHxaJ/6t9QgcBaZNqaRVgcl7q1W/sC+xLjhyx3DWQ5x3?=
 =?us-ascii?Q?87cMvCUdx1e6QfBnnfALaKQdutVQNd5iMiAMDRrMiFtqn1RPkJXQ8jCxUpCX?=
 =?us-ascii?Q?3e2QXTUxm30E4VPh2nUyijosrmxI15cWLppmFCWfXTyY7X37bXh0AhKbaKSL?=
 =?us-ascii?Q?FgjliN6E2Fy4cLil/NXFaTRT94FedZreSgXYmz9SxQ+dh0nXz0u+FWJUgHg1?=
 =?us-ascii?Q?Jha9i9B2pue7svAjQ8cbesg4pM9+jUSPurhDHK1IAPG2LlvaP5wh/cgXadXi?=
 =?us-ascii?Q?DsUx+0tnPTq4Av1FhyOu1gTlvZ/NnxGalrn5GA0JP7rzb1TJNsNO7rNYGq3e?=
 =?us-ascii?Q?r+FNkw31LgOigqpv47OF8OvwslYpS2oEGTlX0l6r3wPsv3ltg7aGDBagJEy5?=
 =?us-ascii?Q?1lk+P9O3oEv8jY+shec/ZVm4F4E4Zn7cddk0QIZ8kA4Ci5A7IWOG/Odru2pb?=
 =?us-ascii?Q?bPEOUN5SiNCSfXL67FjXLdh1kWeaxqhgGOu6BUAIkwS4cn3IG0F/TqLTKPPs?=
 =?us-ascii?Q?F6794c+jlrIds2EqUlEfm0GRXGzAFw5a6G61YryYoKDcnEeqCTLdBm7gt/Z8?=
 =?us-ascii?Q?IzTs2GH7zEhzJ1xhtCtcwGCboMIh7c3xkE1k7LYg/5oN5bZjKIpkSOHAbs4n?=
 =?us-ascii?Q?tDG+sWYGjHtUNZeJDLxH0l6xrRbb3uA/MjavicmXZJ6DN0Qccc0+nwjwS4bu?=
 =?us-ascii?Q?EApZ6wXem96reVhZT4BAygoiRluoW8kl+mtI1gZS?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 804bcaf6-97c2-45a4-8eba-08db9951178a
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2023 03:22:56.9099
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zbGGpufrr5x16nBR1txrwFrpWVz9zdvVmLhVMF8I7DJDy/oxsMqWgZ8N0yzrSLSqQoQ58Em1dWlwTAoF4AXnIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6011
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Stefan Hajnoczi <stefanha@redhat.com>
> Sent: Thursday, August 10, 2023 5:03 AM
>=20
> The memory layout of struct vfio_device_gfx_plane_info is
> architecture-dependent due to a u64 field and a struct size that is not
> a multiple of 8 bytes:
> - On x86_64 the struct size is padded to a multiple of 8 bytes.
> - On x32 the struct size is only a multiple of 4 bytes, not 8.
> - Other architectures may vary.
>=20
> Use __aligned_u64 to make memory layout consistent. This reduces the
> chance of holes that result in an information leak and the chance that

I didn't quite get this. The leak example [1] from your earlier fix is real=
ly
not caused by the use of __u64. Instead it's a counter example that on
x32 there is no hole with 4byte alignment for __u64.

I'd remove the hole part and just keep the compat reason.

[1] https://lore.kernel.org/lkml/20230801103114.757d7992.alex.williamson@re=
dhat.com/T/

> @@ -1392,6 +1392,8 @@ static long intel_vgpu_ioctl(struct vfio_device
> *vfio_dev, unsigned int cmd,
>  		if (dmabuf.argsz < minsz)
>  			return -EINVAL;
>=20
> +		minsz =3D min(minsz, sizeof(dmabuf));
> +

Is there a case where minsz could be greater than sizeof(dmabuf)?