Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Nicolin Chen <nicolinc@nvidia.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>, Jason Gunthorpe <jgg@nvidia.com>
CC:     "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
Subject: RE: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested domain
Thread-Topic: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested domain
Thread-Index: AQHZvh/uFyWMLiVXhUCSOYKFk2h4da/WraUQgAhYJoCAAMpSgIAAnN2AgABV8ACAAPMnQIAACsKAgAAAQaCAAArdAIAAc+AAgAAuy4CAAAHYgIAAEEsAgABtjjA=
Date:   Thu, 10 Aug 2023 02:49:59 +0000
Message-ID: <BN9PR11MB527683351B687B97AB84B51B8C13A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <ZNGypUee/U9d68TZ@Asurada-Nvidia> <ZNI2O4Upyna5AWDA@nvidia.com>
 <ZNJ+Uv/WJwngosjJ@Asurada-Nvidia>
 <BN9PR11MB5276BFFEC7E12EEBD4503BF08C12A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <DS0PR11MB7529C3646E38542457D7B75DC312A@DS0PR11MB7529.namprd11.prod.outlook.com>
 <BN9PR11MB5276912120F662498910A1D48C12A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <DS0PR11MB7529C310FAEA61B6E7988629C312A@DS0PR11MB7529.namprd11.prod.outlook.com>
 <ZNO92PIx2IQ70+DY@nvidia.com> <ZNPlGd4/72dahSs4@Asurada-Nvidia>
 <ZNPmpW3/zDnjqxyU@nvidia.com> <ZNP0UKGU6id5wfc6@Asurada-Nvidia>
In-Reply-To: <ZNP0UKGU6id5wfc6@Asurada-Nvidia>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fZIQ6CEJqndp90bdMz7xAHbBMlvdvo9krKyQvjix0iLSidJACL6vMkPBnF7b?=
 =?us-ascii?Q?l9JPru58INloTCdWfMBUJDtYGOG2YW4DKMeGeKo/fFU1MnRAUxBRBDBFejnP?=
 =?us-ascii?Q?x0cSe/SY6kzVQ6wHrBpozjAc1UZ52QdaptJEaV2Mp2rdwivLbd7QovUTFq3G?=
 =?us-ascii?Q?8gNRUpNn63TNkhrbYnphxMi3T0aX6eV8g7pVIi9yJprvPRQY4cNjiNrE2Zkj?=
 =?us-ascii?Q?T0P2mvTM162jFyXWpG5A4Zk1zF8Oxri3iXd1WnRtKF+7rnVOHbFlq6zDta/9?=
 =?us-ascii?Q?W+v2jWePpzv80BYjxMnhScawDR5XOpkrBS9A4EPQTwUdQlaXBXb2kSLdSfVj?=
 =?us-ascii?Q?VRhd4sINFkmtZfHCcJniNKns1WUXQP8V9+k4l01IfEuwstkrbRimLRXU2hce?=
 =?us-ascii?Q?LuQ9gNM70SRbklvvujZdxsjHwB141waLWa4xJxglu/NuQ+CNcLEwbCeTN4LH?=
 =?us-ascii?Q?g8Vuaf/fFVSS36HS2J4Y1OucuLR8XoXB0Y4RaH2j90CcSvDpNSPqAuGpAI/I?=
 =?us-ascii?Q?3n9yi9u+0wmJHwSnK/+QCjME36OM95v/4peprYe0NpmwvTaHh/6gOIWwLJ68?=
 =?us-ascii?Q?K0zC2JHDkcZdFSta55nivtwP2v3djtfERPEe6g5dp1/oAieSq5JxvOamvJBb?=
 =?us-ascii?Q?c18Gkk9OR+BMqVCxOwxpTXbXlgd8wNUN3o6i2uROy8mNjDuruiMFUzis71qy?=
 =?us-ascii?Q?EXW7ebZBcfZBXAiXI9z/5+TASD+f4MXoPpoLN47LhJgy1JUmZJSPdwdOxbWu?=
 =?us-ascii?Q?JIz40V90lLqABDl6/+IcXxWox2l0xI4OO3wQ6Z4HeVNlD9+tmDIeEPgxWMkW?=
 =?us-ascii?Q?xCBASxG1grTLAkjCaCFvXSG7X3UZcp1GFYqGadQ9KmHRHVv7tU7+rq0Q8C8A?=
 =?us-ascii?Q?yyOA1sbT0SD4CFcS89h8VXt4+xQiQ7yxo2S21k2pQqFnS38rkybTbNzho/go?=
 =?us-ascii?Q?43kWzJw4h5qezc40p3ffFVAyvwpswZ+DqgWL928z5Maqh6JyYtZ4Qc0I1V0E?=
 =?us-ascii?Q?PSIcDYeTT6ckGy3yNvXbebXeyuH9AhPufrKkLnZ8532ZbaO8nd6piVKv1PTy?=
 =?us-ascii?Q?WnAak4/rUMZNxjkNbTI73W9nsE0gDNZ3CVNQQ07bHrXqvor+ahcLf4D2evv4?=
 =?us-ascii?Q?ON35qBnB7R/ReA3L6CWJ3QZINcGqYq/bz7tMtxzzrC9prGNXE2tqBHAzRMJ1?=
 =?us-ascii?Q?8w8eLwbIFN46PA8I1CVnH5uiZRWYAKqnwjJfGsJ+zWjAkp4ffluT/HPcBDVU?=
 =?us-ascii?Q?F5wri11EWw/wRf/lDtVPv51A4OCSmGDOgLb/WfYOacxdDXdsSfYF3gDE4T9A?=
 =?us-ascii?Q?FYqLf8bKtcvOVK6ce5KC1a5cg7EMPB0m2vB2dFnaFpll2LzZQGNgzFTg/RV+?=
 =?us-ascii?Q?/Z+veOSQm4MqCV2q/Z6QXtBhwk3l5SbWAdcgnJeNixblraKXGfLjJ7yEC48A?=
 =?us-ascii?Q?dQ0bdNHlwqskH+wj/tC3mR36B756oDfet6ZyGlos3jIY+OSJOwC2+lw2hVQd?=
 =?us-ascii?Q?RPd1bs9r5IbqoBOIbpuHup7HeQWvBkwLBiYtAd2QKkSCoE/34vWwvBi4rfYH?=
 =?us-ascii?Q?13FWbHb91FOzQOik9FSJvgNTB8fqxP/5ym3Uv35D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9df07d5b-54a2-470d-03d0-08db994c7d3e
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2023 02:50:00.0321
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s9a8zy/UNYr4TMEUTT92mEjA9JGxlSLAmScW3l52j+ukoqTVKhZFo0BDv1vm/wqEo8evcOOFqW9h6/vrUiGjNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7594
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Thursday, August 10, 2023 4:17 AM
>=20
> On Wed, Aug 09, 2023 at 04:19:01PM -0300, Jason Gunthorpe wrote:
> > On Wed, Aug 09, 2023 at 12:12:25PM -0700, Nicolin Chen wrote:
> > > On Wed, Aug 09, 2023 at 01:24:56PM -0300, Jason Gunthorpe wrote:
> > > > Similarly for managing the array of invalidation commands.
> > >
> > > You mean an embedded uptr inside a driver user data struct right?
> > > Sure, that should go through the new helper too.
> >
> > If we are committed that all drivers have to process an array then put
> > the array in the top level struct and pass it in the same user_data
> > struct and use another helper to allow the driver to iterate through
> > it.
>=20
> I see. Both VTD and SMMU pass uptr to the arrays of invalidation
> commands/requests. The only difference is that SMMU's array is a
> ring buffer other than a plain one indexing from the beginning.
> But the helper could take two index inputs, which should work for
> VTD case too. If another IOMMU driver only supports one request,
> rather than a array of requests, we can treat that as a single-
> entry array.
>=20

I like this approach.