Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230809081840.16034-1-manivannan.sadhasivam@linaro.org>
In-Reply-To: <20230809081840.16034-1-manivannan.sadhasivam@linaro.org>
From:   Steev Klimaszewski <steev@kali.org>
Date:   Wed, 9 Aug 2023 22:33:59 -0500
Message-ID: <CAKXuJqgyCJmWF=LfSGPOr85n0SzLSRbDRvLtfAsw=tXwxXjiCQ@mail.gmail.com>
Subject: Re: [PATCH 0/2] PCI: qcom: Enable ASPM on host bridge and devices
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
        robh@kernel.org, gustavo.pimentel@synopsys.com,
        jingoohan1@gmail.com, andersson@kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 9, 2023 at 3:19=E2=80=AFAM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> Hi,
>
> This series enables ASPM by default on the host bridge and devices of sel=
ected
> Qcom platforms.
>
> The motivation behind enabling ASPM in the controller driver is provided =
in the
> commit message of patch 2/2.
>
> This series has been tested on SC8280-CRD and Lenovo Thinkpad X13s laptop
> and it helped save ~0.6W of power during runtime.
>
> - Mani
>
> Manivannan Sadhasivam (2):
>   PCI: dwc: Add host_post_init() callback
>   PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops
>
>  .../pci/controller/dwc/pcie-designware-host.c |  3 ++
>  drivers/pci/controller/dwc/pcie-designware.h  |  1 +
>  drivers/pci/controller/dwc/pcie-qcom.c        | 28 +++++++++++++++++++
>  3 files changed, 32 insertions(+)
>
> --
> 2.25.1
>
While not extremely scientific, and I don't have any way to measure
the power usage on my Thinkpad X13s, with these patches applied, I've
only gone down 29% battery power in the past 6 hours, suspend and
resume cycles don't see any issues either.

Tested-by: Steev Klimaszewski <steev@kali.org>