Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230710050024.2519893-1-chenhuacai@loongson.cn>
 <ce4cee2d76340d1776560c124c1894080ded13bb.camel@xry111.site> <292e6aa6b9399c8dd53562f51237090bcd6d19c5.camel@xry111.site>
In-Reply-To: <292e6aa6b9399c8dd53562f51237090bcd6d19c5.camel@xry111.site>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Thu, 10 Aug 2023 11:34:29 +0800
Message-ID: <CAAhV-H6JTbuK+ypvrUi21KOYcTOWmTKbwxK_D8M5y9XaXfJK4A@mail.gmail.com>
Subject: Re: [PATCH V2] LoongArch: Fix module relocation error with binutils 2.41
To:     Xi Ruoyao <xry111@xry111.site>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>, loongarch@lists.linux.dev,
        linux-arch@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn,
        WANG Xuerui <git@xen0n.name>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Ruoyao,

On Thu, Aug 10, 2023 at 11:21=E2=80=AFAM Xi Ruoyao <xry111@xry111.site> wro=
te:
>
> On Thu, 2023-08-10 at 11:20 +0800, Xi Ruoyao wrote:
> > Can we backport this patch into stable?  It fixes a build error with
> > binutils >=3D 2.41.
>
> Correction: not a build error, but all modules won't load if built with
> binutils >=3D 2.41 without the patch.
Generally we can backport, but I don't think there are users who use
the old kernels. :)

Huacai
>
> > On Mon, 2023-07-10 at 13:00 +0800, Huacai Chen wrote:
> > > Binutils 2.41 enables linker relaxation by default, but the kernel
> > > module loader doesn't support that, so just disable it. Otherwise we
> > > get such an error when loading modules:
> > >
> > > "Unknown relocation type 102"
> > >
> > > As an alternative, we could add linker relaxation support in the kern=
el
> > > module loader. But it is relatively large complexity that may or may =
not
> > > bring a similar gain, and we don't really want to include this linker
> > > pass in the kernel.
> > >
> > > Reviewed-by: WANG Xuerui <git@xen0n.name>
> > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> > > ---
> > >  arch/loongarch/Makefile | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> > > index 09ba338a64de..7466d3b15db8 100644
> > > --- a/arch/loongarch/Makefile
> > > +++ b/arch/loongarch/Makefile
> > > @@ -68,6 +68,8 @@ LDFLAGS_vmlinux                       +=3D -static =
-n -nostdlib
> > >  ifdef CONFIG_AS_HAS_EXPLICIT_RELOCS
> > >  cflags-y                       +=3D $(call cc-option,-mexplicit-relo=
cs)
> > >  KBUILD_CFLAGS_KERNEL           +=3D $(call cc-option,-mdirect-extern=
-access)
> > > +KBUILD_AFLAGS_MODULE           +=3D $(call cc-option,-mno-relax) $(c=
all cc-option,-Wa$(comma)-mno-relax)
> > > +KBUILD_CFLAGS_MODULE           +=3D $(call cc-option,-mno-relax) $(c=
all cc-option,-Wa$(comma)-mno-relax)
> > >  else
> > >  cflags-y                       +=3D $(call cc-option,-mno-explicit-r=
elocs)
> > >  KBUILD_AFLAGS_KERNEL           +=3D -Wa,-mla-global-with-pcrel
> >
>
> --
> Xi Ruoyao <xry111@xry111.site>
> School of Aerospace Science and Technology, Xidian University