Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Stefan Hajnoczi <stefanha@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     Jason Gunthorpe <jgg@ziepe.ca>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>
Subject: RE: [PATCH 3/4] vfio: use __aligned_u64 in struct
 vfio_iommu_type1_info
Thread-Topic: [PATCH 3/4] vfio: use __aligned_u64 in struct
 vfio_iommu_type1_info
Thread-Index: AQHZywUDvpHBRYjKtEWFDXR9GZe5kK/i3eJA
Date:   Thu, 10 Aug 2023 03:25:37 +0000
Message-ID: <BN9PR11MB5276D1304E854E2AE7E8EFA18C13A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230809210248.2898981-1-stefanha@redhat.com>
 <20230809210248.2898981-4-stefanha@redhat.com>
In-Reply-To: <20230809210248.2898981-4-stefanha@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DGQSHJjcItM8z2RaIipFyI9pXqueTvLimHpIGMjSi1/kk1MpDwJNK1Yav6p3?=
 =?us-ascii?Q?iPrwUht34WXiiGPYHNwadfaAgaualLPE0+e7OxTQDP0wU10yiFEB9e3EJ8D7?=
 =?us-ascii?Q?LB7KwnHwNeh9vi7PkkeNJBloBYZSrV+HyBW1wL1ts36TXB/MskKTg/GmTizx?=
 =?us-ascii?Q?7f7DMYSIVzJTrma55S71Ga34NxC0G6uXEwwoDTjL7Eb7Pr7Bf1m39WieWvka?=
 =?us-ascii?Q?HcVeumsmXlp5owv5BG26FgRMd3ZlaMh3Qg34OECcBjlxosSRe7sEDYCnU9sZ?=
 =?us-ascii?Q?nrAM4/AtxZZ5/bFGwa0GjU/2e0Uj3DFvD03kE7fJKJukOoxIq+rmRbyStEav?=
 =?us-ascii?Q?aDk0Dk7a5/JCL14Hy+m3L+ul7a71P39ymapwg5KKEPqspnD1IIIlSKeSIKMe?=
 =?us-ascii?Q?wU0Rk4ggtt8GMFYGchwwMCemB/lnU+bWSXcU+Ep2XkvqdKtc0gvBVgBo/3g9?=
 =?us-ascii?Q?uuOV3YADNAuY96rNvqhKJ634oO4PhmoS2hm1GTmxPXyUk+Txx0yPeRQfztlS?=
 =?us-ascii?Q?iuZDsI2iI2wNnD3sXyIpxDMcUvvViE7BvLomxGoU2Mg53HhGPsMGcHhM6zTM?=
 =?us-ascii?Q?uKDjTj2yYT/Eofcr4IILCc90IyQ8q2fL5IMTnti0JOmVykPVbQVWrIzCDOfH?=
 =?us-ascii?Q?fkG2j4hfwgYPHAThPgPf8GlSYkjIYCAME5m0lV+lKchWeP4EPX9n+XNAXbPV?=
 =?us-ascii?Q?e+NjU81k8V1x6wkoStx51jQJKwhv4GKSaOLSmU/P7zTfvlqpG3VQywV6MqfD?=
 =?us-ascii?Q?rrCRXSa2nzscOs+xepeGvWB5GmUlwgGwbPFYx9Mx0BF9sxR4KtuPB2l8+FQE?=
 =?us-ascii?Q?IoSJSpm1syxC31HjjZa9+xFSYjOAZhlWuOQVvHDFYQCSLV/IXi8AF4tyKcEV?=
 =?us-ascii?Q?Hkw8eZyNgvYVV77BfIYhFvXMjf4fcY7gZBsUHCdLQ6DZX0rYkyMYWkNczYfu?=
 =?us-ascii?Q?bQq+bDSnlxgxeXx8rh/baA/tNsXwuXpjv4Xl6o7TWIxnWSk/MK4ndc/MibvD?=
 =?us-ascii?Q?9DlkvIjWa1KIpkbqNkMLFzQMnNyuEc5f1OmilsenEx0grawdmw3lcPbMYU5a?=
 =?us-ascii?Q?Ny7SIp0f4Nuf6XPE9c56tPdetT3mNdcfkMjeuIOxRQbj1q0hNVXOzKiSk4T7?=
 =?us-ascii?Q?kg06zvSohXCxFO7uIvonoGZ89GzlJ2Jj/8a1Ly0QOTtL8iPHLk3Rnmn9fT0n?=
 =?us-ascii?Q?37wbRY4A6jLAolE2WZEwpuPSa98iSYUo79YVtIXsdr9TusrtfhKM531uwzoJ?=
 =?us-ascii?Q?aRMK4yZaMfTsd/NjE+aidcszQPQyQxv7Ac0QHLxSAjgcvh1v41x1ZeM6M7lI?=
 =?us-ascii?Q?Ifn0uHzMV4/IOt5QiJjLYW/Yo3dB2+FWcgq2YPhHhy183du1nLBjg1XKbjcc?=
 =?us-ascii?Q?10cl1dMiGT+mou2JoGdh/aCum/OPDuniQDYkT6F9+AjNmPLbKQGr4yMMdzYg?=
 =?us-ascii?Q?I+xd+QSwYKDJSt4bIS6FCkVrtyVj40SjN+tBuE3quexED8oaOzZd98t7BVll?=
 =?us-ascii?Q?iq2Y5lvjwt9Ku2Zu/j9JhqXvrMjyOOF3byjjIAtro8egal1IS40tf/k9ZnQ+?=
 =?us-ascii?Q?33gvYahE3SZy5Ka9JP6yO9WlrdTaDD2xur1BNCdW?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35ef5d58-69fe-42c1-de6f-08db9951776b
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2023 03:25:37.7412
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FPPUGowUskg4wujQefugGL3FJ+LVLZT5oPDgS0qriYi1RionSvK5PdvQFZYJVTuM64NsXozVI7FfHo0qvBaFUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6011
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Stefan Hajnoczi <stefanha@redhat.com>
> Sent: Thursday, August 10, 2023 5:03 AM
>
> @@ -1303,8 +1303,9 @@ struct vfio_iommu_type1_info {
>  	__u32	flags;
>  #define VFIO_IOMMU_INFO_PGSIZES (1 << 0)	/* supported page sizes info
> */
>  #define VFIO_IOMMU_INFO_CAPS	(1 << 1)	/* Info supports caps */
> -	__u64	iova_pgsizes;	/* Bitmap of supported page sizes */
> +	__aligned_u64	iova_pgsizes;		/* Bitmap of supported page
> sizes */
>  	__u32   cap_offset;	/* Offset within info struct of first cap */
> +	__u32   reserved;

isn't this conflicting with the new 'pad' field introduced in your another
patch " [PATCH v3] vfio: align capability structures"?

@@ -1304,6 +1305,7 @@ struct vfio_iommu_type1_info {
 #define VFIO_IOMMU_INFO_CAPS	(1 << 1)	/* Info supports caps */
 	__u64	iova_pgsizes;	/* Bitmap of supported page sizes */
 	__u32   cap_offset;	/* Offset within info struct of first cap */
+	__u32   pad;
 };