Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230806-xiaomi-star-v1-0-0c384e8b5737@gmail.com>
 <20230806-xiaomi-star-v1-3-0c384e8b5737@gmail.com> <27bd3a9e-192f-43e9-b417-784c6d9c3ecd@linaro.org>
In-Reply-To: <27bd3a9e-192f-43e9-b417-784c6d9c3ecd@linaro.org>
From:   Sophon Wu <wuxilin123@gmail.com>
Date:   Thu, 10 Aug 2023 13:30:18 +0800
Message-ID: <CAEPPPKsOTJkfd8sn=ApUKPf6MqQOEmVk9EC8OJd-Ln82cF0Xnw@mail.gmail.com>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: Add device tree for Xiaomi Mi 11 Ultra
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Tony Luck <tony.luck@intel.com>,
        "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Konrad Dybcio <konrad.dybcio@linaro.org> =E4=BA=8E2023=E5=B9=B48=E6=9C=888=
=E6=97=A5=E5=91=A8=E4=BA=8C 00:05=E5=86=99=E9=81=93=EF=BC=9A
>On 5.08.2023 19:03, Xilin Wu via B4 Relay wrote:
>> From: Xilin Wu <wuxilin123@gmail.com>
>>
>> Add support for Xiaomi Mi 11 Ultra. This commit brings support for:
>> * Front and rear display panels (initialized by bootloader)
>> * USB
>> * UFS
>> * PCIe0
>> * Thermistor sensors
>> * ADSP/CDSP/Modem/SLPI
>> * IR Transmitter
>> * RTC provided by PMK8350
>> * Buttons
>>
>> To create a working boot image, you need to run:
>> cat arch/arm64/boot/Image.gz arch/arm64/boot/dts/qcom/sm8350-xiaomi-\
>> star.dtb > .Image.gz-dtb
>>
>> mkbootimg \
>> --kernel .Image.gz-dtb \
>> --ramdisk some_initrd.img \
>> --pagesize 4096 \
>> --base 0x0 \
>> --kernel_offset 0x8000 \
>> --ramdisk_offset 0x1000000 \
>> --tags_offset 0x100 \
>> --cmdline "SOME_CMDLINE" \
>> --dtb_offset 0x1f00000 \
>> --header_version 1 \
>> --os_version 14.0.0 \
>> --os_patch_level 2099-12 \
>> -o boot.img-xiaomi-star
>>
>> Then, you can flash it to slot b on the device:
>>
>> // You have to either pull vbmeta{"","_system"} from
>> // /dev/block/bootdevice/by-name/ or build one as a part of AOSP build p=
rocess
>> fastboot --disable-verity --disable-verification flash vbmeta_b vbmeta.i=
mg
>> fastboot --disable-verity --disable-verification flash vbmeta_system_b \
>> vbmeta_system.img
>>
>> fastboot flash boot_b boot.img-xiaomi-star
>> fastboot erase dtbo_b
>> fastboot set_active b
>> fastboot reboot
>>
>> Signed-off-by: Xilin Wu <wuxilin123@gmail.com>
>> ---
>[...]
>
>
>> +&adsp {
>> +    status =3D "okay";
>> +    firmware-name =3D "qcom/sm8350/xiaomi/star/adsp.mbn";
>> +};
>Please keep status as the last property, everywhere.
>
>BTW, is the rear screen connected via DSI, or is it some stupid
>SPI display?
>
>Konrad

Thanks. Will fix in v2. The rear screen is connected via DSI.