Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <37782447-43c7-50f9-b9b4-5fbca94ce8c6@linaro.org>
Date:   Thu, 10 Aug 2023 08:22:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.1
Subject: Re: [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES
Content-Language: en-US
To:     Varshini.Rajendran@microchip.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
        claudiu.beznea@microchip.com, linux-crypto@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230728102442.265820-1-varshini.rajendran@microchip.com>
 <09bd1388-02aa-32c7-319e-d7150a0f3e9c@linaro.org>
 <1ec901d0-44c2-1d28-5976-d93abfffee67@microchip.com>
From:   Tudor Ambarus <tudor.ambarus@linaro.org>
In-Reply-To: <1ec901d0-44c2-1d28-5976-d93abfffee67@microchip.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/10/23 06:38, Varshini.Rajendran@microchip.com wrote:
>> On 7/28/23 11:24, Varshini Rajendran wrote:
>>> Add DT bindings for atmel TDES.
>> NACK. The atmel crypto drivers check the version at runtime and
>> fill a capabilities structure based on the version identified.
>> There's a single compatible regardless of the version of the IP
>> used until now, why do you want to change it?
>>
> Hi Tudor,

Hi,

> 
> I am aware that there is no change in the crypto IP used. This patch is 
> to add a SoC specific compatible as expected by writing-bindings 
> guideline. Maybe a bit more explanation in the commit description might 
> do the trick.
> 

So you add a compatible that will never be used just to comply with
the writing bindings guideline?