Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808033130.2226-1-Wenhua.Lin@unisoc.com> <ZNJBrnKGVGXaFAtc@smile.fi.intel.com>
In-Reply-To: <ZNJBrnKGVGXaFAtc@smile.fi.intel.com>
From:   wenhua lin <wenhua.lin1994@gmail.com>
Date:   Thu, 10 Aug 2023 15:03:21 +0800
Message-ID: <CAB9BWhdYUcnkwqFQz+e8dK-_Vv6on=Poo8QmKrk55c+zrQ4-mw@mail.gmail.com>
Subject: Re: [PATCH 2/3] gpio: sprd: In the sleep state, the eic dbnc clk must
 be forced open
To:     Andy Shevchenko <andy@kernel.org>
Cc:     Wenhua Lin <Wenhua.Lin@unisoc.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Aug 8, 2023 at 9:23=E2=80=AFPM Andy Shevchenko <andy@kernel.org> wr=
ote:
>
> On Tue, Aug 08, 2023 at 11:31:30AM +0800, Wenhua Lin wrote:
> > In the sleep state, Eic dbnc has no clock and the clk enable
>
> Comma is not needed here.

Hi Andy:
We will make changes in patch v2.

Thanks
Wernhua.Lin

>
> > of dbnc needs to be forced open, so that eic can wake up normally.
>
> ...
>
> > +#define SPRD_EIC_DBNC_FORCE_CLK              0x8000
>
> BIT(15) ?

Hi Andy:
Yes, The bit15 is clock of dbnc forced open

Thanks
Wernhua.Lin

>
> --
> With Best Regards,
> Andy Shevchenko
>
>