Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 09:34:57 +0200
From:   Lukas Wunner <lukas@wunner.de>
To:     Alistair Francis <alistair23@gmail.com>
Cc:     bhelgaas@google.com, linux-pci@vger.kernel.org,
        Jonathan.Cameron@huawei.com, alex.williamson@redhat.com,
        christian.koenig@amd.com, kch@nvidia.com,
        gregkh@linuxfoundation.org, logang@deltatee.com,
        linux-kernel@vger.kernel.org,
        Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v3] PCI/DOE: Expose the DOE protocols via sysfs
Message-ID: <20230810073457.GA26246@wunner.de>
References: <20230809232851.1004023-1-alistair.francis@wdc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230809232851.1004023-1-alistair.francis@wdc.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Aug 09, 2023 at 07:28:51PM -0400, Alistair Francis wrote:
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1226,6 +1227,12 @@ static int pci_create_resource_files(struct pci_dev *pdev)
>  	int i;
>  	int retval;
>  
> +#ifdef CONFIG_PCI_DOE
> +	retval = doe_sysfs_init(pdev);
> +	if (retval)
> +		return retval;
> +#endif
> +

The preferred way to expose PCI sysfs attributes nowadays is to add them
to pci_dev_attr_groups[] and use the ->is_visible callback to check
whether they're applicable to a particular pci_dev.  The alternative
via pci_create_resource_files() has race conditions which I think
still haven't been fixed. Bjorn recommended the ->is_visible approach
in response to the most recent attempt to fix the race:

https://lore.kernel.org/linux-pci/20230427161458.GA249886@bhelgaas/

To avoid (most of) the #ifdefs, you may want to consider adding a
doe-sysfs.c file like I've done for cma in this commit:

https://github.com/l1k/linux/commit/b057e2fb0ee0

Thanks,

Lukas