Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808033144.2276-1-Wenhua.Lin@unisoc.com> <e5d5a440-af25-17a7-40a2-8dbbc8c20c69@linux.alibaba.com>
In-Reply-To: <e5d5a440-af25-17a7-40a2-8dbbc8c20c69@linux.alibaba.com>
From:   wenhua lin <wenhua.lin1994@gmail.com>
Date:   Thu, 10 Aug 2023 15:08:32 +0800
Message-ID: <CAB9BWhdseF56JyTC75MLGmo=ZRpTfmLOc=U3XB-zHnAif=fALQ@mail.gmail.com>
Subject: Re: [PATCH 3/3] gpio: sprd: Add clear interrupt
To:     Baolin Wang <baolin.wang@linux.alibaba.com>
Cc:     Wenhua Lin <Wenhua.Lin@unisoc.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Shevchenko <andy@kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 9, 2023 at 9:31=E2=80=AFAM Baolin Wang
<baolin.wang@linux.alibaba.com> wrote:
>
>
>
> On 8/8/2023 11:31 AM, Wenhua Lin wrote:
> > Clear interrupt after set the interrupt type.
>
> Sorry, NAK. The commit message is meaningless.

Hi baolin:
We will re-modify the commit message and submit it in patch v2.

Thanks
Wenhua.Lin

>
> > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> > ---
> >   drivers/gpio/gpio-eic-sprd.c | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.=
c
> > index c506cfd6df8e..31125f53bc97 100644
> > --- a/drivers/gpio/gpio-eic-sprd.c
> > +++ b/drivers/gpio/gpio-eic-sprd.c
> > @@ -374,29 +374,34 @@ static int sprd_eic_irq_set_type(struct irq_data =
*data, unsigned int flow_type)
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTB=
OTH, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTM=
ODE, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTP=
OL, 1);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTC=
LR, 1);
> >                       irq_set_handler_locked(data, handle_edge_irq);
> >                       break;
> >               case IRQ_TYPE_EDGE_FALLING:
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTB=
OTH, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTM=
ODE, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTP=
OL, 0);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTC=
LR, 1);
> >                       irq_set_handler_locked(data, handle_edge_irq);
> >                       break;
> >               case IRQ_TYPE_EDGE_BOTH:
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTM=
ODE, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTB=
OTH, 1);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTC=
LR, 1);
> >                       irq_set_handler_locked(data, handle_edge_irq);
> >                       break;
> >               case IRQ_TYPE_LEVEL_HIGH:
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTB=
OTH, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTM=
ODE, 1);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTP=
OL, 1);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTC=
LR, 1);
> >                       irq_set_handler_locked(data, handle_level_irq);
> >                       break;
> >               case IRQ_TYPE_LEVEL_LOW:
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTB=
OTH, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTM=
ODE, 1);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTP=
OL, 0);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTC=
LR, 1);
> >                       irq_set_handler_locked(data, handle_level_irq);
> >                       break;
> >               default:
> > @@ -409,29 +414,34 @@ static int sprd_eic_irq_set_type(struct irq_data =
*data, unsigned int flow_type)
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBO=
TH, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMO=
DE, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPO=
L, 1);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCL=
R, 1);
> >                       irq_set_handler_locked(data, handle_edge_irq);
> >                       break;
> >               case IRQ_TYPE_EDGE_FALLING:
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBO=
TH, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMO=
DE, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPO=
L, 0);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCL=
R, 1);
> >                       irq_set_handler_locked(data, handle_edge_irq);
> >                       break;
> >               case IRQ_TYPE_EDGE_BOTH:
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMO=
DE, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBO=
TH, 1);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCL=
R, 1);
> >                       irq_set_handler_locked(data, handle_edge_irq);
> >                       break;
> >               case IRQ_TYPE_LEVEL_HIGH:
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBO=
TH, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMO=
DE, 1);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPO=
L, 1);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCL=
R, 1);
> >                       irq_set_handler_locked(data, handle_level_irq);
> >                       break;
> >               case IRQ_TYPE_LEVEL_LOW:
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBO=
TH, 0);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMO=
DE, 1);
> >                       sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPO=
L, 0);
> > +                     sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCL=
R, 1);
> >                       irq_set_handler_locked(data, handle_level_irq);
> >                       break;
> >               default: