Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Aug 2023 09:44:44 +0200
From:   Lukas Wunner <lukas@wunner.de>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Alistair Francis <alistair23@gmail.com>, bhelgaas@google.com,
        linux-pci@vger.kernel.org, Jonathan.Cameron@huawei.com,
        alex.williamson@redhat.com, christian.koenig@amd.com,
        kch@nvidia.com, logang@deltatee.com, linux-kernel@vger.kernel.org,
        Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v3] PCI/DOE: Expose the DOE protocols via sysfs
Message-ID: <20230810074444.GA11861@wunner.de>
References: <20230809232851.1004023-1-alistair.francis@wdc.com>
 <2023081005-ground-muster-63c8@gregkh>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023081005-ground-muster-63c8@gregkh>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Aug 10, 2023 at 07:05:12AM +0200, Greg KH wrote:
> On Wed, Aug 09, 2023 at 07:28:51PM -0400, Alistair Francis wrote:
> > v3:
> >  - Expose each DOE feature as a separate file
> 
> But you don't actually have anything in the sysfs files, why not?

He wants to expose a list of supported protocols.

He first exposed the list in a single attribute, separated by newlines.
Which made sense because it allows users to grep for a specific protocol.

You told him not to expose multiple values in a single attribute.
So he's exposing the available protocols each in an empty file.
The file name contains the protocol.

You got what you asked for. ;)


> > --- a/drivers/pci/doe.c
> > +++ b/drivers/pci/doe.c
> > @@ -56,6 +56,10 @@ struct pci_doe_mb {
> >  	wait_queue_head_t wq;
> >  	struct workqueue_struct *work_queue;
> >  	unsigned long flags;
> > +
> > +#ifdef CONFIG_SYSFS
> > +	struct device_attribute *sysfs_attrs;
> > +#endif
> 
> Please don't put #ifdefs in .c files if you can prevent it.  I think
> this will work just fine if you don't have the #ifdef.  And who would be
> using pci without sysfs?

People with space-constrained devices such as routers.

It is perfectly legal to compile a kernel with CONFIG_PCI=y and
CONFIG_SYSFS=n.

And it is reasonable not to include code in the kernel which has
specifically been deselected in the kernel config.

Thanks,

Lukas