Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <37a235d0-3da1-85c3-766d-29fd31d8a797@amd.com>
Date:   Thu, 10 Aug 2023 09:03:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH drm-misc-next] drm/test: drm_exec: fix memory leak on
 object prepare
Content-Language: en-US
To:     Danilo Krummrich <dakr@redhat.com>, airlied@gmail.com,
        daniel@ffwll.ch, alexander.deucher@amd.com, arthurgrillo@riseup.net
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230809225034.8803-1-dakr@redhat.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230809225034.8803-1-dakr@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkFCb3RXQ3hJZXduTnJJR1NHT3IyUkJ3MXJNbm5WZzY1bnhCL0VqaTlscExF?=
 =?utf-8?B?LzZzZVRNM1BJRWJGSS9qdk5rVEdhYXVSK0tyclVBVUlKOS9BVUV0VTNSTFZs?=
 =?utf-8?B?ZkpmbDlBNU5OT0JqWkVTa3ZRaUVxT3JSTm4vM01ZemM4K1dvMmFLaU1OOG15?=
 =?utf-8?B?RmdhMHd5UVZDZVRUQjc0aUhiZS9KOGFrOHh4T3lBdEdjQjFXU1ZUby83cndi?=
 =?utf-8?B?NFFXQ3R1VGZiL25HUXZqcXBSS0UyVEs1bTFyaVp4SEowamVSQkcyblJiRkZz?=
 =?utf-8?B?S2tqOTVlWFBMTlZ4ck1ESUNLaExKaERqV0dEY2lhNi9RQmJwSk5lMzQxSzdj?=
 =?utf-8?B?ZEdyRERkbFZsMnJoaTJ1amdvTFFpQlZ0REhmeDlMeXBXdE9LTys1enJuN3ls?=
 =?utf-8?B?RzBVc2VMbTg5OGpDTzc4ampDR2xyRDNsWHRhNWJmQlFld081Um5PKzB0dytI?=
 =?utf-8?B?TVdqdHh4eWpqdlVQekhmYldjZlhmZ0RMRjQ3VVltalR1TGpWSWtlY20wbGxr?=
 =?utf-8?B?ODN5cVp2YWpFdE9XUHNpM3pHdTF1TXFsOUllbUYyRUJ3d04zK1RBZHdiNjdy?=
 =?utf-8?B?U3lVTHZFdmZjUnI2OXpJU0t2NUNnUzVVak5RbU8ycE90RWhkazNRSUI5MUJM?=
 =?utf-8?B?MUk1ak44VVdQTmdSSmZwNWUvWHd4ZTMvSVNHLzdNMGhmWTg5d3NRRlJNR092?=
 =?utf-8?B?ZEJxWVhUS2ZOZ0lnMXB1aDlWTkZ1V25ZSVlNMU1naE5XOWFqSVltOWpNby9F?=
 =?utf-8?B?WEVtRTV3RVhZOWhCOFcySHMrSGxFS05neG5SWUx5blFrVFU1QVVPL21FVTRE?=
 =?utf-8?B?ZkNyRTROSW9yREZZWDl4OTRIOFk1UlFlcHV2VU8zdHp4QklPc1hBeFlNVlQy?=
 =?utf-8?B?SitwZGFTaXhCTXBvSkc4THhoUThhMmQxblZNK3o1eG5SeEpTWitUeThMUWYr?=
 =?utf-8?B?aG9UMzBienNwNU1KZU1tNHVQVXNaOHFmTGJPMTQ0aWE3dm55d1R6VzVxNUhV?=
 =?utf-8?B?RmJrazY5UEhKU3o2c3hnRlo5MEVUQ1NDMmxMZjI2TE14cFN6RHJxR1EydGtw?=
 =?utf-8?B?T3BYVDI4SW5kUDU5Ty9YZjRKQVZxMTlWRzFkU09DazNhZkdTUFMzbGRTclNh?=
 =?utf-8?B?WkMzTlFUYnlrOFk2YWdSSnR1cWlMWStuUWIxMWlqVnozeHd5alYxNHdJeWZq?=
 =?utf-8?B?K3UzdnBOK2Jwb0IxemVVcitJaXFtaSs1MFB5VmVJWUQzVm5HNVdYTzJUVHY0?=
 =?utf-8?B?ZmZFUkl2WVdjSHlXWWV0Rk9vNDZIdHhzQTlKTnVEWTYyM1lHV1IvdzRmdFFp?=
 =?utf-8?B?QU8yUzFFVU4xdXFUWkM4MjV5R2t0eXpHZGtVUEJNdW9mSHkwK3VRQjRvNnFF?=
 =?utf-8?B?Y3dDTE1rSTZETStnOHBTQ3Z6cFhJUkEvclcrMVBZMFpjRHliODJnaTdTRXJB?=
 =?utf-8?B?UjN4eGlBSytwZ3JsNllBT0srWmNVQks3TExFOXJYV0czSDlia0UrSkMrN1c4?=
 =?utf-8?B?TUxtN1ZDUWxBQWUxQTd2SnZnSHlRWklhSlpxWWxNTTVodFlub2VSa0dCdHVm?=
 =?utf-8?B?TncxWXJOZFBmSzVmaWx1V3JJZVBGejEzekJVU1NsVUhpcUVJTXhhTi9mbDFM?=
 =?utf-8?B?TExZMHNHdmhoOHd4dVpVUGdBSml5WkZOUUxYbFRreXp6aHJZSFZBek5VM3d5?=
 =?utf-8?B?bDk1N0VqVjV4ckdrWmxqWVZqV0xBbVk3VjFGbnhJZ1NwYVZPYU9WZlpiZ3hR?=
 =?utf-8?B?MlpGRWJ6cGorR0JDcE1mZGtjRHo0eEdURXFZNHhSNU10eTU2dzg3b3BoYXk4?=
 =?utf-8?B?cXBpaHBNN3lBZG9Wd2pua0hQbk9QSmZ0am5JckxxdS9lS0ZzNGJZTmxHeFFR?=
 =?utf-8?B?YUdNR2lmbENyNEN2WG1uTzFqOHFvRUFjZkM0Y08zWHl4R0NYUmxHOFYzZ3NL?=
 =?utf-8?B?SnVCQU1nRzBjZ255RUhmRFFHeVp3VnY4WXJHSnFmblA4cDhZVVltWEx0djJK?=
 =?utf-8?B?OXFab3BRZmM3bzNLVTVmMkFaa0FXTkVnckJWMmVQZi90MFNrdHhJM0kwK0o5?=
 =?utf-8?B?RjlyWXpRb3N4TWV4SU9tbW91R3A1V3ZlQXM2dnVsUDQzdUVWWWxiOUNWa3BU?=
 =?utf-8?B?bXJNRUxRUStFdUxpYkc5NTA4cE9VODUrbTNRbFFWM3ROVTJLZUR0b3BrS2FF?=
 =?utf-8?Q?w6iir4wx01K+Z3n8ejKjmBviVUINprC7zxOD8s+qwur1?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19d5ee40-489e-4a41-b0e7-08db996fe155
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 07:03:20.7015
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EgpSnkdxBy00RF97itzob8GcWic4exRDAyTWsK7HxTWTRbAE1qOGbo851YfCz67p
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6763
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 10.08.23 um 00:50 schrieb Danilo Krummrich:
> drm_exec_prepare_obj() and drm_exec_prepare_array() both reserve
> dma-fence slots and hence a dma_resv_list without ever freeing it.
>
> Make sure to call drm_gem_private_object_fini() for each GEM object
> passed to drm_exec_prepare_obj()/drm_exec_prepare_array() throughout the
> test to fix this up.
>
> While at it, remove some trailing empty lines.
>
> Fixes: 9710631cc8f3 ("drm: add drm_exec selftests v4")
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>

Reviewed and pushed to drm-misc-next.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/tests/drm_exec_test.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_exec_test.c b/drivers/gpu/drm/tests/drm_exec_test.c
> index f79c9f0359aa..9ccf0dd9ca89 100644
> --- a/drivers/gpu/drm/tests/drm_exec_test.c
> +++ b/drivers/gpu/drm/tests/drm_exec_test.c
> @@ -125,8 +125,6 @@ static void test_duplicates(struct kunit *test)
>   	drm_exec_fini(&exec);
>   }
>   
> -
> -
>   static void test_prepare(struct kunit *test)
>   {
>   	struct drm_exec_priv *priv = test->priv;
> @@ -145,6 +143,8 @@ static void test_prepare(struct kunit *test)
>   			break;
>   	}
>   	drm_exec_fini(&exec);
> +
> +	drm_gem_private_object_fini(&gobj);
>   }
>   
>   static void test_prepare_array(struct kunit *test)
> @@ -165,6 +165,9 @@ static void test_prepare_array(struct kunit *test)
>   					     1);
>   	KUNIT_EXPECT_EQ(test, ret, 0);
>   	drm_exec_fini(&exec);
> +
> +	drm_gem_private_object_fini(&gobj1);
> +	drm_gem_private_object_fini(&gobj2);
>   }
>   
>   static struct kunit_case drm_exec_tests[] = {
>
> base-commit: e05f3938c5a7896d09736e3381675a57ffee7a0a