Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CACRpkdY02BbfkxSbyb5U+B29CYyNrhxtSADinYmYJ+ZCM04bjQ@mail.gmail.com>
 <20230809071738.2359532-1-mwalle@kernel.org>
In-Reply-To: <20230809071738.2359532-1-mwalle@kernel.org>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 10 Aug 2023 10:45:16 +0200
Message-ID: <CACRpkdbYZRG-KrURmzxrU4j6iPUkSZ=zTkuvMounGF3XqvQ1mw@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] gpio: ds4520: Add ADI DS4520 GPIO Expander Support
To:     Michael Walle <mwalle@kernel.org>
Cc:     brgl@bgdev.pl, devicetree@vger.kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, okan.sahin@analog.com,
        robh+dt@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 9, 2023 at 9:19=E2=80=AFAM Michael Walle <mwalle@kernel.org> wr=
ote:
> > On Thu, Jul 27, 2023 at 11:55=3DE2=3D80=3DAFAM Okan Sahin <okan.sahin@a=
nalog.com>=3D
> >  wrote:
> >
> >> The DS4520 is a 9-bit nonvolatile (NV) I/O expander.
> >> It offers users a digitally programmable alternative
> >> to hardware jumpers and mechanical switches that are
> >> being used to control digital logic node.
> >>
> >> Signed-off-by: Okan Sahin <okan.sahin@analog.com>
> >
> > Too late to add review tags but just pointing out what a beauty
> > this driver is when using regmap GPIO. Total success!
>
> Mh somehow I'm always missing consumers of regmap GPIO.
>
> Linus, Bartosz, what do you think about the patch below?
(...)
> +K:     (devm_)?gpio_regmap_(un)?register

I never saw that globbing trick before, but makes perfect sense so:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij