Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     Baolu Lu <baolu.lu@linux.intel.com>,
        "Zhang, Tina" <tina.zhang@intel.com>,
        Michael Shavit <mshavit@google.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/5] iommu: Call helper function to get assigned pasid
 value
Thread-Topic: [PATCH 2/5] iommu: Call helper function to get assigned pasid
 value
Thread-Index: AQHZyczxCRfFMGhSVk2JCjxjKYlmLq/hG1GAgACeSCCAAC6iAIABQplw
Date:   Thu, 10 Aug 2023 07:52:52 +0000
Message-ID: <BN9PR11MB5276A5E619DF6638677DFFA58C13A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230808074944.7825-1-tina.zhang@intel.com>
 <20230808074944.7825-3-tina.zhang@intel.com>
 <f3d8692e-b13d-97ee-2288-c2be1858dcfa@linux.intel.com>
 <BN9PR11MB52767F29A6C11157659D375B8C12A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZNOH9lPdTnltb9JZ@ziepe.ca>
In-Reply-To: <ZNOH9lPdTnltb9JZ@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IueTiEtZ/9E6WZwu/ThosVldSxpF9E50cICCnIzSwOG6Ktt3UgTnjB/JpKqp?=
 =?us-ascii?Q?10KbSxhPeuvDVTh/o8eTRIlyocppOs4Z2Dy2mVHexJSeNvGLkSbJhwgRrzud?=
 =?us-ascii?Q?zSOiQZOwQMiykfLE84LW6K7QR+04p4x3Ge8g+aZgRAvw5sRer9BMHeUeFAu5?=
 =?us-ascii?Q?xTQ/pWq8PB3bo2qojhj1kENWjjmbyF2sguMcr0gRAJmc7eXzkVkAb9kh1+RP?=
 =?us-ascii?Q?ju4xxu5I+tE0B/T0frpHUc+0ESqfmhiKv+cO+doaHFjeRYllElzriqahlF9G?=
 =?us-ascii?Q?BK8nsP2CFHS9xGM/9QuIMQ87Pj/9P2VSXGgZuIPkUmJbLiBxVQOfrmwaydQM?=
 =?us-ascii?Q?5aPElRiYiKST1vygXTT+Vqv6JLoO15t6l6RiFcZHO3FAGXEgJnx88AeoIjYI?=
 =?us-ascii?Q?nJ4V6UD4aQt5+S/s3U+yyYmnYk8gNBQs55J+l25MM3oJUmfeODt6tlC+Rq4H?=
 =?us-ascii?Q?ggC3UBnKbwC6UsOAJDuzZvXCM8JG2sZ76G+bWFDLbiCZEuyrNzBHLsnEkM9+?=
 =?us-ascii?Q?JK6xKs+AsXOwghk+g9AbCERqb0RJtOUi60R6tCOfvByDYMA3ycKfdG4Uj2lP?=
 =?us-ascii?Q?2oHm1kWa7Vufr5oxjY9MJRVQgszhTJhfnKSA9y1rbhc5LlLRCeVX3vrVmOhe?=
 =?us-ascii?Q?VAYauO5cf9InalO7vLAAS6mPq2Mk7xBcczssRaYaF/SgUFIjMbogIhcZIvii?=
 =?us-ascii?Q?5/cQKjtf/uueqiu3OrydPaNkY2mJEKM4gSZiqzKhIly/027G0Sq9gwiLpWol?=
 =?us-ascii?Q?OQf0u8juS5ukVljAOu66KR4evlt46EmvqG3qPMdmktUQ196DMMvvITsawWBx?=
 =?us-ascii?Q?ouGRKhybSNU+zV47Wb4OfT6HKdcA8CtAMAIJVdaeC3JqTBeXuzAYpHoWwGMX?=
 =?us-ascii?Q?atbPuUncaBdAHiqI+h8hMnQD7xjbGYuoJP0odhwmKGXKDFj4wBvS5V0/7Fiv?=
 =?us-ascii?Q?PfvWUCCzCdpU59VpVvpKkbCV01qUhl1RHIuBr3zrwVHSsATlaWnnZI1bsmlJ?=
 =?us-ascii?Q?d6Sorkw8de7HeySceTQ5TJsg2HI7E6wL5ijZSl+LCbzaoAUePjzKPgxF3kRL?=
 =?us-ascii?Q?dPwJONA8m4bkLBHR54rZ7bJ1OdML1eG8FEDrTiNa+oU3xLYGGAWqsYx5wnWY?=
 =?us-ascii?Q?wvU2tqAFf4eM2YHgwOJxE6lvrdcj3RVPdX+b2uuoqqn1+aXXj1ErMG+h14Rh?=
 =?us-ascii?Q?loWWOV7yJZjjwrKFLPD0K4xSMc66Uz/0dh6cHbNv+8rY0huLf6b5zwIeVWPw?=
 =?us-ascii?Q?fiyV/2Wvch8NdgY3IsqokXVB0B3RlqyW7wW821zazzUGi7a6o96xo0tN01yK?=
 =?us-ascii?Q?ZYD/aEyHDYvL9BiTV7hzI1TgikFFiTlGMq3ednse2k9FpRj9hhfnIy9bOme0?=
 =?us-ascii?Q?7vvytGvd1tJtJT2+foMrj8HHPEFdg2S0roZLkPN/SrrTyEf5Gh5F27g0UqSL?=
 =?us-ascii?Q?DJZNBm8FTvfxi6lBWA+NKWJjGoezOgpK4R8AKAva44SOEI98T4Euzc1G3rlG?=
 =?us-ascii?Q?w8b/QQR5VeV8+qZwfiaDaXRIG5KSd3TynQ33Hm8OdIePXgcdWwnrsAU96w/c?=
 =?us-ascii?Q?PJLhRDBB1qJ3a6R+DamW4z65W/ZhN6o4vFdXJfYZ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f109a0b-7058-4182-5349-08db9976cc9d
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2023 07:52:52.0935
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z5VNfiuvnBMW4wERvVLFBuNm7EEyrkLRVwqDYGxxm/k5ZVd+iPfy1kz9D/yjSW9vwE1zAlPi13tC3oAZwqynJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8045
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Wednesday, August 9, 2023 8:35 PM
>=20
> On Wed, Aug 09, 2023 at 09:49:16AM +0000, Tian, Kevin wrote:
> > > From: Baolu Lu <baolu.lu@linux.intel.com>
> > > Sent: Wednesday, August 9, 2023 8:22 AM
> > >
> > > On 2023/8/8 15:49, Tina Zhang wrote:
> > > > Use the helper function mm_get_pasid() to get the mm assigned pasid
> > > > value.
> > >
> > > For internal iommu drivers, perhaps we should use another helper.
> > > Something like sva_domain_get_pasid()?
> > >
> > > Suppose that the iommu drivers should have no idea about the "mm".
> > >
> >
> > Aren't all touched functions accept a struct mm_struct pointer?
>=20
> It is wrong for the driver to even ask this question.
>=20
> Domains, regardless of what they are, get attached to PASIDs. Maybe
> many PASIDs, driver doesn't get to care. SVA isn't special. Stop
> making it special.

Agree. I didn't think that far for what this series intends to achieve.

>=20
> The driver should rely on there being exactly one iommu_domain for SVA
> per mm so it can hang the mm_notifier off the iommu_domain

I'm confused. Isn't this series trying to allow multiple domains per mm?

>=20
> But otherwise invalidation for a SVA domain should be *exactly the
> same flow* as invalidation for a paging domain. It iterates over the
> attachments and generates the correct list of PASIDs and ATCs.
>=20
> Jason